December 2015 - Wine-devel - list.winehq.org

Plug and Play and Wine
by Aric Stewart 30 Dec '15

30 Dec '15

Hello All, Yay 1.8! So in discussions with Alexandre, he expressed that he would really like there to be a Plug and Play system in wine to support the HID work I have been doing. Others at WineConf also expressed a desire for a plug and play system. So I have been doing research, reading and work to try to design out how this system will work. I promised him that while I would do research and testing I would wait until after the release before initiating this conversation. We also discussed at WineConf that design processes like this should happen more out in the open so here is my proposed design, with my thinking, so that people who have interest and maybe more knowledge about parts of this than I can help improve the design. I have done some basic proof of concept coding on most of this so that I know it can work, but have flexibility. Long discussion below. The main thing I have learned is that this side of Plug and Play (The system side) is very complicated and pretty much completely undocumented. So this beginning design is going to be greatly simplified but hopefully in enough of a good framework state that it can be expanded as needed. A few definitions, these are borrowed terms but may not be specifically defined exactly the same as on windows: Bus driver : this is whatever lump of code that it talking to the underlying devices, this should be talking to platform native devices. For the purposes of our PnP the bus driver will be only really responsible for enumerating devices, detecting addition and removal of devices and being able to generate device IDs for these devices. This will all be wine code as far as I can determine. Device Driver: This is the code that is actually trying to do something with the device enumerated but the bus driver. This too will likely be wine code. Think a hid minidriver or usb.sys. Generally any supported native drivers will have to sit above this particular device driver level. But that could maybe change, we will see Plug and Play manager: This is the chunk of code that manages all the driver, devices and does the plug and play work. I have chosen to make the existing Programs/plugplay.exe be the plug and play manager. No INF processing or install: The most important part of this that is missing and that I am not addressing is anything about driver installation or inf files. Right now everything in this process is wine builtin code, so there is no need to have inf processing, and that is a seriously complicated part of this process. I have not fully figured out how we should manage the driver store and do the full driver on demand installation and such. But a basic framework can be put together without it. The Plug and Play process, (As I see it for wine) Ok, here is the meat of what is interesting. Starting at the bottom. Plug and Play bus drivers will be written for OS/X HID devices as well as udev hidraw devices. When I discussed this with Alexandre he did not feel like these need to be individual dlls, so they will be included in the plugplay.exe manager. However they will be designed in such a way that if a compelling reason why we need to pull them out becomes apparent it will not be difficult. These bus drivers will not be full device driver really, they just handle the Plug and play aspects of the bus, the device->DeviceExtension will be simply be a handle to the native device in question. The driver will only handle IRP_MJ_PNP ioctls. Having these be loaded into the plugplay.exe manager process space makes many things much easier. When the bus driver detects a new device it will call PNP_IoInvalidateDeviceRelations, and internal function inside of plugplay.exe that mirrors IoInvalidateDeviceRelations. Because the bus drivers are living inside of the plugplay manager there is no need to implement and deal with the ntoskrnl.exe version of IoInvalidateDeviceRelations. Again this will be coded to be able to be pulled out if needed. If we decide to handle any bus drivers that live outside of the plugplay.exe process space then we will need to have this functionality, probably via RPC like the service manager. Here is where the fun comes. Because we are not handling installing drivers (yet) we can just make use of the critical device store. These are drivers that, on windows, are automatically loaded on boot every time. This database is maintained in [CurrentControlSet/Control/CriticalDeviceDatabase] The keys in this registry key represent a HardwareID that will match a device. We query the IDs from the bus device’s BusQueryHardwareIDs and if we find a match (from most specific to most general) we look at that registry key. The CriticalDeviceDatabase entry will specify a [Service] value. All the first round builtin drivers will specify the [Service]. Further implementations when we start supporting inf files will also look at supporting the [ClassGUID] value where a driver inf can be specified. That Service will specify a key in [CurrentControlSet\Services]. These services will need to be [type] of 0x1 (device driver) and [start] of 0x3 (on demand), finally they will have an [ImagePath] that points to the .sys file for this driver. The plug and play manager will determine if it has loaded that driver or not, and if not then it will load the driver into its process space and call the drivers DriverEntry. Part of this will be done via the advapi service APIs to query the service and then I was planing to reuse code from winedevice.exe for the actual loading of the driver.sys into the plugplay.exe process space. With the loaded driver we then call the driver’s extension.AddDevice entry point with the new bus device. The drivers AddDevice function will be well behaved and call IoAttachDeviceToDeviceStack. The Plug and Play manager will look at the bus device after AddDevice and if there is an AttachedDevice then will proceed to call IRP_MN_START_DEVICE on the attached device. Then a IRP_MJ_POWER/IRP_MN_SET_POWER to PowerDeviceD0. It is an important point that having the bus drivers and function drivers all loaded into the same process space means that they have a common process stack for sharing memory and handles and such. Driver will expect this so if we end up having to change this we will have to deal with the complexities of the memory management. Device removal will be more simplistic. When the bus driver detects that a device has been removed then we again make a PNP_IoInvalidateDeviceRelations. Then the plug and play manager will send a IRP_MN_SURPRISE_REMOVAL followed by a IRP_MN_REMOVE_DEVICE ioctl to the AttachedDevice. That will represent the entirety of the process, as I see it on the first pass, for plug and play. Some of the many things this does not do, it does not make use of or maintain a driver store (I think maintained as keys under the [CurrentControlSet/Control/Class/<GUID>] keys). It does not do any of the complicated driver INF, install on demand work and it does not allow for new drivers to be installed via any of the installation processes. But it does not prevent this from being expanded on for next passes. Another big unanswered part of this is the integration with the Plug and Play configuration manager (cfgmgr32.dll) and all the CM_XXX functions. I am only working on the HID bus and drivers, however I feel like we could expand this pretty easily into USB or even mountmgr bus and driver architectures as we move forward. Comments? Thoughts? Anyone actually get to the end here? -aric

2 2

Re: configure: Detect MinGW-w64 Clang cross toolchain
by Alexandre Julliard 30 Dec '15

30 Dec '15

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -171,17 +171,19 @@ LIBS="$ac_wine_check_funcs_save_LIBS"]) > > dnl **** Check for a mingw program, trying the various mingw prefixes **** > dnl > -dnl Usage: WINE_CHECK_MINGW_PROG(variable,prog,[value-if-not-found],[path]) > +dnl Usage: WINE_CHECK_MINGW_PROG(variable,progs,[value-if-not-found],[path]) > dnl > AC_DEFUN([WINE_CHECK_MINGW_PROG], > [case "$host_cpu" in > i[[3456789]]86*) > ac_prefix_list="m4_foreach([ac_wine_prefix],[w64-mingw32, pc-mingw32, mingw32msvc, mingw32], > - m4_foreach([ac_wine_cpu],[i686,i586,i486,i386],[ac_wine_cpu-ac_wine_prefix-$2 ])) > + m4_foreach([ac_wine_cpu],[i686,i586,i486,i386], > + m4_foreach([ac_wine_prog],[$2],[ac_wine_cpu-ac_wine_prefix-ac_wine_prog ]))) > mingw32-$2" ;; Do we need to duplicate all the names? Or would it be sufficient to check only the w64-mingw one? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [2/2] kernel32: add tests for GetSystemPreferredUILanguages
by Marvin 30 Dec '15

30 Dec '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19262 Your paranoid android. === w1064 (32 bit locale) === locale.c:2339: Test failed: LCMapStringEx should fail with bad locale name locale.c:2340: Test failed: unexpected error code -559038737 locale.c:2431: Test failed: Expected lcid == 0, got got 00001000, error -559038737 locale.c:4154: Test failed: IsValidLocaleName should have failed locale.c:4156: Test failed: IsValidLocaleName should have failed locale.c:4521: Test failed: For id 7, expected ret == 4, got 1, error 87 locale.c:4523: Test failed: For id 7, Expected IVC, got ''

1 0

Re: [PATCH] user32: Properly handle WM_DEVICECHANGE in is_pointer_message(). (resend)
by Marvin 30 Dec '15

30 Dec '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19261 Your paranoid android. === w1064 (32 bit msg) === msg.c:6138: Test failed: Update region shouldn't be empty msg.c:6372: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6374: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6144: Test failed: Regions are different msg.c:6144: Test failed: Regions are different msg.c:6144: Test failed: Regions are different

1 0

Re: [PATCH] user32: Properly handle WM_DEVICECHANGE in is_pointer_message().
by Marvin 30 Dec '15

30 Dec '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19260 Your paranoid android. === w1064 (32 bit msg) === msg.c:6138: Test failed: Update region shouldn't be empty msg.c:6372: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6374: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6144: Test failed: Regions are different msg.c:6144: Test failed: Regions are different msg.c:6144: Test failed: Regions are different

1 0

Re: [PATCH] ole32: Properly implement OleRegGetUserType()
by Dmitry Timoshkov 30 Dec '15

30 Dec '15

> dlls/ole32/ole2.c | 85 +++++++++++++++++++++++++++++-------------------------- > 1 file changed, 45 insertions(+), 40 deletions(-) It would be helpful to know why this implementaion is considered more "proper" than an existing one, especially taking into account lack of any tests or reference to a bug report. -- Dmitry.

2 2

Re: 0001-winedbg-Add-a-debug-button-on-crash-dialog-get-rid-of-
by Jactry Zeng 29 Dec '15

29 Dec '15

Hi Changhui, I like this patch, too. '&Debug' and 'Show &Details' use a same shortcut key here. @@ -58,6 +50,7 @@ BEGIN IDC_STATIC_TXT2,"SysLink",0,27,60,224,100 DEFPUSHBUTTON "Close", IDOK, 205, 151, 60, 16, WS_TABSTOP PUSHBUTTON "Show &Details", ID_DETAILS, 140, 151, 60, 16, WS_TABSTOP + PUSHBUTTON "&Debug", ID_DEBUG, 75, 151, 60, 16, WS_TABSTOP END I think push this debug button in the left corner seems better? Maybe we also need some text in IDC_STATIC_TXT2 to let users know what it means. Thanks. 2015-12-28 17:21 GMT+08:00 Changhui LIU <liuchanghui(a)linuxdeepin.com>: > > > > > > > ------------------ > Regards, > Changhui Liu > > > > > -- Regards, Jactry Zeng

1 0

Re: 0001-winedbg-Add-a-debug-button-on-crash-dialog-get-rid-of-
by Alex Henrie 29 Dec '15

29 Dec '15

I'm pretty sure that the Debug button on the crash dialog is hidden so that people who don't know what they're doing don't try to use it. -Alex

2 1

Re: [PATCH 1/1] msvcr120: Enable MSVCRT__nextafterf when _MSVCR_VER>=120.
by Piotr Caban 29 Dec '15

29 Dec '15

Hi, On 12/28/15 08:19, YongHao Hu wrote: > dlls/msvcr120/msvcr120.spec | 6 +++--- > dlls/msvcr120_app/msvcr120_app.spec | 6 +++--- > dlls/msvcrt/math.c | 18 +++++++++--------- > 3 files changed, 15 insertions(+), 15 deletions(-) Please also update: ucrtbase/ucrtbase.spec api-ms-win-crt-math-l1-1-0/api-ms-win-crt-math-l1-1-0.spec files. Thanks, Piotr

2 2

Re: [PATCH] ole32: Zero out pointer in CreateFileMoniker() on error
by Marvin 29 Dec '15

29 Dec '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19236 Your paranoid android. === wvistau64 (32 bit moniker) === moniker: unhandled exception c0000005 at 0042A889 === w2008s64 (32 bit moniker) === moniker: unhandled exception c0000005 at 0042A889 === w7u (32 bit moniker) === moniker: unhandled exception c0000005 at 0042A889 === w7pro64 (32 bit moniker) === moniker: unhandled exception c0000005 at 0042A889 === w8 (32 bit moniker) === moniker: unhandled exception c0000005 at 0042A889 === w864 (32 bit moniker) === moniker: unhandled exception c0000005 at 0042A889 === w1064 (32 bit moniker) === moniker: unhandled exception c0000005 at 0042A889 === wvistau64 (64 bit moniker) === moniker: unhandled exception c0000005 at 00000000004241FA === w2008s64 (64 bit moniker) === moniker: unhandled exception c0000005 at 00000000004241FA === w7pro64 (64 bit moniker) === moniker: unhandled exception c0000005 at 00000000004241FA === w864 (64 bit moniker) === moniker: unhandled exception c0000005 at 00000000004241FA === w1064 (64 bit moniker) === moniker: unhandled exception c0000005 at 00000000004241FA

1 0