December 2015 - Wine-devel - list.winehq.org

Re: [PATCH] d3drm/tests: Add tests for IDirect3DRM*::LoadTexture (try 4).
by Stefan Dösinger 27 Dec '15

27 Dec '15

> Am 23.12.2015 um 16:46 schrieb Aaryaman Vasishta <jem456.vasishta(a)gmail.com>: > > + file = create_bitmap("palette.bmp", 3, 39, TRUE); > + > + hr = Direct3DRMCreate(&d3drm1); > + ok(hr == D3DRM_OK, "Cannot get IDirect3DRM interface (hr = %x)\n", hr); > + > + hr = IDirect3DRM_QueryInterface(d3drm1, &IID_IDirect3DRM2, (void **)&d3drm2); > + ok(SUCCEEDED(hr), "Cannot get IDirect3DRM2 interface (hr = %x)\n", hr); > + > + file = create_bitmap("8bpp.bmp", 100, 100, FALSE); The first line here seems to be a leftover from the last patch version. The same applies to the V3 function

2 4

Re: ntdll: add RtlCreateUserProcess stub
by Dmitry Timoshkov 27 Dec '15

27 Dec '15

Austin English <austinenglish(a)gmail.com> wrote: > +NTSTATUS WINAPI RtlCreateUserProcess(UNICODE_STRING *path, ULONG attributes, RTL_USER_PROCESS_PARAMETERS *parameters, > + PSECURITY_DESCRIPTOR *process_descriptor, PSECURITY_DESCRIPTOR *thread_descriptor, > + HANDLE parent, BOOLEAN inherit, HANDLE debug, HANDLE exception, > + PRTL_USER_PROCESS_INFORMATION info) Some of the parameters use wrong pointer information. Probably it would be better to completely avoid Pxxx prefixes and use normal pointers for all parameters? -- Dmitry.

2 1

Re: pdh: Fix prototype of PdhGetLogFileType[A/W].
by Austin English 26 Dec '15

26 Dec '15

Thanks for fixing it so quickly Sebastian. I came back from holiday and it was already done :). On Thu, Dec 24, 2015 at 4:08 PM, Sebastian Lackner <sebastian(a)fds-team.de> wrote: > Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> > --- > > As pointed out on the mailing list yesterday, the first parameter can't be a handle. > Output after this patch: > > fixme:pdh:PdhGetLogFileTypeW L"dummy.log", 0x33fd9c: stub > > dlls/pdh/pdh.spec | 4 ++-- > dlls/pdh/pdh_main.c | 8 ++++---- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/dlls/pdh/pdh.spec b/dlls/pdh/pdh.spec > index 529b92d..41900c8 100644 > --- a/dlls/pdh/pdh.spec > +++ b/dlls/pdh/pdh.spec > @@ -62,8 +62,8 @@ > @ stub PdhGetFormattedCounterArrayW > @ stdcall PdhGetFormattedCounterValue(ptr long ptr ptr) > @ stub PdhGetLogFileSize > -@ stdcall PdhGetLogFileTypeA(ptr ptr) > -@ stdcall PdhGetLogFileTypeW(ptr ptr) > +@ stdcall PdhGetLogFileTypeA(str ptr) > +@ stdcall PdhGetLogFileTypeW(wstr ptr) > @ stub PdhGetLogSetGUID > @ stub PdhGetRawCounterArrayA > @ stub PdhGetRawCounterArrayW > diff --git a/dlls/pdh/pdh_main.c b/dlls/pdh/pdh_main.c > index 036d28b..8854fd7 100644 > --- a/dlls/pdh/pdh_main.c > +++ b/dlls/pdh/pdh_main.c > @@ -1273,17 +1273,17 @@ PDH_STATUS WINAPI PdhSetDefaultRealTimeDataSource( DWORD source ) > /*********************************************************************** > * PdhGetLogFileTypeA (PDH.@) > */ > -PDH_STATUS WINAPI PdhGetLogFileTypeA(PDH_HLOG log, DWORD *type) > +PDH_STATUS WINAPI PdhGetLogFileTypeA(const char *log, DWORD *type) > { > - FIXME("%p, %p: stub\n", log, type); > + FIXME("%s, %p: stub\n", debugstr_a(log), type); > return PDH_NOT_IMPLEMENTED; > } > > /*********************************************************************** > * PdhGetLogFileTypeW (PDH.@) > */ > -PDH_STATUS WINAPI PdhGetLogFileTypeW(PDH_HLOG log, DWORD *type) > +PDH_STATUS WINAPI PdhGetLogFileTypeW(const WCHAR *log, DWORD *type) > { > - FIXME("%p, %p: stub\n", log, type); > + FIXME("%s, %p: stub\n", debugstr_w(log), type); > return PDH_NOT_IMPLEMENTED; > } > -- > 2.6.4 > > -- -Austin

1 0

Re: [PATCH 7/7] dwrite: Fix identical ranges merging
by Marvin 26 Dec '15

26 Dec '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19166 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 6/7] dwrite: Locale layout ranged attribute is case-insensitive
by Marvin 26 Dec '15

26 Dec '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19165 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 5/7] dwrite: Store optical alignment property
by Marvin 26 Dec '15

26 Dec '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19164 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 4/7] dwrite: Store last line wrapping property
by Marvin 26 Dec '15

26 Dec '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19163 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/7] dwrite: Store per-range typography property
by Marvin 26 Dec '15

26 Dec '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19162 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/7] dwrite/tests: One more test for duplicates in IDWriteTypography
by Marvin 26 Dec '15

26 Dec '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19161 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: mshtml: Add IHTMLXMLHttpRequest::responseXML() method implementation. (resend)
by Nikolay Sivov 25 Dec '15

25 Dec '15

On 25.12.2015 10:30, Zhenbo Li wrote: > +static void test_illegal_xml(IXMLDOMDocument *xmldom) > +{ > + IXMLDOMNode *first, *last; > + VARIANT variant; > + HRESULT hres; > + BSTR bstr; > + > + hres = IXMLDOMDocument_get_baseName(xmldom, NULL); > + ok(hres == E_INVALIDARG, "Expect E_INVALIDARG, got %08x\n", hres); > + hres = IXMLDOMDocument_get_baseName(xmldom, &bstr); > + ok(hres == S_FALSE, "get_baseName failed: %08x\n", hres); > + ok(bstr == NULL, "bstr(%p): %s\n", bstr, wine_dbgstr_w(bstr)); > + SysFreeString(bstr); > + > + hres = IXMLDOMDocument_get_dataType(xmldom, NULL); > + ok(hres == E_INVALIDARG, "Expect E_INVALIDARG, got %08x\n", hres); > + hres = IXMLDOMDocument_get_dataType(xmldom, &variant); > + ok(hres == S_FALSE, "get_dataType failed: %08x\n", hres); > + ok(V_VT(&variant) == VT_NULL, "got %s\n", debugstr_variant(&variant)); > + VariantClear(&variant); > + > + hres = IXMLDOMDocument_get_text(xmldom, &bstr); > + ok(!strcmp_wa(bstr, ""), "text = %s\n", wine_dbgstr_w(bstr)); > + SysFreeString(bstr); > + > + hres = IXMLDOMDocument_get_firstChild(xmldom, NULL); > + ok(hres == E_INVALIDARG, "Expect E_INVALIDARG, got %08x\n", hres); > + > + first = (void*)0xdeadbeef; > + hres = IXMLDOMDocument_get_firstChild(xmldom, &first); > + ok(hres == S_FALSE, "get_firstChild failed: %08x\n", hres); > + ok(first == NULL, "first != NULL\n"); > + > + last = (void*)0xdeadbeef; > + hres = IXMLDOMDocument_get_lastChild(xmldom, &last); > + ok(hres == S_FALSE, "get_lastChild failed: %08x\n", hres); > + ok(last == NULL, "last != NULL\n"); > +} It makes no sense to test every method on empty tree, test for text string. > + hres = IXMLDOMDocument_QueryInterface(xmldoc, &IID_IObjectSafety, (void**)&safety); > + assert(SUCCEEDED(hres)); > + hres = IObjectSafety_SetInterfaceSafetyOptions(safety, NULL, > + INTERFACESAFE_FOR_UNTRUSTED_CALLER | INTERFACESAFE_FOR_UNTRUSTED_DATA | INTERFACE_USES_SECURITY_MANAGER, > + INTERFACESAFE_FOR_UNTRUSTED_CALLER | INTERFACESAFE_FOR_UNTRUSTED_DATA | INTERFACE_USES_SECURITY_MANAGER); > + assert(SUCCEEDED(hres)); > + IObjectSafety_Release(safety); This looks weird to me, why the asserts? Did Jacek suggest that?

2 2