March 2015 - Wine-devel - list.winehq.org

Re: [PATCH 3/3] dwrite: Fix GetClusterMetrics() return value
by Marvin 13 Mar '15

13 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12139 Your paranoid android. === wvistau64 (32 bit layout) === layout.c:1056: Test failed: got 0x80004002 layout.c:1109: Test failed: got 0x80004002 === w2008s64 (32 bit layout) === layout.c:1056: Test failed: got 0x80004002 layout.c:1109: Test failed: got 0x80004002 === w7u (32 bit layout) === layout.c:1109: Test failed: got 0x80004002 === wvistau64 (64 bit layout) === layout.c:1056: Test failed: got 0x80004002 layout.c:1109: Test failed: got 0x80004002 === w2008s64 (64 bit layout) === layout.c:1056: Test failed: got 0x80004002 layout.c:1109: Test failed: got 0x80004002

1 0

Re: [PATCH 2/3] dwrite: Store vertical orientation property
by Marvin 13 Mar '15

13 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12138 Your paranoid android. === wvistau64 (32 bit layout) === layout.c:1057: Test failed: got 0x80004002 layout.c:1110: Test failed: got 0x80004002 === w2008s64 (32 bit layout) === layout.c:1057: Test failed: got 0x80004002 layout.c:1110: Test failed: got 0x80004002 === w7u (32 bit layout) === layout.c:1110: Test failed: got 0x80004002 === wvistau64 (64 bit layout) === layout.c:1057: Test failed: got 0x80004002 layout.c:1110: Test failed: got 0x80004002 === w2008s64 (64 bit layout) === layout.c:1057: Test failed: got 0x80004002 layout.c:1110: Test failed: got 0x80004002

1 0

Re: [PATCH 1/3] dwrite: Store pair kerning range attribute
by Marvin 13 Mar '15

13 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12137 Your paranoid android. === wvistau64 (32 bit layout) === layout.c:1057: Test failed: got 0x80004002 === w2008s64 (32 bit layout) === layout.c:1057: Test failed: got 0x80004002 === wvistau64 (64 bit layout) === layout.c:1057: Test failed: got 0x80004002 === w2008s64 (64 bit layout) === layout.c:1057: Test failed: got 0x80004002

1 0

Re: wininet: accept Version in cookies
by Sebastian Lackner 13 Mar '15

13 Mar '15

On 13.03.2015 07:26, Daniel Lehman wrote: > > "version=" are 8 chars, why do you compare only the first 7?

2 3

Re: ole32: Fix sanity check timeout.
by Sebastian Lackner 12 Mar '15

12 Mar '15

On 12.03.2015 20:56, Vincent Povirk wrote: > I meant for this to check once every 0.5 seconds, not after every lock > attempt that happens at least 0.5 seconds since the loop started. It > shouldn't hurt anything, but I don't think it's worth checking so > frequently. > > > > Isn't this basically identical to http://source.winehq.org/git/wine.git/patch/66e8060204c91d37ee6aef078d779b7… ?

2 1

Re: [PATCH] null.sys: Added stub dll.
by Alexandre Julliard 12 Mar '15

12 Mar '15

Qian Hong <qhong(a)codeweavers.com> writes: > First part for https://bugs.winehq.org/show_bug.cgi?id=38107 I don't see why you need a driver for this. -- Alexandre Julliard julliard(a)winehq.org

5 4

My Ideas for GSoC 2015
by Zhenbo Li 12 Mar '15

12 Mar '15

Hello, everyone I'm Zhenbo Li, a college student who participated in GSoC 2014 for mshtml.dll. Here are some ideas for GSoC 2015. 1. IDropTargetHelper ================== This interface is to display images [1]. I'm sure that it is necessary for VPT[2], and I guess implementing this interface will contribute to programs like 7zip. Although IDropTargetHelper is a useful interface, I haven't found a proper demo(most demos depend on MFC). So I'm writing a simple demo for this interface[3], with no MFC or .NET code. 2. IXMLHttpRequest ================== XMLHttpRequest is used heavily in AJAX programming.[4] Wine has implemented most of it in msxml component, but it's a stub in mshtml. Most js code doesn't treat wine IE as IE6 or earlier, so they will not choost ActiveX[5] to work around it(like Firebug Lite[6]) 3. sessionStorage =============== IHTMLStorage[7] is used widely, including Firebug Lite[6]. A well-implemented IHTMLStorage interface should support both sessionStorage and localStorage. I tried to write a hack, but found that it may be necessary to adjust wine-gecko code to support that(Thank Jacek). Therefore, implementing sessionStorage can be the first step of implementing localStorage, and it can be an example for WebIDL binding for further development. These are my humble ideas for GSoC 2015, and I'm glad to choose one of them as my proposal, if they meet the criteria for GSoC. Also, it is my honor if my ideas make a positive effect on other GSoC students. Thank you for reading this mail. I'm looking forward to your feedback. [1]: https://msdn.microsoft.com/en-us/library/windows/desktop/bb762028%28v=vs.85… [2]: http://virtualplaytable.com/ [3]: https://gitcafe.com/endle/IDrop_Helper_Example [4]: https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest [5]: http://en.wikipedia.org/wiki/XMLHttpRequest#Support_in_Internet_Explorer_ve… [6]: https://getfirebug.com/firebuglite [7]: https://msdn.microsoft.com/en-us/library/cc288313%28v=vs.85%29.aspx

1 1

Re: [PATCH 5/5] ddraw/tests: r200 ignores the alpha channel when matching color keys.
by Marvin 12 Mar '15

12 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12108 Your paranoid android. === w8 (32 bit ddraw1) === ddraw1.c:6292: Test failed: Got unexpected color 0x000000ff. ddraw1.c:6296: Test failed: Got unexpected color 0x00000080.

2 1

Re: [PATCH] vbscript: Implemented Asc(try 4)
by Piotr Caban 12 Mar '15

12 Mar '15

On 03/04/15 19:59, Shuai Meng wrote: > Change log: > Free 'bstr' only when it comes from to_string(). > --- > dlls/vbscript/global.c | 26 ++++++++++++++++++++++++-- > dlls/vbscript/tests/api.vbs | 42 > ++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 66 insertions(+), 2 deletions(-) This function needs to convert the WCHAR to correct character set. In order to easily write a test for it ChrW needs to be implemented first. The test may e.g. look like this: Asc(ChrW(261)) Your implementation will return 261 in this case, on windows it produces 97. Cheers, Piotr

2 2

Re: setupapi: Implement SetupOpenLog(), SetupLogErrorA(), SetupLogErrorW(), SetupCloseLog() (resend)
by Nikolay Sivov 12 Mar '15

12 Mar '15

On 11.03.2015 22:46, Pierre Schweitzer wrote: > +BOOL WINAPI SetupLogErrorW(LPCWSTR MessageString, LogSeverity Severity) > +{ > + BOOL ret; > + static const WCHAR null[] = {'(','n','u','l','l',')',0}; > + DWORD written; > + DWORD len; > + > + EnterCriticalSection(&setupapi_cs); > + > + if (setupact == INVALID_HANDLE_VALUE || setuperr == INVALID_HANDLE_VALUE) > + { > + LeaveCriticalSection(&setupapi_cs); > + SetLastError(ERROR_FILE_INVALID); > + return FALSE; > + } > + > + if (MessageString == NULL) > + MessageString = null; > + > + len = lstrlenW(MessageString) * sizeof(WCHAR); > + > + ret = WriteFile(setupact, MessageString, len, &written, NULL); > + if (!ret) > + { > + LeaveCriticalSection(&setupapi_cs); > + return ret; > + } > + > + if (Severity >= LogSevMaximum) > + { > + LeaveCriticalSection(&setupapi_cs); > + return FALSE; > + } > + > + if (Severity > LogSevInformation) > + ret = WriteFile(setuperr, MessageString, len, &written, NULL); > + > + LeaveCriticalSection(&setupapi_cs); > + > + return ret; > +} It'd be probably shorter if you had return with unlock call and one place and just jumped there. Also it's questionable if you need to return when first WriteFile() failed without trying to write to error log. I don't remember if I said it last time, but I don't see a reason to add a new file just for couple of functions. > + GetWindowsDirectoryW(win, MAX_PATH); > + lstrcpyW(path, win); > + lstrcatW(path, setupactlog); This never changes, so you can init it once. > + setupact = CreateFileW(path, GENERIC_WRITE, FILE_SHARE_WRITE | FILE_SHARE_READ, > + NULL, OPEN_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL); > + if (setupact == INVALID_HANDLE_VALUE) > + { > + LeaveCriticalSection(&setupapi_cs); > + return FALSE; > + } > + > + SetFilePointer(setupact, 0, NULL, FILE_END); Will FILE_APPEND_DATA work in this case? > + if (setupact != INVALID_HANDLE_VALUE && setuperr != INVALID_HANDLE_VALUE) > + { > + LeaveCriticalSection(&setupapi_cs); > + SetLastError(ERROR_ALREADY_INITIALIZED); > + return TRUE; > + } Setting error here makes sense as tests show. > + SetLastError(ERROR_ALREADY_EXISTS); > + return TRUE; But this one looks redundant. > + ret = SetupLogErrorW((LPCWSTR)L"Test without opening\r\n", LogSevInformation); Don't use L"" please. > + SetLastError(0xdeadbeef); > + ret = SetupLogErrorW(NULL, LogSevInformation); > + error = GetLastError(); > + if (!ret) ok(error == ERROR_INVALID_PARAMETER, "got wrong error: %d\n", error); /* Win Vista + */ > + else ok(ret, "SetupLogError failed\n"); This makes no sense, is it supposed to fail or not? Same for new test file - I think you can add those test in some existing file.

2 3