March 2015 - Wine-devel - list.winehq.org

CMD - implement more robust parser
by Péter Urbanovics 11 Mar '15

11 Mar '15

Hi, I am Peter. I read about this (Google Summer of Code) project "CMD - implement more robust parser" and I am interested. What should I do to prepare for this project? How can I contact with the mentor Jason Edmeades?

2 1

CMD - implement more robust parser
by Abhishek Srivastava 11 Mar '15

11 Mar '15

I am Abhishek and I am interested in project titled "CMD - implement more robust parser". I am new to The wine project and trying to fix few available bugs on BugList. Which kind of bugs should I approach first? And how can I contact mentor for project Mr. Jason Edmeades?

2 1

Re: [PATCH 5/7] gdiplus: Convert animated gif to PixelFormat32bppARGB on load
by Marvin 11 Mar '15

11 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12083 Your paranoid android. === wxppro (32 bit image) === image.c:2463: Test failed: Expected 24, got 12 === w2003std (32 bit image) === image.c:2463: Test failed: Expected 24, got 12 === wvistau64 (32 bit image) === image.c:2463: Test failed: Expected 24, got 12 === w2008s64 (32 bit image) === image.c:2463: Test failed: Expected 24, got 12 === wvistau64 (64 bit image) === image.c:2463: Test failed: Expected 24, got 12 === w2008s64 (64 bit image) === image.c:2463: Test failed: Expected 24, got 12

1 0

Re: [PATCH] user32: Merge SCROLL_DrawInterior and SCROLL_DrawInterior_9x.
by Alexandre Julliard 11 Mar '15

11 Mar '15

Mark Harmstone <hellas(a)burntcomma.com> writes: > The scrollbar-drawing code in user32 contains two nearly-identical functions, > SCROLL_DrawInterior and SCROLL_DrawInterior_9x, the latter of which is only > called when drawing a moving thumb. This patch cleans up the code by merging > them into one function. It's not really cleaner with the extra boolean and the reentrant calls to the same function. You probably want to restructure it some more. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msvcp90: Add istream::operator>>complex implementation and tests.( try 3)
by YongHao Hu 11 Mar '15

11 Mar '15

Hi, I have a better idea to write the test case just after sending this patch. Now I'm planing to submit a new patch with current version of implementation and an improved version of test. Please don't commit this version. However, I think the implementation itself is fine now, could you comment on the implementation part? On 2015年03月11日 14:47, YongHao Hu wrote: > Try3: Thanks QianHong > - Superseded Patch 109782, 109684 > - Avoid unnecessary else block. > > Try2: Thanks Piotr > - Delete useless check. > - Make the code more readable. > > --- > dlls/msvcp71/msvcp71.spec | 12 ++-- > dlls/msvcp80/msvcp80.spec | 12 ++-- > dlls/msvcp90/ios.c | 177 > ++++++++++++++++++++++++++++++++++++++++++++++ > dlls/msvcp90/msvcp90.spec | 12 ++-- > dlls/msvcp90/tests/ios.c | 151 +++++++++++++++++++++++++++++++++++++++ > 5 files changed, 346 insertions(+), 18 deletions(-) > >

2 1

Re: msvcp90: Add istream::operator>>complex implementation and tests.
by Piotr Caban 11 Mar '15

11 Mar '15

Hi, On 03/07/15 12:13, YongHao Hu wrote: > +/* ??$?5MDU?$char_traits(a)D@std@@@std@@YAAAV?$basic_istream(a)DU?$char_traits(a)D@std@@@0(a)AAV10@AAV?$complex(a)M@0@@Z */ > +/* ??$?5MDU?$char_traits(a)D@std@@@std@@YAAEAV?$basic_istream(a)DU?$char_traits(a)D@std@@@0(a)AEAV10@AEAV?$complex(a)M@0@@Z */ > +basic_istream_char* __cdecl basic_istream_char_read_complex_float(basic_istream_char *this, complex_float *v) > +{ > + float r; > + basic_ios_char *base = basic_istream_char_get_basic_ios(this); > + if(ios_base_good(&base->base)) { There's no need to check the stream state here, it will be done by stream reading functions. > + ws_basic_istream_char(this); > + if(basic_istream_char_peek(this) == '(') { > + basic_istream_char_get(this); > + basic_istream_char_read_float(this, &r); > + if(!ios_base_fail(&base->base)) { I think that the implementation will be more readable if you just return on error here. The if(!ios_base_fail(...)) line can be changed to: if(ios_base_fail(&base->base)) return this; You don't need to set failbit in this case because it's already set by basic_istream_char_read_float. The same applies to some other ios_base_fail() checks. Thanks, Piotr

2 1

Re: include: don't redefine _EVENT_TYPE or _TIMER_TYPE (resend)
by Alexandre Julliard 11 Mar '15

11 Mar '15

Austin English <austinenglish(a)gmail.com> writes: > Previous try was dropped without comment. I guess I don't see where you are going with that. ntdef.h is supposed to contain a ton of definitions that are already in other headers, are you planning to add a #ifdef around every single one of them? That doesn't seem very workable. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/5] d3d9/tests: Add a test for UpdateTexture.
by Marvin 10 Mar '15

10 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12038 Your paranoid android. === w8 (32 bit visual) === visual.c:18055: Test failed: Got unexpected color 0x00000000, case 0, 6. visual.c:18055: Test failed: Got unexpected color 0x00303000, case 0, 7. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 0, 10. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 0, 12. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 1, 1. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 1, 2. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 1, 3. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 1, 4. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 1, 5. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 1, 6. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 1, 7. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 1, 8. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 1, 10. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 1, 12. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 2, 1. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 2, 2. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 2, 3. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 2, 4. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 2, 5. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 2, 6. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 2, 7. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 2, 8. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 2, 10. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 2, 12.

2 1

Re: [PATCH 3/5] d3d8/tests: Add a test for UpdateTexture.
by Marvin 10 Mar '15

10 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12039 Your paranoid android. === w8 (32 bit visual) === visual.c:5983: Test failed: Got unexpected color 0x00000000, case 0, 6. visual.c:5983: Test failed: Got unexpected color 0x00303000, case 0, 7. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 0, 10. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 0, 12. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 1, 1. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 1, 2. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 1, 3. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 1, 4. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 1, 5. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 1, 6. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 1, 7. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 1, 8. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 1, 10. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 1, 12. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 2, 1. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 2, 2. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 2, 3. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 2, 4. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 2, 5. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 2, 6. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 2, 7. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 2, 8. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 2, 10. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 2, 12.

1 0

Re: [PATCH 2/3] gdiplus: Convert gif frame to DIB on load
by Vincent Povirk 10 Mar '15

10 Mar '15

I don't like that we essentially have another instance here of the bitmap create/destroy logic. I think I'd rather we create another bitmap than use the existing one with new image data. It's not clear to me that decode_image_wic is even worth calling. Most of the logic in there is for reading image bits, and couldn't we in theory use blit_gif_frame or select_image_gif from the next patch for that? Or, if we wanted to add another hook to it, we could ask decode_image_wic to not attempt to find a matching format, and instead fall back on the conversion to 32bppARGB.

2 1