April 2015 - Wine-devel - list.winehq.org

i3, i5, i7 benchmarks building wine-1.6.2
by Dan Kegel 14 Apr '15

14 Apr '15

Hi folks, in case anyone's wondering how fast a cheap computer builds wine these days, I did a little benchmark on the family computers. The benchmark was: $ sudo apt-get build-dep wine $ apt-get source wine $ cd wine1.6-1.6.2/ $ time debuild -b -uc -us $ dh clean $ time debuild -b -uc -us -j4 Results: Vintage CPU Ubuntu Time -j1 Time -j4 Details (model, barebones price) 2015 i3-4130 15.04b2 23m31s 12m16s http://kegel.com/new-computer-2015.html (ts140, $250, no drive) 2014 i5-4460 14.04 21m25s 8m12s http://kegel.com/new-computer-2014.html (h530, $426 including 1TB drive) 2010 i7-920 14.10 35m47s 13m44s http://kegel.com/new-computer-2010.html (ASRock x58 Extreme, $800, no drive) I'll probably semi-retire the ol' i7 and replace it with another ts140 soon, partly to save power, and partly to beef up my LAN party capabilities :-) (My new house has been averaging 22 kwh/day lately; switching from the i7 to the i3 will save something like 0.5 kwh/day on days when I work at home. Hope to add solar panels and go carbon-neutral sometime, but gotta fix the chimneys, replace furnaces with heat pumps, insulate, and replace the roof first.) - Dan

1 0

Re: dsound: Fix conning formula to correctly interpolate volume.
by Andrew Eikum 13 Apr '15

13 Apr '15

On Sat, Apr 11, 2015 at 03:44:14PM +0000, Igor Kotrasinski wrote: > > Original formula is obviously wrong (plug in a large flAngle and a small cone difference). This one does correct linear interpolation. Makes sense to me. Thanks! Andrew

1 0

Re: [PATCH] dsound: Stricter validation for formats in secondary buffers
by Marvin 13 Apr '15

13 Apr '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12777 Your paranoid android. === wxppro (32 bit dsound) === dsound.c:1401: Test failed: secondary: SetFormat: 88780032 === w2003std (32 bit dsound) === dsound.c:1401: Test failed: secondary: SetFormat: 88780032

1 0

Re: [PATCH] shell32: Add more knownfolders
by Marvin 13 Apr '15

13 Apr '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12776 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: winejoystick.dev: Add Graphics Driver connection for winejoystick.drv
by Charles Davis 13 Apr '15

13 Apr '15

I do not agree with this particular direction. You do realize that some people on Mac OS still use the X11 driver (e.g. to get virtual desktop support), right? With these patches, these people suddenly won’t have any joystick support at all. Don’t get me wrong, I still think putting all the joystick code in one place is the right thing to do. I just don’t think that one place should be the graphics driver. Chip

5 7

Re: mshtml: Remove nsIDOMWindowUtils::SetCriticalDisplayPortForElement.
by Alexandre Julliard 13 Apr '15

13 Apr '15

Thomas Faber <thomas.faber(a)reactos.org> writes: > This function is no longer present in Wine Gecko, so this re-aligns > the vtable. > > See https://www.winehq.org/pipermail/wine-devel/2015-April/107319.html It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M mshtml.dll -p mshtml_test.exe.so activex && touch activex.ok activex.c:1320: Test failed: unexpected call InPlaceDeactivate activex.c:1066: Test failed: unexpected call Close activex.c:1041: Test failed: unexpected call SetClientSite_NULL activex.c:1761: Test failed: OnUIActivate failed: 8000ffff activex.c:1716: Test failed: GetContainer failed: 8000ffff activex.c:1717: Test failed: container == NULL wine: Unhandled page fault on read access to 0x00000000 at address 0x7ecb5066 (thread 003a), starting debugger... -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: wininet: Avoid four instances of "logical not is only applied to the to the left hand side".
by Henri Verbeet 13 Apr '15

13 Apr '15

On 12 April 2015 at 23:04, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > Indrek suggested that in this specific case the alternate approach > below also should work, so let me provide this as an option in case It probably would, but note that that doesn't do quite the same thing. BOOL values aren't restricted to TRUE/FALSE, so in principle there's no reason "ret" couldn't be e.g. ~0u. You'd need something like "!ret != !ie10_cache" to preserve the original behaviour, but I'm not sure that's really much better.

2 2

Re: winecfg: add all Windows versions and accompanying error message (try 3)
by Andrew Eikum 12 Apr '15

12 Apr '15

On Thu, Apr 09, 2015 at 05:42:36PM -0700, Jason Overland wrote: > @@ -399,9 +401,49 @@ static void on_remove_app_click(HWND dialog) > SendMessageW(GetParent(dialog), PSM_CHANGED, (WPARAM) dialog, 0); > } > > +static INT_PTR WINAPI win_ver_error_dlg_proc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam) This function should be guarded by an #ifdef. On my 32-bit build, I get: appdefaults.c:404:90: warning: ‘win_ver_error_dlg_proc’ defined but not used [-Wunused-function] > @@ -159,6 +159,22 @@ BEGIN > COMBOBOX IDC_WINVER,100,194,145,56,CBS_DROPDOWNLIST | WS_VSCROLL | WS_TABSTOP > END > > +IDD_WINVERERROR DIALOGEX 100, 100, 238, 95 > +STYLE DS_SETFONT | DS_MODALFRAME | DS_FIXEDSYS | WS_POPUP | WS_CAPTION | WS_SYSMENU > +CAPTION "Error: Invalid selection" > +FONT 8, "MS Shell Dlg" > +BEGIN > + LTEXT "This Wine prefix is built to support 64 bit applications. \ > + Because the Windows version you selected does not support 64 bit applications, \ > + this prefix cannot be configured to mimic that version of Windows.", > + IDC_STATIC,5,5,220,40 > + CONTROL "Please refer to \"How do I create a 32 bit wineprefix on a 64 bit system?\" \ > + in the \"Using Wine\" section of the <a href=\"http://wiki.winehq.org/FAQ\">Wine FAQ</a> \ > + for instructions on how to create a 32 bit Wine prefix.", > + IDC_WIN_VER_TEXT,"SysLink",0,5,40,220,70 For some reason, this renders without a space between "the" and the "Wine FAQ" link. Also half of the last 'x' and the period are cut off. It could be an issue on my system. I'm not very familiar with how RC files work. Other than those issues, it seems to work as intended. Andrew

3 2

Re: wined3d: Load ModelView matrix for glLightfv calls.
by Matteo Bruni 11 Apr '15

11 Apr '15

2015-04-11 17:16 GMT+02:00 Joachim Priesner <joachim.priesner(a)web.de>: > Analogous to the light() function in state.c, the correct ModelView matrix > has to be loaded when glLightfv is called. The code to load/restore the > matrix is copied from there. > --- > dlls/wined3d/glsl_shader.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c > index 1a1b6b0..2422982 100644 > --- a/dlls/wined3d/glsl_shader.c > +++ b/dlls/wined3d/glsl_shader.c > @@ -7208,6 +7208,11 @@ void glsl_vertex_pipe_view(struct wined3d_context *context, const struct wined3d > > context->constant_update_mask |= WINED3D_SHADER_CONST_FFP_MODELVIEW; > > + /* Light settings are affected by the ModelView transform in OpenGL, the View transform in Direct3D. */ > + gl_info->gl_ops.gl.p_glMatrixMode(GL_MODELVIEW); > + gl_info->gl_ops.gl.p_glPushMatrix(); > + gl_info->gl_ops.gl.p_glLoadMatrixf(&state->transforms[WINED3D_TS_VIEW]._11); > + > for (k = 0; k < gl_info->limits.lights; ++k) > { > if (!(light = state->lights[k])) > @@ -7218,6 +7223,8 @@ void glsl_vertex_pipe_view(struct wined3d_context *context, const struct wined3d > checkGLcall("glLightfv dirn"); > } > > + gl_info->gl_ops.gl.p_glPopMatrix(); > + > for (k = 0; k < gl_info->limits.clipplanes; ++k) > { > if (!isStateDirty(context, STATE_CLIPPLANE(k))) > -- > 1.8.4.5 AFAICS this patch is correct. Thank you Joachim!

1 0

Re: rpcrt4/tests: Fix a minor leak (Valgrind)
by Marvin 11 Apr '15

11 Apr '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12764 Your paranoid android. === wvistau64 (64 bit ndr_marshall) === No test summary line found === w2008s64 (64 bit ndr_marshall) === No test summary line found

1 0