April 2015 - Wine-devel - list.winehq.org

dwrite font family issue
by Julius Schwartzenberg 09 Apr '15

09 Apr '15

Hi, On #winehq there was a discussion on Monday as I was trying to get Samsung Smart View 2.0 to run. (DotNOT 4.5 application requiring Windows 7/8.) I would report back on my findings. Anastasius Focht figured it was running into a problem discovering a suitable font (family). Here is a patch I came up with which lets the program continue. I'm not sure whether this is a correct fix however. What is happening is that in 'dlls/dwrite/font.c: collection_find_family' the name argument is completely uppercase. This is then compared to buffer which will contain a similar string at some point but with regular casing. Before that however I see the string passed with its original casing like this: 0009:Call KERNEL32.LCMapStringEx(00000000,00000200,0172c79c L"Arial",00000005,0172c7b4,00000005,00000000,00000000,001908b8) ret=00aaa471 0009:fixme:nls:LCMapStringEx unsupported lparam 1908b8 0009:Ret KERNEL32.LCMapStringEx() retval=00000005 ret=00aaa471 0009:trace:dwrite:dwritefontcollection_FindFamilyName (0x1966e8)->(L"ARIAL" 0x33be0c 0x33be08) I added two TRACE calls myself to print the values of name & buffer which gives: 0009:trace:dwrite:collection_find_family name=L"ARIAL" and later: 0009:trace:dwrite:collection_find_family buffer=L"Arial" The call to KERNEL32.LCMapStringEx may suggest that the casing is actually lost unintentionally. Thanks, Julius

2 1

Re: [PATCH 5/5] wined3d: Set color keys through the command stream.
by Henri Verbeet 08 Apr '15

08 Apr '15

On 6 April 2015 at 00:28, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +#define WINED3D_CKEY_REMOVE 0x80000000 > + It seems unfortunate to define part of the flags in include/wine/wined3d.h and part of the flags in dlls/wined3d/cs.c. You'd probably also want to mask out private flags in wined3d_cs_emit_set_color_key(). Ultimately though, why do you need this? Most of the CS ops operate on a wined3d_state structure, which is mirrored between the CS and the device, and (in theory) functions get passed the appropriate one depending on whether they're running from the CS or not. This one is different in that it operates on a texture, and anything that would need to read the color key would then need to either wait for the texture to become idle, or run from the CS itself. Perhaps that's ok, but it's more of a fundamental design decision than this commit makes it seem.

2 3

Re: [PATCH 2/2] shell32: Add more knownfolders
by Marvin 08 Apr '15

08 Apr '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12722 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: winecfg: improve user experience by adding all Windows versions and accompanying error message
by Jason Overland 08 Apr '15

08 Apr '15

Is there anything I can do to improve this patch? Thanks, Jason On 03/26/2015 10:03 PM, Jason Overland wrote: > Hi, > This patch is a resubmission of and supersedes my previous patch "winecfg: add note about 32 bit prefixes to dialog". Thanks to everyone who provided feedback on that one. > > In this patch, winecfg's Application settings tab now includes all Windows versions in the combobox. If the user is running from a 64 bit prefix and selects a version of Windows that requires a 32 bit prefix, the selection will revert to the previous selection and a modal dialog containing an error message will appear: > > """ > This Wine prefix is built to support 64 bit applications. Because the Windows version you selected does not support 64 bit applications, this prefix cannot be configured to mimic that version of Windows. > > Please refer to "How do I create a 32 bit wineprefix on a 64 bit system?" in the "Using Wine" section of the Wine FAQ (http://wiki.winehq.org/FAQ) for instructions on how to create a 32 bit Wine prefix. > """ > > In addition, I noticed two File Open dialogs in winecfg which should be modal but are not modal. I made these modal by setting the appropriate owner window. While a separate issue, this seemed like a trivial enough change to include in this patch. >

3 3

Re: [1/3] ws2_32/tests: Add some more select() related tests
by Marvin 08 Apr '15

08 Apr '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12715 Your paranoid android. === w7u (32 bit sock) === sock.c:7148: Test failed: bytesReturned isn't supposed to be 1 sock.c:7172: Test failed: GetOverlappedResult failed, error 0

1 0

Re: dinput: Add JoystickID to the Instance Name
by Dmitry Timoshkov 07 Apr '15

07 Apr '15

Aric Stewart <aric(a)codeweavers.com> wrote: > + if (SUCCEEDED(IDirectInputDevice2_GetProperty(iface, DIPROP_JOYSTICKID, (LPDIPROPHEADER)&pd))) > + index = pd.dwData; Please find a way to avoid the cast. > + if (SUCCEEDED(IDirectInputDevice2_GetProperty(iface, DIPROP_JOYSTICKID, (LPDIPROPHEADER)&pd))) > + index = pd.dwData; Same here. > + snprintf(buffer, MAX_PATH, "Joystick %d", index); 'index' is unsigned, sizeof() instead of a hardcoded value is better. -- Dmitry.

1 0

Problem receiving UDP broadcast on wxppro and w2008s64
by Bruno Jesus 07 Apr '15

07 Apr '15

Hi, Francois, I hope you can help me in this situation. The patch attached to bug 31994 [1] (compiled version at [2]) runs fine in most testbot machines (tested dozens of times) and my personal XP machine, but for some reason it doesn't work in xppro and w2008s64. The test creates 2 UDP sockets and send a broadcast from socket A to the network where B is bound, but the broadcasted packet never is received by B resulting in test timeout due to recvfrom never getting data. According to [3] all testbots share similar IP addresses like and I can't imagine a reason for them not to work: wxppro: testing broadcast for interface IP 10.42.42.134 (don't work) w2003std: testing broadcast for interface IP 10.42.42.140 (works) wvistau64: testing broadcast for interface IP 10.42.42.138 (works) w2008s64: testing broadcast for interface IP 10.42.42.216 (don't work) Any ideas? I wonder if it could be a firewall. The test also works fine in NT4. [1] https://bugs.winehq.org/attachment.cgi?id=51182 [2] https://testbot.winehq.org/GetFile.pl?JobKey=12594&StepKey=1 [3] https://testbot.winehq.org/JobDetails.pl?Key=12591 Best Regards, Bruno

2 5

Re: locale: [1/1] patch - 0x10000000 flag is NORM_STOP_ON_NULL (plus test fix)
by Marvin 07 Apr '15

07 Apr '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12697 Your paranoid android. === w2000pro (32 bit locale) === locale.c:1776: Test failed: Without NORM_STOP_ON_NULL flag - strings `don\0a` (5) and `don\0b` (5) expected CSTR_LESS_THAN, got 2

1 0

CoInternetParseUrl and concepts explanation.
by Philippe Groarke 06 Apr '15

06 Apr '15

Hello, I am currently exploring Wine code base looking for low hanging fruits I can contribute to. I think CoInternetParseUrl and other URLMon stubs seemed easy enough I want to try and implement some. I also see many URLMon stubs when using Wine for games and applications. In CoInternetParseUrl, you use a switch case depending on the parameters passed. These in turn call specific methods for each parameter, which most do the same thing, call IInternetProtocolInfo_ParseUrl with the desired parse option . This function is defined in urlmon header. It seems to call a saved This on runtime, derefencing a saved (?) virtual table calling ParseUrl. It is also implemented in the header (static FORCEINLINE) and also calls the ParseUrl. There are some STDMETHODCALLTYPE pure virtual methods inside a IInternetProtocoleInfo class. A struct virtual table IInternetProtocolInfoVtbl O_o I cannot find the actual ParseUrl implementation, though in misc.c, there are many references to CHECK_CALLED(ParseUrl) and SET_EXPECT(ParseUrl). I have no clue what is going on here to be completely honest. Finally, in misc.c there are some pCoInternetParseUrl and CoInternetParseUrl tests. But nothing that seems to implement what I need. My question is, why go through all these hoops instead of implementing CoInternetParseUrl inside internet.c. I am sure there is good reasoning behind this, I would just like to understand why. Also, where do I implement ParseUrl or IInternetProtocolInfo_ParseUrl? Thank you for any help in understanding what is going on here. Good day, Philippe

2 1

Re: [PATCH 2/4] ntdll/test: Add ntdll test function test_file_full_size_information
by Nikolay Sivov 06 Apr '15

06 Apr '15

On 04.04.2015 10:03, Jianqiu Zhang wrote: > + trace("TotalAllocationUnits %08x %08x\n", fsi.TotalAllocationUnits.HighPart, fsi.TotalAllocationUnits.LowPart); > + trace("CallerAvailableAllocationUnits %08x %08x\n", fsi.CallerAvailableAllocationUnits.HighPart, fsi.CallerAvailableAllocationUnits.LowPart); > + trace("ActualAvailableAllocationUnits %08x %08x\n", fsi.ActualAvailableAllocationUnits.HighPart, fsi.ActualAvailableAllocationUnits.LowPart); > + trace("SectorsPerAllocationUnit %08x\n", fsi.SectorsPerAllocationUnit); > + trace("BytesPerSector %08x\n", fsi.BytesPerSector); > + Hi, Jianqiu. This is not exactly a test, as you're just printing a result. Same thing with patch 3/4. Also to print LONGLONG values you use wine_dbgstr_longlong() probably.

2 3