July 2015 - Wine-devel - list.winehq.org

Re: [PATCH 4/4] wined3d: Always use screen-sized frontbuffers.
by Henri Verbeet 07 Jul '15

07 Jul '15

On 6 July 2015 at 23:47, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > --- > dlls/wined3d/device.c | 6 +++--- > dlls/wined3d/surface.c | 22 +++++++++++++++++----- > dlls/wined3d/swapchain.c | 27 +++++++++++++-------------- > 3 files changed, 33 insertions(+), 22 deletions(-) > Why would we want that?

2 1

Re: [PATCH 5/5] wined3d: Use GLSL 1.50 on core contexts.
by Henri Verbeet 07 Jul '15

07 Jul '15

On 6 July 2015 at 22:20, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > static const char *shader_glsl_get_version(const struct wined3d_gl_info *gl_info, > const struct wined3d_shader_version *version) > { > - if (gl_info->glsl_version >= MAKEDWORD_VERSION(1, 30) && version->major >= 4) > + if (!gl_info->supported[WINED3D_GL_LEGACY_CONTEXT]) > + return "#version 150"; > + else if (gl_info->glsl_version >= MAKEDWORD_VERSION(1, 30) && version && version->major >= 4) > return "#version 130"; > else > return "#version 120"; Is GLSL 1.20 unavailable in core contexts? I only glanced over the spec, but didn't immediately see anything that explicitly makes earlier versions unavailable. What's a bit unfortunate about this is that drivers may decide to use different floating point rules (in particular wrt. multiplications by zero) depending on the GLSL version. IIRC at least r600g considered doing that at some point, although I'd have to check if that's currently the case.

2 1

Re: [PATCH 2/2] mshtml: Add IHTMLXMLHttpRequest::send() method implementation. (try 2)
by Marvin 07 Jul '15

07 Jul '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=15123 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/4] d3d8/tests: Add a windowed GetFrontBufferData test.
by Henri Verbeet 07 Jul '15

07 Jul '15

On 6 July 2015 at 23:47, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +/* Locks a given surface and returns the color at (x,y). It's the caller's > + * responsibility to only pass in lockable surfaces and valid x,y coordinates */ > +static DWORD get_pixel_color_from_surface(IDirect3DSurface8 *surface, UINT x, UINT y) In ddraw this is called get_surface_color(), the equivalent d3d10core function is called get_texture_color().

1 0

odbccp32: Implement SQLGetPrivateProfileString (try 7)
by Hugh McMaster 07 Jul '15

07 Jul '15

On Tuesday, 7 July 2015, 10:31 pm UTC+10, Nikolay Sivov wrote: >On 07.07.2015 11:15, Alistair Leslie-Hughes wrote: > >> + retval = heap_alloc(cbRetBuffer*sizeof(WCHAR)); >> + >> + ret = SQLGetPrivateProfileStringW(sect, entry, string, retval, cbRetBuffer, file); > >cbRetBuffer is A-buffer length, you're still using it as W-buffer length. Unless I'm reading MSDN [1] incorrectly, this should work. cbRetBuffer is the size, in characters, of RetBuffer (i.e. the A-buffer). retval is the W-buffer. Its allocated byte size is double that of RetBuffer, but its size, in characters, is still the same.

2 2

Re: odbccp32: Implement SQLGetPrivateProfileString (try 7)
by Nikolay Sivov 07 Jul '15

07 Jul '15

On 07.07.2015 11:15, Alistair Leslie-Hughes wrote: > + retval = heap_alloc(cbRetBuffer*sizeof(WCHAR)); > + > + ret = SQLGetPrivateProfileStringW(sect, entry, string, retval, cbRetBuffer, file); cbRetBuffer is A-buffer length, you're still using it as W-buffer length.

1 0

Re: msscript.ocx: Added IDispatch functions implementation.
by Dmitry Timoshkov 07 Jul '15

07 Jul '15

Hi Jacek, Jacek Caban <jacek(a)codeweavers.com> wrote: > + case DLL_PROCESS_DETACH: > + release_typelib(); > + break; There should be a check to avoid freeing resources on process termination to avoid possible deadlocks. -- Dmitry.

1 0

Re: shell32/tests: Try harder to close Open With window
by Marvin 07 Jul '15

07 Jul '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=15086 Your paranoid android. === w2000pro (32 bit shlexec) === shlexec.c:2449: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2449: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2449: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2449: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2449: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 shlexec.c:2449: Test failed: ShellExecuteEx(mask="0x500", file="C:\Documents and Settings\winetest\Local Settings\Temp\wt1.tmp\test file.sde") failed: rc=33 err=1400 === wxppro (32 bit shlexec) === shlexec.c:1224: Test failed: expected 1 args, got 4 === w2003std (32 bit shlexec) === shlexec.c:1224: Test failed: expected 1 args, got 4

2 1

Re: [PATCH 2/4] d3d8/tests: Add a windowed GetFrontBufferData test.
by Marvin 07 Jul '15

07 Jul '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=15097 Your paranoid android. === w8 (32 bit visual) === visual.c:7637: Test failed: Got color 0xfffff913. visual.c:7639: Test failed: Got color 0xfffff913. visual.c:7641: Test failed: Got color 0xfffff913. visual.c:7643: Test failed: Got color 0xfffff913. visual.c:7646: Test failed: Got color 0xfffffa13. visual.c:7648: Test failed: Got color 0xfffffa13. visual.c:7650: Test failed: Got color 0xfffffa13. visual.c:7652: Test failed: Got color 0xfffefa13. visual.c:7655: Test failed: Got color 0xfffff913. visual.c:7657: Test failed: Got color 0xfffff913. visual.c:7659: Test failed: Got color 0xfffff913. visual.c:7661: Test failed: Got color 0xfffff913. visual.c:7664: Test failed: Got color 0xfffffa13. visual.c:7666: Test failed: Got color 0xfffef913. visual.c:7668: Test failed: Got color 0xfffffa13. visual.c:7670: Test failed: Got color 0xfffef913.

1 0

Re: [PATCH 1/4] d3d9/tests: Add a windowed GetFrontBufferData test.
by Marvin 07 Jul '15

07 Jul '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=15096 Your paranoid android. === w8 (32 bit visual) === visual.c:19339: Test failed: Got color 0xff7170fb. visual.c:19341: Test failed: Got color 0xff7170fb. visual.c:19343: Test failed: Got color 0xff7170fb. visual.c:19345: Test failed: Got color 0xff7170fb. visual.c:19348: Test failed: Got color 0xff71fefb. visual.c:19350: Test failed: Got color 0xff71fefb. visual.c:19352: Test failed: Got color 0xff71fefb. visual.c:19354: Test failed: Got color 0xff71fefb. visual.c:19357: Test failed: Got color 0xff7f70fb. visual.c:19359: Test failed: Got color 0xff7f70fb. visual.c:19361: Test failed: Got color 0xffff70fb. visual.c:19363: Test failed: Got color 0xffff70fb. visual.c:19366: Test failed: Got color 0xff86fefb. visual.c:19368: Test failed: Got color 0xff85fefb. visual.c:19370: Test failed: Got color 0xfffffe90. visual.c:19372: Test failed: Got color 0xfffffe90.

1 0