January 2016 - Wine-devel - list.winehq.org

Wiki is being hammered by spammers
by Rosanne DiMesio 13 Jan '16

13 Jan '16

In the past hour, I've restored the Front Page three times, and deleted over two dozen newly created spam pages. Earlier, Alexandre deleted many more spam pages. Something needs to be done now. -- Rosanne DiMesio dimesio(a)earthlink.net

9 10

Re: [PATCH] ole32: OleGetClipboard(): zero output interface pointer on error
by Nikolay Sivov 13 Jan '16

13 Jan '16

On 13.01.2016 13:23, Paul Gofman wrote: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- > dlls/ole32/clipboard.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/dlls/ole32/clipboard.c b/dlls/ole32/clipboard.c > index ca9520f..b871bbc 100644 > --- a/dlls/ole32/clipboard.c > +++ b/dlls/ole32/clipboard.c > @@ -2201,6 +2201,7 @@ HRESULT WINAPI OleGetClipboard(IDataObject **obj) > TRACE("(%p)\n", obj); > > if(!obj) return E_INVALIDARG; > + *obj = NULL; > > if(FAILED(hr = get_ole_clipbrd(&clipbrd))) return hr; > Hi, Paul. This is to handle a case when OLE was not initialized, right? If so, it should be easy to add a test for it. It makes sense to zero it as a common convention for out interface pointers, but a test won't hurt.

2 4

Re: [2/4] gdi32: Fix the advance width in synthetic bold glyphs with scaling. (try 3)
by Marvin 13 Jan '16

13 Jan '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19662 Your paranoid android. === wvistau64 (32 bit font) === Failure running script in VM: network read timed out (Connect:AgentVersion.h:0/9) === wvistau64 (64 bit font) === Failure running script in VM: network read timed out (Connect:AgentVersion.h:0/9)

1 0

Re: shell32/tests: Trace the effective ShellExecuteEx() flags.
by Marvin 13 Jan '16

13 Jan '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19657 Your paranoid android. === wvistau64 (32 bit shlexec) === shlexec.c:141: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtDB9E.tmp\test file.noassoc.shlexec") WaitForSingleObject returned 258 shlexec.c:1570: Test failed: argvA3 expected 'Open', but key not found or empty shlexec.c:1578: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtDB9E.tmp\test file.noassoc.shlexec', but key not found or empty shlexec.c:1570: Test failed: argvA3 expected 'QuotedLowerL', got 'Open' shlexec.c:1578: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtDB9E.tmp\test file.shlexec', got 'C:\Users\winetest\AppData\Local\Temp\wtDB9E.tmp\test file.noassoc.shlexec' === w1064 (32 bit shlexec) === shlexec.c:2293: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt1B82.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2293: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt1B82.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2293: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt1B82.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2293: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wt1B82.tmp\test file.sde") failed: rc=29 err=2 === w1064 (64 bit shlexec) === shlexec.c:2293: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtF82E.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2293: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtF82E.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2293: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtF82E.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2305: Test failed: ddeExec expected '[ifexec("C:\Users\winetest\AppData\Local\Temp\wtF82E.tmp\test file.sde")]', got '[open("C:\Users\winetest\AppData\Local\Temp\wtF82E.tmp\test file.sde")]' shlexec.c:2293: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtF82E.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2293: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtF82E.tmp\test file.sde") failed: rc=29 err=2

1 0

Re: shell32/tests: Tweak some overly optimistic ok() messages.
by Marvin 13 Jan '16

13 Jan '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19656 Your paranoid android. === w1064 (32 bit shlexec) === shlexec.c:2293: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtD923.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2293: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtD923.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2293: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtD923.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2305: Test failed: ddeExec expected '[ifexec("C:\Users\winetest\AppData\Local\Temp\wtD923.tmp\test file.sde")]', got '[open("C:\Users\winetest\AppData\Local\Temp\wtD923.tmp\test file.sde")]' shlexec.c:2293: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtD923.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2293: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtD923.tmp\test file.sde") failed: rc=29 err=2 === w1064 (64 bit shlexec) === shlexec.c:2293: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt1102.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2293: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt1102.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2293: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt1102.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2293: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt1102.tmp\test file.sde") failed: rc=29 err=2

1 0

Re: regsvr32/tests: Add initial tests
by Francois Gouget 13 Jan '16

13 Jan '16

On Tue, 12 Jan 2016, Hugh McMaster wrote: [...] > diff --git a/programs/regsvr32/tests/Makefile.in b/programs/regsvr32/tests/Makefile.in > new file mode 100644 > index 0000000..61d25fe > --- /dev/null > +++ b/programs/regsvr32/tests/Makefile.in [...] > +ifneq (,$(filter crosstest mingw,$(MAKECMDGOALS) $(findstring mingw,$(CC)))) > + TARGET_DLLS = $(addsuffix .dll, $(DLL_BASENAMES)) I believe the syntax on these last two lines is specific to GNU make which is something that Wine has tried to avoid so far. Note that more generally getting a dll into this test will be pretty tricky. Would it be possible to do the tests using an existing dll? Alternatively would it work to add the test's dll to dlls/ and grab and include it as a resource in programs/regsvr32/tests? This may help avoid makefile shenanigans. > diff --git a/programs/regsvr32/tests/regsvr32.c b/programs/regsvr32/tests/regsvr32.c > new file mode 100644 > index 0000000..746c81f > --- /dev/null > +++ b/programs/regsvr32/tests/regsvr32.c [...] > +#define run_test(...) run_test_(output, &r, __VA_ARGS__) A macro with a variable argument list? That does not seem portable (or maybe is a > C99 feature). > +static BOOL __cdecl run_test_(char *output, DWORD *r, const char *fmt, ...) > +{ > + __ms_va_list va_args; Shouldn't this be using something like __winetest_va_list? To be checked... > +#define CMP(s) !strcmp(output, s) This macro is totally unnecessary. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Broadcast message : fin du monde dans cinq minutes, repentez vous !

2 3

Re: [PATCH] comctl32/trackbar: Update thumb immediately on key press
by Marvin 13 Jan '16

13 Jan '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19639 Your paranoid android. === wvistau64 (32 bit trackbar) === trackbar.c:682: Test failed: got 36, expected 36 === wvistau64 (64 bit trackbar) === trackbar.c:682: Test failed: got 36, expected 36

2 1

Re: [PATCH 1/2] dnsapi: migrating to res_nquery (try 2)
by Sebastian Lackner 13 Jan '16

13 Jan '16

On 12.01.2016 20:55, Donat Enikeev wrote: > @@ -597,7 +609,9 @@ static DNS_STATUS dns_do_query( PCSTR name, WORD type, DWORD options, PDNS_RECOR > > DNS_RRSET_INIT( rrset ); > > - len = res_query( name, ns_c_in, type, answer, sizeof(answer) ); > + TRACE("Performing res_nquery(%p, %s, %u, %u, %p)\n", rs, name, type, options, result); Please use debugstr_a() when tracing untrusted values of arbitrary size. > + > + len = res_nquery( rs, name, ns_c_in, type, answer, sizeof(answer) ); > if (len < 0) > { > ret = dns_map_h_errno( h_errno );

1 0

Re: [PATCH 2/2] dnsapi: DnsQueryEx partial implementation (try 2)
by Hans Leidekker 13 Jan '16

13 Jan '16

On Tue, 2016-01-12 at 22:55 +0300, Donat Enikeev wrote: This produces a warning on Mac OS: gcc -m32 -c -o query.o query.c -I. -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe \ -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers \ -Wstrict-prototypes -Wtype-limits -Wvla -Wwrite-strings -Wpointer-arith -gdwarf-2 -gstrict-dwarf \ -fno-omit-frame-pointer -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 query.c:701:17: warning: format specifies type 'unsigned short' but the argument has type 'UCHAR' (aka 'unsigned char') [-Wformat] p_sockaddr->sin_addr.WS_s_impno, p_sockaddr->sin_addr.WS_s_lh, ^

1 0

Re: [PATCH 1/4] oleaut32: Add tests for safearray unmarshaling into passed variant
by Dmitry Timoshkov 13 Jan '16

13 Jan '16

Hi Piotr, Piotr Caban <piotr(a)codeweavers.com> wrote: > @@ -1316,11 +1316,19 @@ static void test_marshal_VARIANT(void) > ok(*wirev, "wv[6] %08x\n", *wirev); /* win2k: this is lpsa. winxp: this is (char*)lpsa + 1 */ > wirev++; > check_safearray(wirev, lpsa); > - VariantInit(&v2); > + mem = CoTaskMemAlloc(1024); > + lpsa_copy = lpsa2 = SafeArrayCreate(VT_I8, 1, &sab); > + CoTaskMemFree(mem); > + mem = lpsa2->pvData; > + V_VT(&v2) = VT_UI4 | VT_ARRAY | VT_BYREF; > + V_ARRAYREF(&v2) = &lpsa2; Looks like the result of CoTaskMemAlloc/CoTaskMemFree is not used. -- Dmitry.

2 3