January 2016 - Wine-devel - list.winehq.org

why are WineWindows NSPanels
by Theodore Dubois 13 Jan '16

13 Jan '16

Hi, Why are WineWindows NSPanels, not NSWindows? I can see a disadvantage of this, which is that NSPanels don’t show up in Mission Control, but I can’t see the advantage. ~Theodore

2 1

Re: [PATCH 2/4] oleaut32: Set safearray pointer to NULL in LPSAFEARRAY_UserFree
by Marvin 12 Jan '16

12 Jan '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19628 Your paranoid android. === w1064 (64 bit usrmarshal) === The test timed out

1 0

Re: [PATCH 2/2] winegstreamer: Always run gstreamer callbacks on a Wine thread
by Michael Stefaniuc 12 Jan '16

12 Jan '16

Hello Andrew, On 01/11/2016 09:13 PM, Andrew Eikum wrote: > This gets winegstreamer with gstreamer-0.10 working for me again, > fixing Bug 30557. However, gstreamer-0.10 is no longer developed and > some distros don't ship it anymore. which distros are those? gstreamer-0.10 is still available in Fedora 23. I intend to pull this patch (or a version of it) into Stable. But I'd rather stick with the old gstreamer-0.10 then go to the new API; it is the smaller change. > I have more patches on top of this one to move winegstreamer to the > gstreamer-1.0 API. See Bug 31836. In order to avoid dependency churn > for packagers, I think it makes sense to apply them both during the > same release, so I intend to send those patches after this one is > accepted. If you prefer to review them all, I can send them all at > once. bye michael

3 4

Re: dwrite: Remove "crashes on native" tests that were already if(0)-ed. if(0)-ed.
by Nikolay Sivov 12 Jan '16

12 Jan '16

On 12.01.2016 14:44, Gerald Pfeifer wrote: > I noticed those via the new -Wmisleading-indentation warnings. All > of these are tests that are disabled (if (0)) since they crash native. > > Am I missing something, or can we just remove them as dead code? There are disabled from the very beginning, and serve documentation purpose. > > (If not, okay to add braces for those cases not having them yet?) We try to avoid workarounds for static analyzers, and this warning is very similar in nature. I personally don't see a need of extra braces just to please it, but if it's decided that it's important to handle this warning for all wine code and if this warning will be actually on by default in gcc release, then sure, braces it is, instead of removing such blocks. > > Gerald >

1 0

Re: [PATCH 1/2] dnsapi: migrating to res_nquery (split resend)
by Hans Leidekker 12 Jan '16

12 Jan '16

On Mon, 2016-01-11 at 22:07 +0300, Donat Enikeev wrote: > -static void initialise_resolver( void ) > +static res_state initialise_resolver( void ) > { > - if ((_res.options & RES_INIT) == 0) > - res_init(); > + res_state dns_res_state = NULL; No need to initialize this variable. Why the dns_ prefix on local variables? > + if ( !(dns_res_state = heap_alloc_zero(sizeof(struct __res_state))) ) > + return NULL; > + > + res_ninit(dns_res_state); > + > + return dns_res_state; > } > @@ -706,6 +719,7 @@ DNS_STATUS WINAPI DnsQuery_UTF8( PCSTR name, WORD type, DWORD options, PVOID ser > { > DNS_STATUS ret = DNS_ERROR_RCODE_NOT_IMPLEMENTED; > #ifdef HAVE_RESOLV > + res_state dns_res_state; > > TRACE( "(%s,%s,0x%08x,%p,%p,%p)\n", debugstr_a(name), dns_type_to_str( type ), > options, servers, result, reserved ); > @@ -713,13 +727,15 @@ DNS_STATUS WINAPI DnsQuery_UTF8( PCSTR name, WORD type, DWORD options, PVOID ser > if (!name || !result) > return ERROR_INVALID_PARAMETER; > > - initialise_resolver(); > - _res.options |= dns_map_options( options ); > + dns_res_state = initialise_resolver(); > + if ( !dns_res_state ) return ERROR_NOT_ENOUGH_MEMORY; > > - if (servers && (ret = dns_set_serverlist( servers ))) > + dns_res_state->options |= dns_map_options( options ); > + > + if (servers && (ret = dns_set_serverlist( dns_res_state, servers ))) > return ret; You are leaking dns_res_state here. > @@ -824,8 +842,9 @@ DNS_STATUS WINAPI DnsQueryConfig( DNS_CONFIG_TYPE config, DWORD flag, PCWSTR ada > case DnsConfigDnsServerList: > { > #ifdef HAVE_RESOLV > - initialise_resolver(); > - ret = dns_get_serverlist( buffer, len ); > + res_state dns_res_state = initialise_resolver(); > + ret = dns_get_serverlist( dns_res_state, buffer, len ); > + heap_free(dns_res_state); You should check the return value of initialise_resolver() here too.

1 0

Re: regsvr32/tests: Add initial tests
by Marvin 12 Jan '16

12 Jan '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19620 Your paranoid android. === wxppro (32 bit dll) === No test summary line found === w2003std (32 bit dll) === No test summary line found === wvistau64 (32 bit dll) === No test summary line found === w2008s64 (32 bit dll) === No test summary line found === w7u (32 bit dll) === No test summary line found === w7pro64 (32 bit dll) === No test summary line found === w8 (32 bit dll) === No test summary line found === w864 (32 bit dll) === No test summary line found === w1064 (32 bit dll) === No test summary line found === wvistau64 (64 bit dll) === No test summary line found === w2008s64 (64 bit dll) === No test summary line found === w7pro64 (64 bit dll) === No test summary line found === w864 (64 bit dll) === No test summary line found === w1064 (64 bit dll) === No test summary line found

2 1

Re: [PATCH 2/2] winegstreamer: Always run gstreamer callbacks on a Wine thread
by Matteo Bruni 11 Jan '16

11 Jan '16

2016-01-11 21:13 GMT+01:00 Andrew Eikum <aeikum(a)codeweavers.com>: Just happened to notice this while skimming the patch: > +GstBusSyncReply watch_bus_wrapper(GstBus *bus, GstMessage *msg, gpointer user) > +{ > + struct cb_data cbdata = { WATCH_BUS, > + { .watch_bus_data = { bus, msg, user} } > + }; I think designators are a C99 feature :/

1 0

ole32: OleInitialize/OleUnitialize behaves differently in Wine and Windows
by Paul Gofman 11 Jan '16

11 Jan '16

OleInitialize/OleUnitialize behave differently in Wine and Windows (at least WinXP) in the following special case. The application thread has a multithreaded apartment initialized. Then OleInitialize is called from the same thread, followed by OleUnitialize call later. According to MSDN spec OleInitialize should return RPC_E_CHANGED_MODE (which is the case both in Windows and Wine) and OleUnitilize call should not be performed after that. If OleUnitilize is actually called (which is the case in the application), it presumably should uninitialize the COM apartment completely just as in case CoUnitialize (this is what Wine does). But this seems to be not the case under Windows. I am attaching a patch which adds such a test to ole32/tests/compobj. The test does CoInitializeEx(NULL, COINIT_MULTITHREADED), then OleInitialize, OleUninitialize and then tries to create COM object. The test fails under Wine (apartment not initialized) but passes OK under my WinXP virtual machine. If to change OleInitialize/OleUninitialize to CoInitializeEx(NULL, COINIT_APARTMENTTHREADED)/CoUnitialize the test will fail both under Wine and Windows. The application works under Windows but crashes under Wine. I can tweak the application to work under Wine by, for instance, incrementing init counter in CoInitializeEx in ole32/compobj.c despite of returning RPC_E_CHANGED_MODE. So, the questions are: 1. Should I submit this test to wine-patches? 2. Is there some obvious way how can this be correctly fixed? E. g. it could potentially be fixed by adding some extra field to COM current info which would be checked in OleUninitialize not to allow the decrement of init counter by OleUnitialize below the value that was before first OleInit call, but I am not sure for now what Windows actually does. Maybe there are some known good ways how to explore this refcounting behaviour under Windows? If no, I could try to guess native behaviour by doing multiple CoInit/CoUninit/OleInit/OleUninit in different combinations followed by CoCreateInstance. Regards, Paul.

1 0

Re: shell32/tests: create_test_association() should either succeed or fail due to insufficient permissions.
by Marvin 11 Jan '16

11 Jan '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19589 Your paranoid android. === wvistau64 (32 bit shlexec) === shlexec.c:141: Test failed: ShellExecute(verb="QuotedUpperL", file="C:\Users\winetest\AppData\Local\Temp\wtD538.tmp\test file.shlexec") WaitForSingleObject returned 258 shlexec.c:1567: Test failed: argvA3 expected 'QuotedUpperL', but key not found or empty shlexec.c:1575: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtD538.tmp\test file.shlexec', but key not found or empty === w1064 (32 bit shlexec) === shlexec.c:2289: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt1306.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2289: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt1306.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2289: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt1306.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2289: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt1306.tmp\test file.sde") failed: rc=29 err=2 === w1064 (64 bit shlexec) === shlexec.c:2289: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt72F2.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2289: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt72F2.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2289: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt72F2.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2301: Test failed: ddeExec expected '[ifexec("C:\Users\winetest\AppData\Local\Temp\wt72F2.tmp\test file.sde")]', got '[open("C:\Users\winetest\AppData\Local\Temp\wt72F2.tmp\test file.sde")]' shlexec.c:2289: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt72F2.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2289: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt72F2.tmp\test file.sde") failed: rc=29 err=2

2 1

Re: mshtml: Skip unused named args in Invoke calls.
by Marvin 11 Jan '16

11 Jan '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19615 Your paranoid android. === w8 (32 bit script) === script.c:632: Test failed: L"extern_res_script_rs = loaded0,eval,complete1, expected eval,complete1," === w864 (32 bit script) === script.c:632: Test failed: L"extern_res_script_rs = loaded0,eval,complete1, expected eval,complete1,"

1 0