October 2017 - Wine-devel - list.winehq.org

Re: [PATCH] mshtml: Added IDocumentEvent stub implementation.
by Marvin 11 Oct '17

11 Oct '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33484 Your paranoid android. === wxppro (32 bit events) === events.c:2541: Test failed: Could not get IDocumentEvent iface: 80004002 0a30:events: unhandled exception c0000005 at 0042E8B7 === w2003std (32 bit events) === events.c:2541: Test failed: Could not get IDocumentEvent iface: 80004002 05f0:events: unhandled exception c0000005 at 0042E8B7

1 0

Re: [resend 1/2] comctl32: Preserve title when creating ListView window.
by Nikolay Sivov 11 Oct '17

11 Oct '17

On 10/11/2017 10:10 AM, Vadim Druzhin wrote: > Fix for NTPWEdit (http://cdslow.org.ru/en/ntpwedit/index.html) > > Signed-off-by: Vadim Druzhin <cdslow(a)mail.ru> > --- > dlls/comctl32/listview.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c > index 73eceff..8114222 100644 > --- a/dlls/comctl32/listview.c > +++ b/dlls/comctl32/listview.c > @@ -9532,6 +9532,10 @@ static LRESULT LISTVIEW_NCCreate(HWND hwnd, const CREATESTRUCTW *lpcs) > if (!(infoPtr->hdpaPosX = DPA_Create(10))) goto fail; > if (!(infoPtr->hdpaPosY = DPA_Create(10))) goto fail; > if (!(infoPtr->hdpaColumns = DPA_Create(10))) goto fail; > + > + /* Preserve window title */ > + DefWindowProcW(hwnd, WM_SETTEXT, 0, (LPARAM)(lpcs->lpszName)); > + > return TRUE; This is fixed in git now, see https://source.winehq.org/git/wine.git/commit/ee7ddd1ed38a3b2f41bdb676f42e3…, so no need to resend. > fail: > -- > 2.5.5 >

1 0

Re: [resend 2/2] comctl32: Enhance LISTVIEW_ApproximateViewRect in LV_VIEW_DETAILS mode.
by Nikolay Sivov 11 Oct '17

11 Oct '17

On 10/11/2017 10:11 AM, Vadim Druzhin wrote: > Calculate approximated window size > when control does not have real items. > > Fix for NTPWEdit (http://cdslow.org.ru/en/ntpwedit/index.html) > > Signed-off-by: Vadim Druzhin <cdslow(a)mail.ru> > --- > dlls/comctl32/listview.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c > index 8114222..7e33f7c 100644 > --- a/dlls/comctl32/listview.c > +++ b/dlls/comctl32/listview.c > @@ -5362,6 +5362,13 @@ static DWORD LISTVIEW_ApproximateViewRect(const LISTVIEW_INFO *infoPtr, INT nIte > wWidth = rcBox.right - rcBox.left; > wHeight = (rcBox.bottom - rcBox.top) * nItemCount; > } > + else if (nItemCount > 0) > + { > + /* No real items, use approximation */ > + LISTVIEW_GetHeaderRect(infoPtr, 0, &rcBox); > + wHeight = rcBox.bottom - rcBox.top + infoPtr->nItemHeight * nItemCount; > + wWidth = infoPtr->nItemWidth; > + } Hi, Vadim. This doesn't look right. nItemCount less than -1 or 0 is acceptable too, only -1 has special meaning. Please add some tests to ./tests/listview.c:test_approximate_viewrect() first. Currently we only have some tests, and not that many, for LVS_ICON style. > else > { > /* use current height and width */ > -- > 2.5.5 >

1 0

Re: [v2 PATCH 1/4] gdiplus/tests: Test EMF+ records flags
by Vincent Povirk 10 Oct '17

10 Oct '17

Maybe instead of removing the check completely, we could provide a mask of bits to ignore, or an alternative accepted value?

2 1

Re: [PATCH] ws2_32/tests: Fix compilation warning
by Alexandre Julliard 10 Oct '17

10 Oct '17

Fabian Maurer <dark.shadow4(a)web.de> writes: > Without that change, gcc gives the warning > "include/winsock.h:480:37: ‘readfds.fd_array[__i]’ > may be used uninitialized in this function" It looks initialized to me. What gcc version is that? -- Alexandre Julliard julliard(a)winehq.org

2 6

Re: [PATCH 1/4] gdiplus/tests: Test EMF+ records flags
by Marvin 10 Oct '17

10 Oct '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33463 Your paranoid android. === wxppro (32 bit metafile) === metafile.c:57: Test failed: draw image bitmap.4: Expected record type 0x401b, got 0x401b. Expected flags 0, got 0x4000. metafile.c:57: Test failed: properties.4: Expected record type 0x401e, got 0x401e. Expected flags 0x9, got 0x1. === w2003std (32 bit metafile) === metafile.c:57: Test failed: draw image bitmap.4: Expected record type 0x401b, got 0x401b. Expected flags 0, got 0x4000. metafile.c:57: Test failed: properties.4: Expected record type 0x401e, got 0x401e. Expected flags 0x9, got 0x1. === wvistau64 (32 bit metafile) === metafile.c:57: Test failed: draw image bitmap.4: Expected record type 0x401b, got 0x401b. Expected flags 0, got 0x4000. metafile.c:57: Test failed: properties.4: Expected record type 0x401e, got 0x401e. Expected flags 0x9, got 0x1. === w2008s64 (32 bit metafile) === metafile.c:57: Test failed: draw image bitmap.4: Expected record type 0x401b, got 0x401b. Expected flags 0, got 0x4000. metafile.c:57: Test failed: properties.4: Expected record type 0x401e, got 0x401e. Expected flags 0x9, got 0x1. === wvistau64 (64 bit metafile) === metafile.c:57: Test failed: draw image bitmap.4: Expected record type 0x401b, got 0x401b. Expected flags 0, got 0x4000. metafile.c:57: Test failed: properties.4: Expected record type 0x401e, got 0x401e. Expected flags 0x9, got 0x1. === w2008s64 (64 bit metafile) === metafile.c:57: Test failed: draw image bitmap.4: Expected record type 0x401b, got 0x401b. Expected flags 0, got 0x4000. metafile.c:57: Test failed: properties.4: Expected record type 0x401e, got 0x401e. Expected flags 0x9, got 0x1.

1 0

Wine Swag Sticker Poll
by Aric Stewart 10 Oct '17

10 Oct '17

Hello! So all the way back at wineconf I volunteered to be swag master for winehq. The idea is to have something that can be given away at trade shows, presentations, LUG visits and the like. Just something to help promote the visibility of the project. Jana here, CodeWeavers marketing director, has put together a sampling of designs to do as our first sticker and so now we are looking for some feedback on what people prefer. https://docs.google.com/forms/d/e/1FAIpQLSd5X_fXe9KSFAppRHz8kUo3XKeODyH5KeX… Rosanne? Could you direct me as to where this should be put up for the users as well? I am unfamiliar with how to communicate to our user base. The poll will run for as long as it feels like it needs to get some sort of winner. Comments and suggestions are always welcome! -aric

7 10

Re: [PATCH 1/2] msvcrt: Add vf[w]printf_s_l
by Piotr Caban 10 Oct '17

10 Oct '17

It causes compilation warnings: ../../../wine_src/dlls/msvcr110/../msvcrt/file.c: In function 'MSVCRT_vfprintf_s': ../../../wine_src/dlls/msvcr110/../msvcrt/file.c:5100:12: warning: implicit declaration of function 'MSVCRT__vfprintf_s_l' [-Wimplicit-function-declaration] Thanks, Piotr

1 0

Re: [PATCH 2/2] msvcrt: Change forward for consistency.
by Piotr Caban 10 Oct '17

10 Oct '17

On 10/09/17 12:23, Gijs Vermeulen wrote: > @@ -5320,7 +5320,7 @@ int CDECL MSVCRT_printf_s(const char *format, ...) > __ms_va_list valist; > int res; > __ms_va_start(valist, format); > - res = MSVCRT_vprintf_s(format, valist); > + res = MSVCRT_vfprintf_s(MSVCRT_stdout, format, valist); I don't think this code needs to be changed. It's just a matter of taste so I would leave it as is. Thanks, Piotr

1 0

wine-2.0.3-rc1 Available
by Michael Stefaniuc 10 Oct '17

10 Oct '17

Hello guys, I have pushed wine-2.0.3-rc1 (with tag) to https://github.com/mstefani/wine-stable http://static-winehq.193b.starter-ca-central-1.openshiftapps.com/stable/ This version has only 63 commits and only 38 bugs fixed. The summer was kinda low on bug fixes. So I have picked some small fixes too that had no bugzilla entry. And now the interesting parts from the ANNOUNCE file: What's new in this release (see below for details): - Various bug fixes - FreeType 2.8.1 compatibility fixes ---------------------------------------------------------------- Bugs fixed in 2.0.3 (total 38): 11433 unimplemented function ole32.dll.OleGetIconOfFile 16948 tmpfile() fails when run from Unix path 24723 Lost Horizon crash/page fault during Chapter 2 26388 Sound Recorder crashes on encoding PCM Sample 32563 Purebasic does not display icons in toolbar which is drawn distorted. 33740 Sound Recorder displays error when seeking MP3 stream to the end 35529 Uninstaller: application list doesn't fit 38328 WPS 2013 (Kingsoft) crash at install 38980 World of Warships/Planes/Tanks client in torrent download mode crashes spuriously on high bandwidth load (i/o completion ports) 40919 Worms Armageddon Gameplay only shows top-left corner of screen 41489 notepad++ escape key 42080 Listview does not draw correctly in some conditions. 42140 "Unrecognized stencil op 0" messages flooding system log in Söldner Secret Wars 42656 ACDSee Pro 10 needs msvcp140.dll.?_Schedule_chore(a)details@Concurrency@@YAHPEAU_Threadpool_chore(a)12@@Z 42708 Soul Reaver GOG Cinematics stopped working 42754 Seed of Andromeda Pre-Alpha 0.2 crashes 42910 Scrabble (Infogrames) multiplayer requires IDirectPlay4::EnumConnections 42940 WAtomic: White labels that show name of elements hidden by GL components 43005 secur32/tests/ntlm.ok crashes in DeleteSecurityContext 43020 Guitar Pro 7 needs msvcp140.dll._To_wide 43026 SP+ maker won't run. 43039 Rise of the Tomb Raider needs unimplemented function USER32.dll.PhysicalToLogicalPoint 43097 WarBR: game (WarS v5.5 p4) crashes on start, needs WMP IOleObject::GetExtent method implementation 43157 Adobe Premiere needs ntoskrnl.exe.KeAcquireSpinLockRaiseToDpc 43216 winhttp fails to redirect from http to https on 301 error. 43220 Adobe Premiere needs ntoskrnl.exe.KeReleaseSpinLock 43268 Wargaming.net Game Center needs msvcp140.dll._To_byte 43283 Crazyracing KartRider: Crashes on startup on unimplemented function ntoskrnl.exe.IoCreateNotificationEvent 43295 BitLord crashes on unimplemented function IPHLPAPI.DLL.if_nametoindex 43303 PHP crashes on unimplemented function api-ms-win-crt-math-l1-1-0.dll.acosh 43304 PHP crashes on unimplemented function api-ms-win-crt-math-l1-1-0.dll.atanh 43305 numpy crashes on unimplemented function api-ms-win-crt-math-l1-1-0.dll.log1p 43334 winealsa.drv: Warning while building (GCC 7.1.1) 43369 Nora, Princess and Stray cat (demo): fails to run (division by zero) 43392 valgrind shows a couple invalid reads in programs/regedit/tests/regedit.c 43403 make error on Debian 4.9.30-2kali1 (2017-06-22) x86_64 GNU/Linux 43715 Many applications (winecfg, ...) crash on startup with freetype 2.8.1 43716 freetype 2.8.1 breaks Wine build during font conversion with sfnt2fon ---------------------------------------------------------------- Changes since 2.0.2: Akihiro Sagawa (2): oleaut32: Fix parse error when converting non-ascii string to VT_DATE. gdi32: Return non-zero VREFRESH value for display devices. Alex Henrie (5): comctl32/listview: When adding a scrollbar, update the other one. msvcr120: Add acosh. msvcr120: Add atanh. msvcr120: Add expm1. msvcr120: Add log1p. Alexandre Julliard (1): user32: Always update the visible region for cross-process DCEs. Alistair Leslie-Hughes (2): dplayx: Implement IDirectPlay4 EnumConnections. dmime: Support more interfaces in IDirectMusicAudioPath.GetObjectInPath. Andrey Gusev (1): winealsa.drv: Fix uninitialized variable warning. André Hentschel (2): wpcap: Fix build with newer pcap versions. oleview: Fix bytecount for memmoves (Coverity). Austin English (4): user32: Add LogicalToPhysicalPoint/PhysicalToLogicalPoint stubs. ntoskrnl.exe: Add KeReleaseSpinLock stub. ntoskrnl: Add KeAcquireSpinLockRaiseToDpc stub. ntoskrnl.exe: Add IoCreateNotificationEvent stub. Daniel Lehman (1): mshtml: Decrement refcount in nsWeakReference::Release (Valgrind). Dmitry Timoshkov (3): oleaut32: Add an arguments check to LoadTypeLibEx. user.exe16: Fix memory leak in case when HeapReAlloc fails. dsound: Fix a memory leak. Fabian Maurer (1): user32: Don't send WM_CHAR when a menu gets VK_ESCAPE and add tests. Hans Leidekker (4): winhttp: Reset content length when a redirect creates a new connection. wbemprox: Also free data for tables that don't have a fill function (Valgrind). advpack: Don't trace the contents of an output buffer (Valgrind). msi: Avoid zero size allocations (Valgrind). Henri Verbeet (4): ddraw/tests: Introduce a helper function to create windows. ddraw/tests: Add a test for the alpha and z-buffer blit flags. ddraw: Ignore unsupported blit flags. wined3d: Only warn about 0 stencil ops in gl_stencil_op(). Hugh McMaster (2): regedit: Prevent out-of-bounds reads when unescaping a string (Valgrind). uninstaller: Pass RegQueryValueExW() the size of the buffer (Coverity). Huw D. M. Davies (2): shell32: Remove an extraneous '@'. user32: Explicitly set last error to ERROR_SUCCESS. Jacek Caban (1): wmp: Added IOleObject::GetExtent and SetExtent implementation. Józef Kucia (1): user32: Fix memory leak in WinHelpA(). Ken Thomases (2): winemac: Track whether a view has ever had an OpenGL context attached. gdiplus: Avoid infinite recursion in flatten_bezier(). Marcus Meissner (2): msvcrt: Free the temporary filename (Coverity). gameux: Avoid freeing uninitialized interfaces (Coverity). Michael Müller (1): include: Fix an invalid UUID in dxva2api.idl. Michael Stefaniuc (2): tools/sfnt2fon: Just skip all glyphs below 0x20. fonts: Increase the Em size to fix a build failure with freetype 2.8.1. Mikhail Paulyshka (1): msvcp140: Implement _To_byte. Nikolay Sivov (6): comctl32/toolbar: Fix TB_SETDRAWTEXTFLAGS handler. comctl32/toolbar: Don't add NULL imagelist entries. comctl32/toolbar: Support undocumented IDs for standard bitmap lists. gdi32: Pick first charmap if none was selected using preferred encoding. include: Fix IShellFolderView method macros. shell32/ebrowser: Respond to IOleWindow from IExplorerBrowser. Piotr Caban (4): msvcrt: Use temp directory when creating file in tmpfile. msvcp140: Add _ContextCallback tests. msvcp140/tests: Add _TaskEventLogger tests. msvcp140: Add {_Schedule,_Reschedule,_Release}_chore implementation. Sebastian Lackner (1): ntoskrnl.exe: Add KeReleaseInStackQueuedSpinLock stub. Stefan Dösinger (3): ws2_32: Don't post completion packet if receiving fails with error immediately. iphlpapi: Implement if_nametoindex. msvcp140: Implement _To_wide. Zebediah Figura (4): secur32/tests: Zero-initialize contexts. msacm32: Don't write cbSize if the format is WAVE_FORMAT_PCM. winemp3.acm: Fix error in acmStreamSize(). msacm32: Rewrite PCM conversion functions. Zhenbo Li (1): ole32: Add stub for OleGetIconOfFile. -- Michael Stefaniuc mstefani(a)winehq.org

1 0