October 2017 - Wine-devel - list.winehq.org

Re: [PATCH] shlwapi: Support UNC paths in PathGetDriveNumberW.
by Marvin 09 Oct '17

09 Oct '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33459 Your paranoid android. === wxppro (32 bit path) === path.c:1458: Test failed: got = -1 === w2003std (32 bit path) === path.c:1458: Test failed: got = -1

1 0

Re: [PATCH] d3dx9/tests: Avoid bitwise operation.
by Fabian Maurer 09 Oct '17

09 Oct '17

> if (!end1 && !end2) break; > > - status = !end1 ^ !end2; > + status = !end1 && !end2; > ok(!status, "Line %u, test %u: Mismatch in size, test declaration > is %s than expected.\n", line, test_id, end1 ? "shorter" : "longer"); > if (status) Doesn't this change the meaning of the code? You could also just make it into "status = FALSE", since when it's true the conditional break is used. Regards, Fabian Maurer

2 1

Re: [PATCH] quartz: Add missing parameter.
by Matteo Bruni 09 Oct '17

09 Oct '17

2017-10-07 15:55 GMT+02:00 Andrey Gusev <andrey.goosev(a)gmail.com>: > Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> > --- > dlls/quartz/pin.c | 5 ++++- > dlls/quartz/pin.h | 5 ++++- > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/dlls/quartz/pin.c b/dlls/quartz/pin.c > index a2651fd49b..355d87d9d5 100644 > --- a/dlls/quartz/pin.c > +++ b/dlls/quartz/pin.c > @@ -218,7 +218,10 @@ static HRESULT PullPin_Init(const IPinVtbl *PullPin_Vtbl, const PIN_INFO * pPinI > return S_OK; > } > > -HRESULT PullPin_Construct(const IPinVtbl *PullPin_Vtbl, const PIN_INFO * pPinInfo, SAMPLEPROC_PULL pSampleProc, LPVOID pUserData, QUERYACCEPTPROC pQueryAccept, CLEANUPPROC pCleanUp, REQUESTPROC pCustomRequest, STOPPROCESSPROC pDone, LPCRITICAL_SECTION pCritSec, IPin ** ppPin) > +HRESULT PullPin_Construct(const IPinVtbl *PullPin_Vtbl, const PIN_INFO * pPinInfo, > + SAMPLEPROC_PULL pSampleProc, LPVOID pUserData, QUERYACCEPTPROC pQueryAccept, > + CLEANUPPROC pCleanUp, REQUESTPROC pCustomRequest, STOPPROCESSPROC pDone, > + LPCRITICAL_SECTION pCritSec, IPin ** ppPin) > { > PullPin * pPinImpl; > > diff --git a/dlls/quartz/pin.h b/dlls/quartz/pin.h > index 428fa6fe8e..2f29c929cf 100644 > --- a/dlls/quartz/pin.h > +++ b/dlls/quartz/pin.h > @@ -102,7 +102,10 @@ typedef struct PullPin > #define Req_Pause 3 > > /*** Constructors ***/ > -HRESULT PullPin_Construct(const IPinVtbl *PullPin_Vtbl, const PIN_INFO * pPinInfo, SAMPLEPROC_PULL pSampleProc, LPVOID pUserData, QUERYACCEPTPROC pQueryAccept, CLEANUPPROC pCleanUp, STOPPROCESSPROC, REQUESTPROC pCustomRequest, LPCRITICAL_SECTION pCritSec, IPin ** ppPin); > +HRESULT PullPin_Construct(const IPinVtbl *PullPin_Vtbl, const PIN_INFO * pPinInfo, > + SAMPLEPROC_PULL pSampleProc, LPVOID pUserData, QUERYACCEPTPROC pQueryAccept, > + CLEANUPPROC pCleanUp, REQUESTPROC pCustomRequest, STOPPROCESSPROC pDone, > + LPCRITICAL_SECTION pCritSec, IPin ** ppPin); > > /**************************/ > /*** Pin Implementation ***/ > -- > 2.13.6 Maybe I'm blind (I read this from the cell phone, so definitely possible) but I don't see that you're adding any parameter, rather swapping two arguments in the header only. Just making sure that's what you meant to do.

1 0

Re: [PATCH 1/2] ntdll/tests: Don't abort if NtCancelFileIoEx() is missing.
by Zebediah Figura 09 Oct '17

09 Oct '17

On 10/09/2017 07:29 AM, Jacek Caban wrote: > Hi Zebediah, > > On 07.10.2017 00:18, Zebediah Figura wrote: >> - ok(U(iosb).Status == STATUS_CANCELLED, "Wrong iostatus %x\n", U(iosb).Status); >> - ok(WaitForSingleObject(hEvent, 0) == 0, "hEvent not signaled\n"); >> + ok(U(iosb).Status == STATUS_CANCELLED, "Wrong iostatus %x\n", U(iosb).Status); >> + ok(WaitForSingleObject(hEvent, 0) == 0, "hEvent not signaled\n"); >> + >> + CloseHandle(hPipe); >> + } >> + else >> + skip("NtCancelIoFileEx not available\n"); > > > Please use win_skip() instead. > > > Thanks, > > Jacek > > > Whoops, thanks. Resent.

1 0

Re: [PATCH] gdiplus: Added GdipSetImageAttributesNoOp()
by Vincent Povirk 09 Oct '17

09 Oct '17

This could use some tests. My guess is that there's an additional set of flags for "no op" that overrides the others.

1 0

Re: [PATCH V3] msvcp100: add time_get::do_get and time_get::get functions
by Piotr Caban 06 Oct '17

06 Oct '17

On 10/06/17 20:21, Vijay Kiran Kamuju wrote: > +#define call_time_get_char_do_get(this, ret, s, e, base, err, t, fmt, mod) CALL_VTBL_FUNC(this, 12, istreambuf_iterator_char*, \ > + (const time_get_char*, istreambuf_iterator_char*, istreambuf_iterator_char, istreambuf_iterator_char, ios_base*, int*, struct tm*, char, char), \ > + (this, ret, s, e, base, err, t, fmt, mod)) > +#else > +#define call_time_get_char_do_get(this, ret, s, e, base, err, t, fmt, mod) CALL_VTBL_FUNC(this, 20, istreambuf_iterator_char*, \ > + (const time_get_char*, istreambuf_iterator_char*, istreambuf_iterator_char, istreambuf_iterator_char, ios_base*, int*, struct tm*, char, char), \ > + (this, ret, s, e, base, err, t, fmt, mod)) You're calling wrong virtual functions in call_time_get_char_do_get macro. Second argument of CALL_VTBL_FUNC macro is function offset in virtual function table. Thanks, Piotr

1 0

Re: [v2] msvcrt: Introduce vf[w]printf_helper function.
by Piotr Caban 06 Oct '17

06 Oct '17

Hi, On 10/02/17 21:46, Gijs Vermeulen wrote: > -int CDECL MSVCRT_vfprintf(MSVCRT_FILE* file, const char *format, __ms_va_list valist) > +static int vfprintf_vfwprintf_helper(MSVCRT_FILE* file, const char *format, const MSVCRT_wchar_t *format_wide, > + __ms_va_list valist, MSVCRT__locale_t locale, DWORD options, BOOL wide) I would prefer to have a separate helper for vfprintf and vfwprintf functions. Also please reorder the parameters so it's more similar to _stdio_common_vfprintf. > + if(!MSVCRT_CHECK_PMT( file != NULL )) return -1; > + if(!(wide && MSVCRT_CHECK_PMT( format != NULL ))) return -1; This doesn't work as expected. It should look like this: if(!wide && !MSVCRT_CHECK_PMT(... Thanks, Piotr

1 0

Re: msvcp100: add time_get::do_get and time_get::get functions
by Piotr Caban 06 Oct '17

06 Oct '17

Hi, On 10/06/17 18:37, Vijay Kiran Kamuju wrote: > +#if _MSVCP_VER <= 100 > +#define call_time_get_char_do_get(this, ret, s, e, base, err, t, fmt, mod) CALL_VTBL_FUNC(this, 12, istreambuf_iterator_char*, \ > + (const time_get_char*, istreambuf_iterator_char*, istreambuf_iterator_char, istreambuf_iterator_char, ios_base*, int*, struct tm*, char, char), \ > + (this, ret, s, e, base, err, t)) > +#else > +#define call_time_get_char_do_get(this, ret, s, e, base, err, t, fmt, mod) CALL_VTBL_FUNC(this, 20, istreambuf_iterator_char*, \ > + (const time_get_char*, istreambuf_iterator_char*, istreambuf_iterator_char, istreambuf_iterator_char, ios_base*, int*, struct tm*, char, char), \ > + (this, ret, s, e, base, err, t)) > +#endif This will not compile (too few arguments are passed). > @@ -11613,6 +11644,9 @@ void __asm_dummy_vtables(void) { > VTABLE_ADD_FUNC(locale_facet__Decref) > #endif > VTABLE_ADD_FUNC(time_get_char_do_date_order) > +#if _MSVCP_VER >= 100 > + VTABLE_ADD_FUNC(time_get_char_do_get) > +#endif > VTABLE_ADD_FUNC(time_get_char_do_get_time) > VTABLE_ADD_FUNC(time_get_char_do_get_date) > VTABLE_ADD_FUNC(time_get_char_do_get_weekday) The order of virtual functions is incorrect. Thanks, Piotr

1 0

Re: ImmReleaseContext only return true
by Nikolay Sivov 06 Oct '17

06 Oct '17

On 06.10.2017 18:55, r00t0 wrote: > BOOL WINAPI ImmReleaseContext(HWND hWnd, HIMC hIMC) > { > - static BOOL shown = FALSE; > - > - if (!shown) { > - FIXME("(%p, %p): stub\n", hWnd, hIMC); > - shown = TRUE; > - } > - return TRUE; > + TRACE("(%p, %p): stub\n", hWnd, hIMC); > + return TRUE; > } Hi, Tomasz. What's a point of this change? (the rest of the diff seems to be whitespace changes only)

1 0

Re: ImmReleaseContext only return true
by Fabian Maurer 06 Oct '17

06 Oct '17

You seem to have a lot of unrelated white-space changes. > BOOL WINAPI ImmReleaseContext(HWND hWnd, HIMC hIMC) > { >- static BOOL shown = FALSE; >- >- if (!shown) { >- FIXME("(%p, %p): stub\n", hWnd, hIMC); >- shown = TRUE; >- } >- return TRUE; >+ TRACE("(%p, %p): stub\n", hWnd, hIMC); >+ return TRUE; > } What's the point behind this change? Regards, Fabian Maurer

1 0