October 2017 - Wine-devel - list.winehq.org

Re: msxml3: Use correct string length in saxreader_get_cdata_chunk
by Nikolay Sivov 06 Oct '17

06 Oct '17

On 05.10.2017 15:59, Piotr Caban wrote: > @@ -1972,6 +1972,7 @@ static BSTR saxreader_get_cdata_chunk(const xmlChar *str, int len) > BSTR bstr = bstr_from_xmlCharN(str, len), ret; > WCHAR *ptr; > > + len = SysStringLen(bstr); Hi. Just making sure I understand this correctly, the issue is that we're using length counted in xmlChars as WCHAR length?

2 2

Re: [PATCH] rsaenh: Fix length of some algorithm names in aProvEnumAlgsEx array.
by Michael Stefaniuc 05 Oct '17

05 Oct '17

Hello Alex, On 10/05/2017 09:15 AM, Alex Henrie wrote: > From: Louis Lenders <xerox.xerox2000x(a)gmail.com> > > Patch from Wine Staging. > > Signed-off-by: Louis Lenders <xerox.xerox2000x(a)gmail.com> > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> > --- > dlls/rsaenh/rsaenh.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/dlls/rsaenh/rsaenh.c b/dlls/rsaenh/rsaenh.c > index 3db828638b..97eb474374 100644 > --- a/dlls/rsaenh/rsaenh.c > +++ b/dlls/rsaenh/rsaenh.c > @@ -246,9 +246,9 @@ static const PROV_ENUMALGS_EX aProvEnumAlgsEx[5][RSAENH_MAX_ENUMALGS+1] = > - {CALG_SHA_256, 256,256, 256,CRYPT_FLAG_SIGNING, 6,"SHA-256", 30,"Secure Hash Algorithm (SHA-256)"}, > - {CALG_SHA_384, 384,384, 384,CRYPT_FLAG_SIGNING, 6,"SHA-384", 30,"Secure Hash Algorithm (SHA-384)"}, > - {CALG_SHA_512, 512,512, 512,CRYPT_FLAG_SIGNING, 6,"SHA-512", 30,"Secure Hash Algorithm (SHA-512)"}, > + {CALG_SHA_256, 256,256, 256,CRYPT_FLAG_SIGNING, 8,"SHA-256", 32,"Secure Hash Algorithm (SHA-256)"}, > + {CALG_SHA_384, 384,384, 384,CRYPT_FLAG_SIGNING, 8,"SHA-384", 32,"Secure Hash Algorithm (SHA-384)"}, > + {CALG_SHA_512, 512,512, 512,CRYPT_FLAG_SIGNING, 8,"SHA-512", 32,"Secure Hash Algorithm (SHA-512)"}, why don't you switch the whole big structure to automatically calculate the string sizes? Something like: #define X(str) sizeof(str), str ... {CALG_SHA_256, 256,256, 256,CRYPT_FLAG_SIGNING, X("SHA-256"), X("Secure Hash Algorithm (SHA-256)")}, ... #undef X The less the programmer can fat finger the merrier, especially in security related code. bye michael

1 0

Re: [PATCH] ntdll: Failure callback is optional in LdrResolveDelayLoadedAPI()
by Marvin 05 Oct '17

05 Oct '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33398 Your paranoid android. === w1064 (32 bit loader) === loader.c:3019: Test failed: Test 4: unexpected return value DEADBEEF. === w1064 (64 bit loader) === loader.c:3019: Test failed: Test 4: unexpected return value 00000000DEADBEEF.

1 0

Re: [3/3] gdiplus/tests: Add tests for gdi32 transform and clip caching.
by Marvin 05 Oct '17

05 Oct '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33389 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [3/3] gdiplus/tests: Add tests for gdi32 transform and clip caching.
by Marvin 05 Oct '17

05 Oct '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33389 Your paranoid android. === wvistau64 (32 bit graphics) === Can't locate object method "new" via package "URI" at /home/testbot/lib/WineTestBot/VMs.pm line 203, <DATA> line 751. Child process died unexpectedly === w864 (32 bit graphics) === Can't locate object method "new" via package "URI" at /home/testbot/lib/WineTestBot/VMs.pm line 203, <DATA> line 751. Child process died unexpectedly

1 0

Re: [v2 PATCH] qedit: Support IAMTimelineGroup interface in IAMTimelineObj
by Nikolay Sivov 05 Oct '17

05 Oct '17

On 05.10.2017 3:03, Alistair Leslie-Hughes wrote: > +static HRESULT WINAPI timelinegrp_QueryInterface(IAMTimelineGroup *iface, REFIID riid, void **object) > +{ > + TimelineObjImpl *This = impl_from_IAMTimelineGroup(iface); > + > + TRACE("(%p)->(%s %p)\n", This, debugstr_guid(riid), object); > + > + if (!object) > + return E_POINTER; There's no test for this condition. > + > + *object = NULL; > + if (IsEqualIID(riid, &IID_IUnknown) || > + IsEqualIID(riid, &IID_IAMTimelineGroup) ) > + *object = &This->IAMTimelineGroup_iface; > + else if (IsEqualIID(riid, &IID_IAMTimelineObj) ) > + *object = &This->IAMTimelineObj_iface; > + else > + WARN("(%p, %s,%p): not found\n", This, debugstr_guid(riid), object); > + > + if (!*object) > + return E_NOINTERFACE; > + > + IUnknown_AddRef((IUnknown*)*object); > + return S_OK; > +} That's not what I meant. Tests don't show that you need this. Please take a look how objects supporting multiple interfaces are implemented.

1 0

Re: [PATCH 4/4] user32: Don't invalidate ComboBox on CB_SETCURSEL message
by Marvin 04 Oct '17

04 Oct '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33383 Your paranoid android. === w7u (32 bit msg) === msg.c:12113: Test failed: WmMouseHoverSeq: 0: the msg sequence is not complete: expected 0118 - actual 0000 msg.c:12115: Test failed: wrong tme.dwFlags 00000001, expected 00000000 msg.c:12115: Test failed: wrong tme.hwndTrack 001C01BA, expected 00000000 msg.c:12115: Test failed: wrong tme.dwHoverTime 400, expected 0

1 0

Re: [PATCH] qedit: Support IAMTimelineGroup interface in IAMTimelineObj
by Nikolay Sivov 04 Oct '17

04 Oct '17

On 10/04/2017 07:40 AM, Alistair Leslie-Hughes wrote: > --- a/dlls/qedit/tests/timeline.c > +++ b/dlls/qedit/tests/timeline.c > @@ -126,7 +126,7 @@ static void test_timelineobj_interfaces(void) > IAMTimelineGroup *group; > > hr = IAMTimelineObj_QueryInterface(obj, &IID_IAMTimelineGroup, (void **)&group); > - todo_wine ok(hr == S_OK, "got %08x\n", hr); > + ok(hr == S_OK, "got %08x\n", hr); > if(hr == S_OK) > IAMTimelineGroup_Release(group); You don't need if() after this patch. > +static HRESULT WINAPI timelinegrp_QueryInterface(IAMTimelineGroup *iface, REFIID riid, void **object) > +{ > + TimelineObjImpl *This = impl_from_IAMTimelineGroup(iface); > + > + TRACE("(%p)->(%s %p)\n", This, debugstr_guid(riid), object); > + > + if (!object) > + return E_POINTER; > + > + *object = NULL; > + if (IsEqualIID(riid, &IID_IUnknown) || > + IsEqualIID(riid, &IID_IAMTimelineGroup) ) > + *object = &This->IAMTimelineGroup_iface; > + else > + WARN("(%p, %s,%p): not found\n", This, debugstr_guid(riid), object); > + > + if (!*object) > + return E_NOINTERFACE; > + > + IUnknown_AddRef((IUnknown*)*object); > + return S_OK; > +} This looks wrong, but not impossible. Can you query IAMTimelineObj back from IAMTimelineGroup? Looks like we don't have tests showing that you can't do that.

1 0

Re: [Rediffed PATCH] ntdll: Add stub for RtlGetUnloadEventTrace
by Alex Henrie 04 Oct '17

04 Oct '17

+#define RTL_UNLOAD_EVENT_TRACE_NUMBER 64 +RTL_UNLOAD_EVENT_TRACE RtlpUnloadEventTrace[RTL_UNLOAD_EVENT_TRACE_NUMBER]; Why did you add these? If you don't need them for the stub implementation, I recommend submitting a revised patch without them. -Alex

1 1

Wine 2.18 source code scanned with cppcheck 1.72
by Игорь Чебаненко 03 Oct '17

03 Oct '17

2 1