September 2017 - Wine-devel

Re: [PATCH 3/5] wined3d: Advertise AUTOGENMIPMAP only for renderable and filterable formats.
by Marvin 20 Sep '17

20 Sep '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33191 Your paranoid android. === w8 (32 bit device) === device.c:6945: Test failed: Got unexpected hr 0. === w864 (32 bit device) === device.c:6945: Test failed: Got unexpected hr 0. === w1064 (32 bit device) === device.c:6945: Test failed: Got unexpected hr 0. === w864 (64 bit device) === device.c:6945: Test failed: Got unexpected hr 0. === w1064 (64 bit device) === device.c:6945: Test failed: Got unexpected hr 0.

1 0

Re: [PATCH 2/5] d3d9/tests: Add a test for nonrenderable format D3DUSAGE_AUTOGENMIPMAP support.
by Marvin 20 Sep '17

20 Sep '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33190 Your paranoid android. === w8 (32 bit device) === device.c:6945: Test failed: Got unexpected hr 0. === w864 (32 bit device) === device.c:6945: Test failed: Got unexpected hr 0. === w1064 (32 bit device) === device.c:6945: Test failed: Got unexpected hr 0. === w864 (64 bit device) === device.c:6945: Test failed: Got unexpected hr 0. === w1064 (64 bit device) === device.c:6945: Test failed: Got unexpected hr 0.

1 0

Re: [PATCH] GdiPlus: Add GdipCreateLineBrushFromRectWithAngle tests and fix compat
by Vincent Povirk 20 Sep '17

20 Sep '17

This causes warnings: ../../../../dlls/gdiplus/tests/brush.c: In function ‘test_createLineBrushFromRectWithAngle’: ../../../../dlls/gdiplus/tests/brush.c:85:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] GpRectF rect2 = { 1, 3, -1, -2 }; ^ ../../../../dlls/gdiplus/tests/brush.c:108:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] GpRectF rect3 = { 1, 3, 0, 1 }; ^ ../../../../dlls/gdiplus/tests/brush.c:112:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] GpRectF rect4 = { 1, 3, 1, 0 }; ^

1 0

Re: [1/3] ole32: Add a trace to IDataObject::GetData.
by Huw Davies 20 Sep '17

20 Sep '17

On Wed, Sep 20, 2017 at 02:54:05PM +0300, Dmitry Timoshkov wrote: > Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> > --- > dlls/ole32/datacache.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/dlls/ole32/datacache.c b/dlls/ole32/datacache.c > index ecae89d284..4e684b4189 100644 > --- a/dlls/ole32/datacache.c > +++ b/dlls/ole32/datacache.c > @@ -1245,6 +1245,8 @@ static HRESULT WINAPI DataCache_GetData( > DataCache *This = impl_from_IDataObject(iface); > DataCacheEntry *cache_entry; > > + TRACE("%p,%s,%p\n", iface, debugstr_formatetc(pformatetcIn), pmedium); > + > memset(pmedium, 0, sizeof(*pmedium)); > > cache_entry = DataCache_GetEntryForFormatEtc(This, pformatetcIn); I've resent this one and [2/3] with spaces between the commas in the TRACE()s. I hope that's ok with you. Huw.

2 1

Re: [PATCH] include: Remove D3D_DISABLE_9EX checks.
by Henri Verbeet 20 Sep '17

20 Sep '17

On 20 September 2017 at 07:13, Alex Henrie <alexhenrie24(a)gmail.com> wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=37160 > > The other option is to add D3D_DISABLE_9EX checks to d3d9.h, but I don't > think it will break anything to declare the new stuff unconditionally. > I'd rather do it right.

1 0

[PATCH 4/4] include: Add dxgi1_6.idl
by Shinchiro Shinchiro 20 Sep '17

20 Sep '17

When I try compiling this idl with widl, I'm getting segfault. I can't figure what's wrong with it

1 1

Re: [PATCH v2 2/2] msi: Store the current script in the package.
by Hans Leidekker 19 Sep '17

19 Sep '17

On Tue, 2017-09-19 at 11:59 -0500, Zebediah Figura wrote: > Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> > --- > dlls/msi/action.c | 25 +++++++++++++++---------- > dlls/msi/custom.c | 34 ++-------------------------------- > dlls/msi/dialog.c | 2 +- > dlls/msi/install.c | 8 ++++---- > dlls/msi/msi.c | 6 +++--- > dlls/msi/msipriv.h | 8 +++----- > dlls/msi/package.c | 1 + > 7 files changed, 29 insertions(+), 55 deletions(-) action.c: In function ‘execute_script’: action.c:1549:16: warning: assignment makes integer from pointer without a cast for (i = package->script_actions_count; i > 0; i--) ^

1 0

Re: [PATCH v2 1/2] msi: Remove a superfluous substructure.
by Hans Leidekker 19 Sep '17

19 Sep '17

On Tue, 2017-09-19 at 11:58 -0500, Zebediah Figura wrote: > v2: don't use lists > Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> > --- > dlls/msi/action.c | 45 ++++++++++++++++++++------------------------- > dlls/msi/custom.c | 39 ++++++++++++++++----------------------- > dlls/msi/msipriv.h | 36 +++++++++++++++--------------------- > dlls/msi/package.c | 31 ++++++++++++------------------- > 4 files changed, 63 insertions(+), 88 deletions(-) This gives a warning: package.c: In function ‘msi_alloc_package’: package.c:999:9: warning: unused variable ‘i’ [-Wunused-variable] int i; ^

1 0

Re: [PATCH 3/3] msi: Remove properties from deferred custom actions.
by Hans Leidekker 19 Sep '17

19 Sep '17

On Tue, 2017-09-19 at 00:23 -0500, Zebediah Figura wrote: > This effectively reverts 3c444ea350e0688247bd2056b3861dac4af08fbc, > which should not be necessary, and in fact does not affect the > linked application, MSN Messenger. This needs a test.

2 1

Re: [PATCH] Spec entries fixes.
by Alexandre Julliard 19 Sep '17

19 Sep '17

Andrey Gusev <andrey.goosev(a)gmail.com> writes: > Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> > --- > dlls/advapi32/advapi32.spec | 2 +- > .../api-ms-win-core-console-l2-1-0.spec | 2 +- > .../api-ms-win-core-localization-l2-1-0.spec | 2 +- > .../api-ms-win-core-registry-l2-1-0.spec | 2 +- > .../ext-ms-win-rtcore-ntuser-sysparams-l1-1-0.spec | 2 +- > dlls/kernel32/kernel32.spec | 4 +-- > dlls/kernelbase/kernelbase.spec | 4 +-- > dlls/mpr/mpr.spec | 2 +- > dlls/rasapi32/rasapi32.spec | 4 +-- > dlls/shlwapi/shlwapi.spec | 4 +-- > dlls/unicows/unicows.spec | 38 +++++++++++----------- > dlls/user32/user32.spec | 6 ++-- > 12 files changed, 36 insertions(+), 36 deletions(-) Please don't do large scale changes like this, it should be one module at a time. Also please try to lookup previous similar patches, a number of these have been rejected already. -- Alexandre Julliard julliard(a)winehq.org

1 0