June 2022 - Wine-devel - list.winehq.org

[tools] testbot/Janitor: Clean up obsolete failures.
by Francois Gouget 27 Jun '22

27 Jun '22

Delete failures that have been marked for deletion once they are no longer referenced. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- testbot/bin/Janitor.pl | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/testbot/bin/Janitor.pl b/testbot/bin/Janitor.pl index 618c31d022..839e1a942c 100755 --- a/testbot/bin/Janitor.pl +++ b/testbot/bin/Janitor.pl @@ -43,6 +43,7 @@ $Name0 =~ s+^.*/++; use File::Path; use WineTestBot::Config; +use WineTestBot::Failures; use WineTestBot::Jobs; use WineTestBot::Log; use WineTestBot::Patches; @@ -193,6 +194,22 @@ if ($JobPurgeDays != 0) } } +# And also failures marked for deletion +my $Failures = CreateFailures(); +$Failures->AddFilter("BugStatus", ["deleted"]); +foreach my $Failure (@{$Failures->GetItems()}) +{ + if ($Failure->TaskFailures->IsEmpty()) + { + $Failures->DeleteItem($Failure); + } + else + { + my $TaskFailure = @{$Failure->TaskFailures->GetItems()}[0]; + Trace "Keeping failure ", $Failure->Id, " for task log ", join("/", $TaskFailure->JobId, $TaskFailure->StepNo, $TaskFailure->TaskNo, $TaskFailure->TaskLog), "\n"; + } +} + # Purge the deleted VMs if they are not referenced anymore my $VMs = CreateVMs(); $VMs->AddFilter("Role", ["deleted"]); -- 2.30.2

1 0

[PATCH 0/1] MR315: windowscodecs: Fix non-zero alpha detection in ImagingFactory_CreateBitmapFromHICON.
by Jinoh Kang (＠iamahuman) 27 Jun '22

27 Jun '22

Increment pixel pointer for every *pixel*, not every *stride*. Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/315

3 2

Re: [PATCH v6 0/5] MR310: mf: Fix several reference leaks.
by Rémi Bernon 27 Jun '22

27 Jun '22

v6: Restore temporary todo_wine in PATCH 2, lost in the split. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/310#note_2800

1 0

[PATCH v5 0/5] MR310: mf: Fix several reference leaks.
by Rémi Bernon 27 Jun '22

27 Jun '22

So that the mf tests pass again on 32bit on the testbot, though they still fail locally with `LIBGL_ALWAYS_SOFTWARE=true GALLIUM_DRIVER=softpipe`. -- v5: mf: Uninitialize renderer before creating mixer and presenter. mf: Release video renderer services before re-initializing. mf: Avoid leaking nodes in IMFTopoLoader_Load. mf/tests: Add some missing IMFActivate_Shutdown calls. mf/tests: Add more consistent reference count checks. https://gitlab.winehq.org/wine/wine/-/merge_requests/310

2 9

[PATCH v4 0/5] MR310: mf: Fix several reference leaks.
by Rémi Bernon 27 Jun '22

27 Jun '22

So that the mf tests pass again on 32bit on the testbot, though they still fail locally with `LIBGL_ALWAYS_SOFTWARE=true GALLIUM_DRIVER=softpipe`. -- v4: mf: Uninitialize renderer before creating mixer and presenter. mf: Release video renderer services before re-initializing. mf: Avoid leaking nodes in IMFTopoLoader_Load. mf/tests: Add some missing IMFActivate_Shutdown calls. mf/tests: And more consistent reference count checks. https://gitlab.winehq.org/wine/wine/-/merge_requests/310

2 8

Re: [PATCH v8 0/9] MR6: Avoid performance degradation due to vDSO unmapping (BZ#52313)
by Jinoh Kang (＠iamahuman) 27 Jun '22

27 Jun '22

> When running under qemu-user CPU emulation, this can mean we not only remove the vdso from the process being launched (a performance degradation), but also clobber it out from under the qemu-user emulator hosting the wine-preloader process - which is in fact in the midst of a call to mmap that is *using* the vdso, so the emulator then segfaults before returning I'd call a QEMU bug. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6#note_2791

1 0

[PATCH v3 0/4] MR310: mf: Fix several reference leaks.
by Rémi Bernon 27 Jun '22

27 Jun '22

So that the mf tests pass again on 32bit on the testbot, though they still fail locally with `LIBGL_ALWAYS_SOFTWARE=true GALLIUM_DRIVER=softpipe`. -- v3: mf: Uninitialize renderer before creating mixer and presenter. mf: Release video renderer services before re-initializing. mf: Avoid leaking nodes in IMFTopoLoader_Load. mf/tests: Add some missing IMFActivate_Shutdown calls. https://gitlab.winehq.org/wine/wine/-/merge_requests/310

3 8

[PATCH 0/1] MR324: vbscript: Use return_null in more places.
by Robert Wilhelm (＠sloper42) 27 Jun '22

27 Jun '22

Signed-off-by: Robert Wilhelm <robert.wilhelm(a)gmx.net> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/324

3 2

[PATCH v2 0/2] MR305: regedit: Add support for REG_QWORD type.
by Nikolay Sivov (＠nsivov) 27 Jun '22

27 Jun '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: regedit: Remove unnecessary string conversion when modifying REG_DWORD value. regedit: Add support for REG_QWORD type. https://gitlab.winehq.org/wine/wine/-/merge_requests/305

4 4

Re: [PATCH v8 0/9] MR6: Avoid performance degradation due to vDSO unmapping (BZ#52313)
by Kevin Puetz (＠puetzk) 27 Jun '22

27 Jun '22

Another interesting case in this same area is qemu-user emulation. As you say, right now wine-preloader just uses MAP_FIXED and removes anything in its way (potentially including the vdso of ASLR put it in the way). When running under qemu-user CPU emulation, this can mean we not only remove the vdso from the process being launched (a performance degradation), but also clobber it out from under the qemu-user emulator hosting the wine-preloader process - which is in fact in the midst of a call to mmap that is *using* the vdso, so the emulator then segfaults before returning (intermittently, since ASLR doesn't always put the vdso in the way, but often enough I have seen it hit the in[0x7ffffe000000, +0x01ff0000 range](https://gitlab.winehq.org/wine/wine/-/blob/master/loader/preloader.c… I'm just remapping it won't fix that problem (having it move mid-call is going to be just as fatal as unmapping it), but it potentially makes it more tractable. qemu is already holding some separation/tagging of host vs guest, so maybe it could special case mremap to move it for us but retain it for its own purposes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6#note_2780

1 0