June 2022 - Wine-devel - list.winehq.org

Re: [PATCH v2 0/3] MR310: mf: Fix several reference leaks.
by Rémi Bernon 27 Jun '22

27 Jun '22

On Mon Jun 27 07:52:49 2022 +0000, Nikolay Sivov wrote: > This is already done in video_renderer_initialize(). Maybe it's not > triggered on shutdown? I think the test failure may come from a missing the `video_renderer_release_presenter_services` call, though I haven't really investigated that aspect of the problem. If it's the case, perhaps it should be added to `video_renderer_initialize` too. The issue with the testbot and 32bit apps is that the way `Initialize` is currently written it create a second video renderer before releasing the previously created one. This requires another d3d device initialization, which often fails from address space exhaustion, so releasing the previous renderer first was resolving the issue (and the reference leak also probably made it worse). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/310#note_2750

1 0

Re: [PATCH v2 0/3] MR310: mf: Fix several reference leaks.
by Nikolay Sivov (＠nsivov) 27 Jun '22

27 Jun '22

Nikolay Sivov (@nsivov) commented about dlls/mf/evr.c: > + renderer->mixer = NULL; > + } > + > + if (renderer->presenter) > + { > + video_renderer_release_presenter_services(renderer); > + IMFVideoPresenter_Release(renderer->presenter); > + renderer->presenter = NULL; > + } > + > + if (renderer->device_manager) > + { > + IUnknown_Release(renderer->device_manager); > + renderer->device_manager = NULL; > + } > + This is already done in video_renderer_initialize(). Maybe it's not triggered on shutdown? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/310#note_2749

1 0

[PATCH 0/17] MR319: d2d1: Initial implementation of effect properties handling
by Nikolay Sivov (＠nsivov) 27 Jun '22

27 Jun '22

-- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/319

1 0

[PATCH 0/1] MR316: wbemprox: Use return length from NtQuerySystemInformationEx().
by Brendan Shanks (＠bshanks) 27 Jun '22

27 Jun '22

The return length is unlikely to change between the two NtQuerySystemInformationEx calls, but it's possible, and it's more correct to parse the entries with the length from the call where the data was returned. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/316

3 2

[PATCH 0/5] MR318: light.msstyles: Add Vista+ button parts.
by Zhiyi Zhang (＠zhiyi) 27 Jun '22

27 Jun '22

These theme parts are queried by Qt5 applications. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/318

2 5

[PATCH 0/6] MR317: uxtheme/tests: Test that DrawThemeBackgroundEx() is at ordinal 47.
by Zhiyi Zhang (＠zhiyi) 27 Jun '22

27 Jun '22

Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/317

2 6

[PATCH 0/6] MR265: kernelbase: Implement PrefetchVirtualMemory.
by Jinoh Kang (＠iamahuman) 26 Jun '22

26 Jun '22

Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/265

3 9

[PATCH v5 0/1] MR296: nsiproxy.sys: Add static ARP entries which are always present on Windows.
by Paul Gofman (＠gofman) 26 Jun '22

26 Jun '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53175 Split off from MR https://gitlab.winehq.org/wine/wine/-/merge_requests/286. -- v5: nsiproxy.sys: Add static ARP entries which are always present on Windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/296

3 3

[PATCH v4 0/9] MR272: d3dx10: Add D3DX10CreateThreadPump implementation.
by Piotr Caban (＠piotr) 26 Jun '22

26 Jun '22

The GetWorkItemCount implementation may look strange. It's done this way because of how WaitForAllItems is implemented. Alternative solution is to introduce separate counter for GetWorkItemCount. -- v4: d3dx10/tests: Add D3DX10CreateThreadPump tests. d3dx10: Add ID3DX10ThreadPump:PurgeAllItems implementation. d3dx10: Add ID3DX10ThreadPump:GetQueueStatus implementation. d3dx10: Add ID3DX10ThreadPump:WaitForAllItems implementation. d3dx10: Add ID3DX10ThreadPump:ProcessDeviceWorkItems implementation. d3dx10: Add ID3DX10ThreadPump:GetWorkItemCount implementation. d3dx10: Add ID3DX10ThreadPump:AddWorkItem implementation. d3dx10: Add D3DX10CreateThreadPump stub. d3dx10/tests: Fix texture leak in check_resource_data. https://gitlab.winehq.org/wine/wine/-/merge_requests/272

2 9

[PATCH 0/2] MR314: ntdll/tests: Preserve EFLAGS across syscall on x64.
by Jinoh Kang (＠iamahuman) 26 Jun '22

26 Jun '22

Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/314

2 2