June 2022 - Wine-devel - list.winehq.org

[PATCH v2 0/1] MR312: winex11.drv: Increment configure_serial in X11DRV_WindowPosChanged() even if...
by Paul Gofman (＠gofman) 27 Jun '22

27 Jun '22

Once we reached that place where sync_window_position() is called (or not called if window is about to be minimized or maximized) the old in-flight X_ConfigureNotify do not make sense anymore. sync_window_position() does that unconditionally but if we don't call it for minimize / maximize we should probably discard them regardless. An example of the failing scenario which this patch is fixing is the following: 1. App calls SetWindowPos() with some size, X_ConfigureNotify is in flight; 2. App calls ShowWindow(SW_MAXIMIZE), old X_ConfigureNotify is still in flight; sync_window_position() is not called and configure_serial is not updated; 3. Now X_ConfigureNotify from p.1 arrives and it gets processed like WM is changing window size back, that confuses the app and since the reaction on the new app's SetWindowPos / maximizing is also delayed and then X events triggered by p. 2. also arribe later. That may cause endless loop with non-functional window. -- v2: winex11.drv: Increment configure_serial in X11DRV_WindowPosChanged() even if not syncing window position. https://gitlab.winehq.org/wine/wine/-/merge_requests/312

2 3

[PATCH 0/5] MR322: winex11.drv: Preparation for nulldrv display modes.
by Rémi Bernon 27 Jun '22

27 Jun '22

The idea is to have a `add_mode` manager callback and enumerate adapter modes when updating display devices. Then the modes would be read from the registry and cached with the adapters and monitors, allowing us to move more things to win32u. This MR is a preparation towards that, moving the `winex11` settings handler to display.c, and making sure we do not enumerate display modes before they have been initialized or while the list is being built. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/322

2 11

[PATCH v2 0/1] MR320: riched20/tests: Test for ITextDocument::Undo and ITextDocument::Redo.
by Jinoh Kang (＠iamahuman) 27 Jun '22

27 Jun '22

Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v2: riched20/tests: Test for ITextDocument::Undo and ITextDocument::Redo. https://gitlab.winehq.org/wine/wine/-/merge_requests/320

2 1

[PATCH 0/2] MR323: winebus.sys: Move bus_event list entry to an internal structure.
by Rémi Bernon 27 Jun '22

27 Jun '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/323

1 2

[PATCH vkd3d v2 1/7] tests: Test dot() intrinsic.
by Giovanni Mascellani 27 Jun '22

27 Jun '22

Signed-off-by: Giovanni Mascellani <gmascellani(a)codeweavers.com> --- v2: * Fixed test case for SM1 --- Makefile.am | 1 + tests/hlsl-dot.shader_test | 96 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 97 insertions(+) create mode 100644 tests/hlsl-dot.shader_test diff --git a/Makefile.am b/Makefile.am index ad6a0a41..400e79e1 100644 --- a/Makefile.am +++ b/Makefile.am @@ -68,6 +68,7 @@ vkd3d_shader_tests = \ tests/hlsl-clamp.shader_test \ tests/hlsl-comma.shader_test \ tests/hlsl-cross.shader_test \ + tests/hlsl-dot.shader_test \ tests/hlsl-duplicate-modifiers.shader_test \ tests/hlsl-for.shader_test \ tests/hlsl-function.shader_test \ diff --git a/tests/hlsl-dot.shader_test b/tests/hlsl-dot.shader_test new file mode 100644 index 00000000..cb117d15 --- /dev/null +++ b/tests/hlsl-dot.shader_test @@ -0,0 +1,96 @@ +[pixel shader] +uniform float4 x; +uniform float4 y; + +float4 main() : SV_TARGET +{ + return dot(x, y); +} + +[test] +uniform 0 float4 2.0 3.0 4.0 5.0 +uniform 4 float4 10.0 11.0 12.0 13.0 +todo draw quad +probe all rgba (166.0, 166.0, 166.0, 166.0) + +[pixel shader] +uniform float2 x; +uniform float4 y; + +float4 main() : SV_TARGET +{ + return dot(x, y); +} + +[test] +uniform 0 float4 2.0 3.0 0.0 0.0 +uniform 4 float4 10.0 11.0 12.0 13.0 +todo draw quad +probe all rgba (53.0, 53.0, 53.0, 53.0) + +[pixel shader] +uniform float x; +uniform float4 y; + +float4 main() : SV_TARGET +{ + return dot(x, y); +} + +[test] +uniform 0 float4 2.0 0.0 0.0 0.0 +uniform 4 float4 10.0 11.0 12.0 13.0 +todo draw quad +probe all rgba (92.0, 92.0, 92.0, 92.0) + +[pixel shader] +uniform float x; +uniform float y; + +float4 main() : SV_TARGET +{ + return dot(x, y); +} + +[test] +% Account for both the SM1 and SM4 uniform layout +uniform 0 float4 2.0 3.0 0.0 0.0 +uniform 4 float4 3.0 0.0 0.0 0.0 +todo draw quad +probe all rgba (6.0, 6.0, 6.0, 6.0) + +[pixel shader fail] +uniform float1x1 x; +uniform float4 y; + +float4 main() : SV_TARGET +{ + return dot(x, y); +} + +[pixel shader fail] +uniform float1x4 x; +uniform float4 y; + +float4 main() : SV_TARGET +{ + return dot(x, y); +} + +[pixel shader fail] +uniform float4x1 x; +uniform float4 y; + +float4 main() : SV_TARGET +{ + return dot(x, y); +} + +[pixel shader fail] +uniform float4x4 x; +uniform float4 y; + +float4 main() : SV_TARGET +{ + return dot(x, y); +} -- 2.36.1

3 20

[PATCH v2 0/5] MR321: win32u: menu conversion
by Jacek Caban (＠jacek) 27 Jun '22

27 Jun '22

-- v2: user32: Remove no longer needed helpers. win32u: Move menu object declarations to menu.c. https://gitlab.winehq.org/wine/wine/-/merge_requests/321

4 8

Re: [PATCH v2 0/3] MR310: mf: Fix several reference leaks.
by Nikolay Sivov (＠nsivov) 27 Jun '22

27 Jun '22

On Mon Jun 27 07:57:50 2022 +0000, Rémi Bernon wrote: > I think the test failure may come from a missing the > `video_renderer_release_presenter_services` call, though I haven't > really investigated that aspect of the problem. If it's the case, > perhaps it should be added to `video_renderer_initialize` too. > The issue with the testbot and 32bit apps is that the way `Initialize` > is currently written it create a second video renderer before releasing > the previously created one. This requires another d3d device > initialization, which often fails from address space exhaustion, so > releasing the previous renderer first was resolving the issue (and the > reference leak also probably made it worse). Ok, that's probably fine then. This release should happen only in "!`EVR_SHUT_DOWN`" branch, it's fine to move releasing part of `video_renderer_initialize` right there, because it's not going to be used outside of `Initialize()`. Having another helper _uninitialize() is also an option to keep method body easier to read. Note that with current patch you have returns while holding a lock. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/310#note_2756

1 0

[PATCH 0/5] MR321: win32u: menu conversion
by Jacek Caban (＠jacek) 27 Jun '22

27 Jun '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/321

2 5

Re: [PATCH v3 0/1] MR306: reg: Add REG_QWORD support to 'add'. - approved
by Hugh McMaster (＠hmc) 27 Jun '22

27 Jun '22

This merge request was approved by Hugh McMaster. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/306

1 0

[PATCH 0/1] MR320: riched20/tests: Test for ITextDocument::Undo and ITextDocument::Redo.
by Jinoh Kang (＠iamahuman) 27 Jun '22

27 Jun '22

Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/320

2 1