June 2022 - Wine-devel - list.winehq.org

Re: [PATCH v4 0/1] MR192: ws2_32: Allow getsockname after AcceptEx - approved
by Zebediah Figura (＠zfigura) 20 Jun '22

20 Jun '22

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/192

1 0

Re: [PATCH v2 0/1] MR259: d3d11: Remove null dxgi object checks. - approved
by Zebediah Figura (＠zfigura) 20 Jun '22

20 Jun '22

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/259

1 0

Re: [PATCH v2 0/1] MR279: d3drm: IDirect3DRMMeshBuilder3 Optimize fake success - approved
by Zebediah Figura (＠zfigura) 20 Jun '22

20 Jun '22

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/279

1 0

[PATCH v3 0/3] MR281: A few fixes in xmllite
by David Kahurani (＠kahurani) 20 Jun '22

20 Jun '22

-- v3: xmllite/writer: Fix typo in a comment xmllite/writer: Handle possible memory allocation failures xmllite/reader: Avoid memory leak on error path https://gitlab.winehq.org/wine/wine/-/merge_requests/281

3 4

[PATCH v2 0/2] MR283: ntdll: Filter EFlags from user-supplied CONTEXT on x86 and x64.
by Jinoh Kang (＠iamahuman) 20 Jun '22

20 Jun '22

-- v2: ntdll: Filter EFlags from user-supplied CONTEXT on x86 and x64. ntdll/tests: Test for setting x86 / x64 EFLAGS register in context. https://gitlab.winehq.org/wine/wine/-/merge_requests/283

3 3

[tools] testbot/Engine: Don't schedule jobs until the initialization is done.
by Francois Gouget 20 Jun '22

20 Jun '22

On startup the Engine starts processes to check the state of each VM, marking them as dirty in the process. But the VM status change causes ScheduleJobs() to be called through the VMStatusChange notification, potentially before all check processes have been started. So make sure no job is scheduled until the Engine is ready. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- testbot/bin/Engine.pl | 1 + testbot/lib/WineTestBot/Engine/Scheduler.pm | 21 +++++++++++++++++++-- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/testbot/bin/Engine.pl b/testbot/bin/Engine.pl index 9d836529c3..39577d14ca 100755 --- a/testbot/bin/Engine.pl +++ b/testbot/bin/Engine.pl @@ -780,6 +780,7 @@ sub main() # Cleanup starts processes to update the VMs. Run ScheduleJobs() now so it # can detect if these processes get stuck. + StartJobScheduler(); ScheduleJobs(); # Check for patches that arrived while the server was off. diff --git a/testbot/lib/WineTestBot/Engine/Scheduler.pm b/testbot/lib/WineTestBot/Engine/Scheduler.pm index 1b21ab9742..f91bf3fd03 100644 --- a/testbot/lib/WineTestBot/Engine/Scheduler.pm +++ b/testbot/lib/WineTestBot/Engine/Scheduler.pm @@ -28,7 +28,7 @@ WineTestBot::Engine::Scheduler - Schedules the TestBot tasks =cut use Exporter 'import'; -our @EXPORT = qw(ScheduleJobs CheckJobs); +our @EXPORT = qw(StartJobScheduler ScheduleJobs CheckJobs); use File::Copy; @@ -945,7 +945,24 @@ sub _PowerOffDirtyVMs($) } } -my $_InScheduleJobs; +my $_InScheduleJobs = 1; + +=pod +=over 12 + +=item C<StartJobScheduler()> + +Job scheduling is disabled initially to let the Engine perform its +initialization without interference. + +=back +=cut + +sub StartJobScheduler() +{ + $_InScheduleJobs = undef; +} + my $_LastTaskCounts = ""; =pod -- 2.30.2

1 0

[tools] testbot/web: Show the web patch id as a tooltip.
by Francois Gouget 20 Jun '22

20 Jun '22

This helps cross-reference the TestBot patch list with the jobs and patches website. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- testbot/web/PatchesList.pl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/testbot/web/PatchesList.pl b/testbot/web/PatchesList.pl index fc074ada1a..bf7c52b203 100644 --- a/testbot/web/PatchesList.pl +++ b/testbot/web/PatchesList.pl @@ -53,7 +53,9 @@ sub GenerateDataView($$$) $Row->{Item}->Disposition =~ /job ([0-9]+)$/) { my $JobId = $1; - print "<a href='/JobDetails.pl?Key=$JobId'>Job $JobId</a>"; + my $Title = $Row->{Item}->WebPatchId; + $Title = " title='Web patch $Title'" if ($Title); + print "<a href='/JobDetails.pl?Key=$JobId'$Title>Job $JobId</a>"; } else { -- 2.30.2

1 0

[PATCH v3 0/6] Fix LVS_OWNERDATA list view multi select.
by Angelo Haller 20 Jun '22

20 Jun '22

From: Angelo Haller <angelo(a)szanni.org> The following patches fix sending of the LVN_ODSTATECHANGED notification for LVS_OWNERDATA list views, adding more refined tests in the process and fixing various bugs. This is v3 addressing most of the concerns that were raised in v2, especially adding even more tests. I was sadly not able to trigger any deselect sequences through emulating mouse clicks. I was actually completely unable even send a lef mouse button down at all. Both SendMessage and SendInput fail, on wind and windows. I am unsure if programmatic mouse clicks are even supported in list views? Some forums seem to suggest, that this is only the case for buttons and similar elements. I was following the code snippets in other parts of the comctl32 tests. The other thing might be that the signal is getting caught somewhere in the test code. If anybody has any more insight in this regard, I'd be happy to add additional mouse click tests as well. The other thing I was unable to do is activate the single select tests via SHIFT/+COMMAND to show we need patch 6/6. Windows weirdly informs about the selected item twice, once to inform the item has been selected and then in another call later about the item being focused as well. This seemingly only affects LVS_OWNERDATA listviews from my tests. Warning: I have had access to the Windows Research Kernel (WRK) 1.2 ~10 years ago. These changes are regarding comctrl32 & tests which are NOT part of the WRK. As outlined in https://wiki.winehq.org/Developer_FAQ this should therefore satisfy the requirement of ONLY submitting patches to components I have NOT had access to. Angelo Haller (6): comctl32/tests: Expand ownerdata listview tests. comctl32/listview: Fix deselect on LVS_OWNERDATA. comctl32/listview: Move sending LVN_ODSTATECHANGED notifications to a function. comctl32/listview: Send LVN_ODSTATECHANGED only for virtual lists. comctl32/listview: Send LVN_ODSTATECHANGED notification. comctl32/listview: Send LVN_ODSTATECHANGED only for true ranges. dlls/comctl32/listview.c | 55 ++++--- dlls/comctl32/tests/listview.c | 253 +++++++++++++++++++++++++++++++-- 2 files changed, 281 insertions(+), 27 deletions(-) Signed-off-by: Angelo Haller <angelo(a)szanni.org> -- 2.36.1

3 14

[PATCH 0/7] MR285: win32u: Default window proc conversion
by Jacek Caban (＠jacek) 20 Jun '22

20 Jun '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/285

5 13

[PATCH 0/3] MR263: iphlpapi: Implement GetBestRoute2.
by Jinoh Kang (＠iamahuman) 20 Jun '22

20 Jun '22

A major problem with this patch is that the function is agnostic to the source argument. Even after some tinkering I still haven't figured out how exactly Windows uses this argument. Also, possibly move GetBestRoute2 implementation to nsiproxy.sys if applicable? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/263

3 4