Re: [PATCH] d3dx9_36: Cube texture can be loaded as a simple texture. The first face texture is taken in that case.

[Józef Kucia]

Hi,

On Sun, Sep 23, 2012 at 8:44 PM, Christian Costa <titan.costa(a)gmail.com>wrote:
> +        hr = IDirect3DTexture9_LockRect(texture, 0, &lock_rect, NULL,
> D3DLOCK_READONLY);
> +        ok(hr == D3D_OK, "IDirect3DTexture9_LockTexture returned %#x,
> expected %#x\n", hr, D3D_OK);
> +        if (SUCCEEDED(hr))
> +            for (i = 0; i < 16; i++)
> +                ok(((BYTE*)lock_rect.pBits)[i] == dds_cube_map[128+i],
> "Byte at index %u is 0x%02x, expected 0x%02x\n", i,
> ((BYTE*)lock_rect.pBits)[i], dds_cube_map[144+i]);
> +        IDirect3DTexture9_Release(texture);

You should call IDirect3DTexture9_UnlockRect before
IDirect3DTexture9_Release.

[PATCH] d3dx9_36: Cube texture can be loaded as a simple texture. The first face texture is taken in that case.

[Christian Costa]

2012/9/24 Józef Kucia <joseph.kucia(a)gmail.com>
> Hi,
>
> On Sun, Sep 23, 2012 at 8:44 PM, Christian Costa <titan.costa(a)gmail.com>wrote:
> > +        hr = IDirect3DTexture9_LockRect(texture, 0, &lock_rect, NULL,
> > D3DLOCK_READONLY);
> > +        ok(hr == D3D_OK, "IDirect3DTexture9_LockTexture returned %#x,
> > expected %#x\n", hr, D3D_OK);
> > +        if (SUCCEEDED(hr))
> > +            for (i = 0; i < 16; i++)
> > +                ok(((BYTE*)lock_rect.pBits)[i] == dds_cube_map[128+i],
> > "Byte at index %u is 0x%02x, expected 0x%02x\n", i,
> > ((BYTE*)lock_rect.pBits)[i], dds_cube_map[144+i]);
> > +        IDirect3DTexture9_Release(texture);
>
> You should call IDirect3DTexture9_UnlockRect before
> IDirect3DTexture9_Release.

Good catch ! Thanks !