November 2022 - Wine-gitlab

Re: [PATCH v2 0/1] MR1552: winevulkan: Use direct calls for vkGetDescriptorEXT.
by Georg Lehmann (＠DadSchoorse) 30 Nov '22

30 Nov '22

On Wed Nov 30 10:54:56 2022 +0000, Jacek Caban wrote: > I guess it wouldn't hurt to take this for now, but note that we'd like > to get rid of those direct calls. Rémi is working on improving syscall > dispatcher performance, see !1437 and !1324. Yes, we can remove it when we stop using direct calls for descriptor set updates. But at the moment I really don't want to have worse performance with descriptor buffers compared to descriptor sets caused by wine. Especially since it's unlikely that Rémi's work will be in 8.0. This is not just some theoretical problem. With the current non direct calls, vkd3d-proton's descriptor buffer path regresses performance for radv users. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1552#note_18011

1 0

[PATCH 0/1] MR1604: vbscript: Make redim fail on fixed-size arrays.
by Nikolay Sivov (＠nsivov) 30 Nov '22

30 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53964 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1604

3 4

Re: [PATCH v2 0/1] MR1552: winevulkan: Use direct calls for vkGetDescriptorEXT.
by Jacek Caban (＠jacek) 30 Nov '22

30 Nov '22

I guess it wouldn't hurt to take this for now, but note that we'd like to get rid of those direct calls. Rémi is working on improving syscall dispatcher performance, see !1437 and !1324. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1552#note_18005

1 0

[PATCH v4 0/1] MR1553: msvcrt: Fix errno set on dup from read-only file.
by xantares (＠xantares) 30 Nov '22

30 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53950 -- v4: msvcrt: Fix errno set on dup from read-only file. https://gitlab.winehq.org/wine/wine/-/merge_requests/1553

3 5

[PATCH v2 0/6] MR1454: wined3d patches
by Matteo Bruni (＠Mystral) 30 Nov '22

30 Nov '22

-- v2: wined3d: Don't use separate GL contexts for different swapchains. wined3d: Destroy primary GL context if initialization fails. wined3d: Move backup window / DC handling from the swapchain to the device. wined3d: Get rid of a redundant branch. wined3d: Remove unnecessary index increment in wined3d_context_gl_cleanup_resources(). wined3d: Don't try to access unused buffers in wined3d_context_gl_load_numbered_arrays(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1454

4 8

[PATCH v2 0/2] MR1321: Reject wic invalid formats
by Zhiyi Zhang (＠zhiyi) 30 Nov '22

30 Nov '22

These invalid formats are rejected when creating WIC render targets. Otherwise, Wine may create a WIC render target with an unsupported format and in turn, will make testing IsSupported() method difficult. -- v2: d2d1: Test creating WIC bitmap render targets. d2d1: Reject unsupported formats when creating WIC bitmap render targets. https://gitlab.winehq.org/wine/wine/-/merge_requests/1321

4 5

[PATCH 0/7] MR1598: jscript/mshtml: More misc fixes.
by Gabriel Ivăncescu 30 Nov '22

30 Nov '22

For the image load event patch, wine-gecko always sends them asynchronously, which is the same behavior as IE9+ modes. See `dom/base/nsImageLoadingContent.cpp: nsImageLoadingContent::FireEvent`. The comment there, funnily enough, is what script56.chm's script protects against (and breaks because of async behavior), but there's no way to selectively override it (because of compat mode), so we have to workaround it on mshtml side. Note that we only hook the gecko events (nsevents) being dispatched, and that's obviously on purpose. We wouldn't want to skip a load event dispatched by some script or app's code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1598

2 11

[PATCH v7 0/3] MR1199: xmllite/writer : Implement a few APIs
by David Kahurani (＠kahurani) 30 Nov '22

30 Nov '22

Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v7: xmllite/writer: Implement WriteSurrogateCharEntity. xmllite/writer: Implement WriteRawChars. xmllite/writer: Implement WriteChars. https://gitlab.winehq.org/wine/wine/-/merge_requests/1199

4 5

[PATCH v2 0/6] MR1588: Draft: Add windows.system.profile.systemmanufacturers DLL.
by Mohamad Al-Jaf (＠maljaf) 30 Nov '22

30 Nov '22

The test for ISmbiosInformationStatics_get_SerialNumber is broken on Window 10 testbot VMs, presumably because they don't have a serial number? It results in an HRESULT of E_UNEXPECTED. I added a broken test case for it. I'm assuming that normal installations of Windows return a valid serial number or at least something like "Not Specified" and not NULL. Also, on my Linux OS running cat /sys/class/dmi/id/product_serial returns "To be filled by O.E.M". So I added a fallback to return 0 as the number. Or is it fine to just return whatever string is found? On the Windows 8 VMs, the test crashes at line 75, hr = ISmbiosInformationStatics_get_SerialNumber( smbios_statics, &serial ). Not sure what I should do in this case. I was hoping for a flag that checks if the VM is Windows 8, but there doesn't seem to be one. Should I wrap the test in if (0) or is there an alternative way? Another weird thing is the test fails prematurely on only the 32-bit version of debian11b, saying that the runtimeclass is not registered. I'm assuming it's an issue with the testbot. Debian11 32 bit runs fine. -- v2: windows.system.profile.systemmanufacturers: Implement ISmbiosInformationStatics_get_SerialNumber. wbemprox: Provide accurate SMBIOS serial number. windows.system.profile.systemmanufacturers/tests: Add ISmbiosInformationStatics_get_SerialNumber tests. windows.system.profile.systemmanufacturers: Stub ISmbiosInformationStatics interface. windows.system.profile.systemmanufacturers: Add stub DLL. https://gitlab.winehq.org/wine/wine/-/merge_requests/1588

5 12

[PATCH v2 0/10] MR1609: joy.cpl: Add an xinput tab and draw controller views with GDI.
by Rémi Bernon 30 Nov '22

30 Nov '22

-- v2: joy.cpl: Remove unnecessary JoystickData structure. joy.cpl: Move dinput test tab logic to dinput.c. joy.cpl: Draw dinput axes state with gdi32. joy.cpl: Draw dinput button state with gdi32. joy.cpl: Add a checkbox to test xinput rumble. joy.cpl: Draw xinput controller state with gdi32. joy.cpl: Add a new xinput controller test tab. joy.cpl: Build without NONAMELESSUNION. joy.cpl: Use designated initializers in display_cpl_sheets. joy.cpl: Add DI_ prefix to dinput dialog constants. https://gitlab.winehq.org/wine/wine/-/merge_requests/1609

1 10