November 2022 - Wine-gitlab

[PATCH 0/14] MR38: vkd3d-shader/hlsl: Add field-level documentation to the most important structs in hlsl.h.
by Francisco Casas (＠fcasas) 16 Nov '22

16 Nov '22

I believe this information could be very useful for newcomers to the HLSL compiler. Documentation often needs to reference other parts of the code, so it can be a problem to update these references if the referenced code is modified. However, I think that documentation in the data definitions (as opposed to documentation inside the functions) is easier to maintain, since each data type is declared in a single place, to which one often keeps going back for reference, so it is less probable to forget to update a comment. Also, it opens up the possibility of explaining **what** things are, instead of **how they are used**, in some cases, avoiding these references to other places in the code. I can think on the following additional benefits: * Updates in these documentation comments, when the way a field is used changes, or when new fields are added, can help making future commits more readable. * Some IDEs display the comments above the field/struct declaration when the cursor is over an use of this field/struct. A hopefully not deceiving sketch: ![Hopefully not deceiving sketch.](/uploads/3f9e65a0dc091904e8267e23e58e37be/field_level_doc.png) -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/38

5 45

[PATCH v9 0/2] MR841: ntoskrnl.exe: processor change callback stubs
by Etaash Mathamsetty (＠etaash.mathamsetty) 16 Nov '22

16 Nov '22

required for mrac anti cheat -- v9: ntoskrnl.exe: Add KeDeregisterProcessorChangeCallback stub. ntoskrnl.exe: Add KeRegisterProcessorChangeCallback stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/841

2 2

Re: [PATCH v2 0/3] MR1389: winspool: Use GetJobW in GetJobA implementation - approved
by Alexandre Julliard (＠julliard) 16 Nov '22

16 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1389

1 0

Re: [PATCH v3 0/2] MR1374: Create forward in kernel32 of MapViewOfFileFromApp and CreateFileMappingFromApp to kernelbase - approved
by Alexandre Julliard (＠julliard) 16 Nov '22

16 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1374

1 0

Re: [PATCH v2 0/4] MR1391: vbscript: Implement Format* functions. - approved
by Alexandre Julliard (＠julliard) 16 Nov '22

16 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1391

1 0

Re: [PATCH v2 0/1] MR1390: winevulkan: Generate "in_ext" definition on demand - approved
by Alexandre Julliard (＠julliard) 16 Nov '22

16 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1390

1 0

Re: [PATCH v2 0/1] MR1386: include/d3d11.idl: Add GUIDs for video decoder profiles. - approved
by Alexandre Julliard (＠julliard) 16 Nov '22

16 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1386

1 0

Re: [PATCH v3 0/2] MR1295: Enable compilation with long types in d3dx9_36/tests. - approved
by Alexandre Julliard (＠julliard) 16 Nov '22

16 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1295

1 0

Re: [PATCH v4 0/5] MR1365: msvcrt: add more *printf* implementations - approved
by Alexandre Julliard (＠julliard) 16 Nov '22

16 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1365

1 0

Re: [PATCH v2 0/1] MR1385: vbscript: update parser to allow statements after ELSE without new line - approved
by Alexandre Julliard (＠julliard) 16 Nov '22

16 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1385

1 0