November 2022 - Wine-gitlab

Re: [PATCH v2 0/1] MR1383: inetcomm: Use standard C functions for memory allocation in mimeole.c. - approved
by Alexandre Julliard (＠julliard) 16 Nov '22

16 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1383

1 0

[PATCH 0/1] MR1393: ntoskrnl.exe: Add semi-stub for KeIpiGenericCall.
by Etaash Mathamsetty (＠etaash.mathamsetty) 16 Nov '22

16 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1393

2 1

[PATCH 0/3] MR1389: winspool: Use GetJobW in GetJobA implementation
by Piotr Caban (＠piotr) 16 Nov '22

16 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1389

3 4

[PATCH 0/1] MR1392: ntdll: Add native thread renaming for macOS.
by Brendan Shanks (＠bshanks) 16 Nov '22

16 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1392

2 1

Re: [PATCH v6 0/4] MR1297: gdiplus: Add GdipSetCustomLineCapBaseCap implementation.
by Esme Povirk (＠madewokherd) 16 Nov '22

16 Nov '22

The arrowcap changes should be split into a separate patch. Moving the `widen_open_figure` function makes it hard to read the diff. If you must move it, please do that in a separate patch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1297#note_16060

1 0

[PATCH v2 0/4] MR1373: mshtml: Page-wide events implementation.
by Gabriel Ivăncescu 16 Nov '22

16 Nov '22

This implements some events related to document/window load and unload / visibility changes. The latter is related in that native partially implements it, and only sends it when it is minimized or restored from being minimized, not on navigation or anything else. The main issue for me is the visibilitychange patch. Since we don't control the container hwnd, and it can even be in another process, there is no way to be notified cleanly when it changes its minimization state. We can't subclass it either, as the tests show, it's not subclassed. I implemented it now using an internal timer that polls for that, since it was the least invasive and works in all cases, including other process hwnd. Hooks wouldn't be able to do that, and are also more invasive IMO. I'm hoping for better ideas, though. -- v2: mshtml: Implement pagehide event. mshtml: Implement unload event. mshtml: Implement pageshow event. mshtml: Add visibilitychange event stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/1373

2 9

[PATCH 0/1] MR1382: httpapi: Use standard C functions for memory allocation.
by Alex Henrie (＠alexhenrie) 16 Nov '22

16 Nov '22

The big win here is getting rid of the reimplementation of wcsdup. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1382

4 3

[PATCH 0/5] MR1384: winegstreamer: Fix some quartz transform issues.
by Anton Baskanov (＠baskanov) 16 Nov '22

16 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1384

4 12

[PATCH 0/4] MR1391: vbscript: Implement Format* functions.
by Nikolay Sivov (＠nsivov) 16 Nov '22

16 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1391

4 6

[PATCH 0/1] MR1390: winevulkan: Generate "in_ext" definition on demand
by Alexandros Frantzis (＠afrantzis) 16 Nov '22

16 Nov '22

There are cases in StructConversionFunction.definition where we will generate copy code for extension struct members, without emitting the definition of the "in_ext" variable used in the copy code. This issue is triggered by mismatches in the condition that guards the generation of the "in_ext" definition, and the condition(s) that govern the generation of the member copy code (e.g., in StructConversionFunction.member_needs_copy and VkMember.needs_conversion). In order to avoid such mismatches and the burden of having to keep the conditions in sync, this commit generates the definition on demand, by checking if it's actually needed by the member copy code. Signed-off-by: Alexandros Frantzis <alexandros.frantzis(a)collabora.com> -- Some more details in case a different solution becomes apparent. An example of the aforementioned issue can be triggered if we make VK_EXT_image_drm_format_modifier an UNEXPOSED extension in `make_vulkan`: ``` ../wine/dlls/winevulkan/vulkan_thunks.c: In function ‘convert_VkFormatProperties2_win32_to_host’: ../wine/dlls/winevulkan/vulkan_thunks.c:10214:119: error: ‘in_ext’ undeclared (first use in this function); did you mean ‘index’? 10214 | out_ext->pDrmFormatModifierProperties = convert_VkDrmFormatModifierPropertiesEXT_array_win32_to_host(ctx, in_ext->pDrmFormatModifierProperties, in_ext->drmFormatModifierCount); | ^~~~~~ | index ``` In this particular case the mismatch happens because for the `VkDrmFormatModifierPropertiesListEXT` (returnedonly=true) struct in the INPUT direction the current check doesn't emit `in_ext`: ``` if self.direction == Direction.OUTPUT or not ext.returnedonly: # Not triggered body += ident + "{0} *in_ext = ({0} *)in_header;\n".format(in_type) ``` but `self.member_needs_copy(ext, m)` below for the "pDrmFormatModifierProperties" member returns `True`, requiring `in_ext`. The flow is: ``` * self.member_needs_copy(ext, m) => True if m.name != "sType" and struct.returnedonly and not m.needs_conversion(self.conv, self.unwrap, Direction.INPUT, self.const): # Not triggered return False return True * m.needs_conversion(self.conv, self.unwrap, Direction.INPUT, self.const) => True # if pointer member needs output conversion, it also needs input conversion # to allocate the pointer if direction == Direction.INPUT and self.is_pointer() and \ self.needs_conversion(conv, unwrap, Direction.OUTPUT, struct_const): return True ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1390

3 2