November 2022 - Wine-gitlab

[PATCH v6 0/2] MR1334: xmllite/writer: Handle surrogate pairs
by David Kahurani (＠kahurani) 16 Nov '22

16 Nov '22

Surrogates have to be written in pairs. Also, handle related errors Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v6: xmllite/writer: Handle surrogate pairs https://gitlab.winehq.org/wine/wine/-/merge_requests/1334

2 3

[PATCH v7 0/4] MR741: ntdll: Implement NtFlushProcessWriteBuffers.
by Torge Matthies (＠tmatthies) 16 Nov '22

16 Nov '22

Based on [a patch](https://www.winehq.org/mailman3/hyperkitty/list/wine-devel(a)winehq.… by Jinoh Kang (@iamahuman) from February 2022. I removed the need for the event object and implemented fast paths for Linux. On macOS 10.14+ `thread_get_register_pointer_values` is used on every thread of the process. On Linux 4.14+ `membarrier(MEMBARRIER_CMD_GLOBAL_EXPEDITED, ...)` is used. On x86 Linux <= 4.13 `madvise(..., MADV_DONTNEED)` is used, which sends IPIs to all cores causing them to do a memory barrier. On non-x86 Linux <= 4.2 and on other platforms the fallback path using APCs is used. -- v7: ntdll: Add thread_get_register_pointer_values-based fast path for NtFlushProcessWriteBuffers. ntdll: Add sys_membarrier-based fast path to NtFlushProcessWriteBuffers. ntdll: Add MADV_DONTNEED-based fast path for NtFlushProcessWriteBuffers. ntdll: Implement NtFlushProcessWriteBuffers. https://gitlab.winehq.org/wine/wine/-/merge_requests/741

4 6

[PATCH 0/4] MR1373: mshtml: Page-wide events implementation.
by Gabriel Ivăncescu 16 Nov '22

16 Nov '22

This implements some events related to document/window load and unload / visibility changes. The latter is related in that native partially implements it, and only sends it when it is minimized or restored from being minimized, not on navigation or anything else. The main issue for me is the visibilitychange patch. Since we don't control the container hwnd, and it can even be in another process, there is no way to be notified cleanly when it changes its minimization state. We can't subclass it either, as the tests show, it's not subclassed. I implemented it now using an internal timer that polls for that, since it was the least invasive and works in all cases, including other process hwnd. Hooks wouldn't be able to do that, and are also more invasive IMO. I'm hoping for better ideas, though. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1373

3 7

Re: [PATCH v3 0/5] MR1365: msvcrt: add more *printf* implementations
by Piotr Caban (＠piotr) 16 Nov '22

16 Nov '22

Please don't update MR after it was approved (unless there's a reason to do that, like e.g. you have found a bug, there are conflicts during rebase). It invalidates the review. Since it was a simple rebase the patch still looks good for me. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1365#note_16031

1 0

[PATCH v2 0/2] MR1295: Enable compilation with long types in d3dx9_36/tests.
by eric pouech (＠epo) 16 Nov '22

16 Nov '22

-- v2: dlls/d3dx9_36/tests: Use correct integral type. d3dx9_36/tests: Introduce union to help passing float values in DWORD. https://gitlab.winehq.org/wine/wine/-/merge_requests/1295

3 4

[PATCH v2 0/2] MR1374: Create forward in kernel32 of MapViewOfFileFromApp and CreateFileMappingFromApp to kernelbase
by Santino Mazza (＠tati1454) 16 Nov '22

16 Nov '22

Some programs try to import these functions from kernel32.dll instead of kernelbase.dll -- v2: kernel32: Forward MapViewOfFileFromApp kernel32 to kernelbase. kernel32: Forward CreateFileMappingFromApp kernel32 to kernelbase. https://gitlab.winehq.org/wine/wine/-/merge_requests/1374

2 2

[PATCH v5 0/2] MR1334: xmllite/writer: Handle surrogate pairs
by David Kahurani (＠kahurani) 16 Nov '22

16 Nov '22

Surrogates have to be written in pairs. Also, handle related errors Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v5: xmllite/writer: Handle surrogate pairs xmllite/writer: Pass xmlwriteroutput directly. https://gitlab.winehq.org/wine/wine/-/merge_requests/1334

2 2

[PATCH 0/2] MR1374: Import MapViewOfFileFromApp and CreateFileMappingFromApp into kernel32
by Santino Mazza (＠tati1454) 16 Nov '22

16 Nov '22

Some programs try to import these functions from kernel32.dll instead of kernelbase.dll -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1374

4 7

[PATCH 0/1] MR1388: msv1_0: Drop the ntlm_auth version check.
by Hans Leidekker (＠hans) 16 Nov '22

16 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53932 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1388

2 1

[PATCH 0/1] MR1364: win32u: Correctly report count in GetRawInputBuffer
by Aric Stewart (＠aricstewart) 16 Nov '22

16 Nov '22

If rawinput_from_hardware_message generates an error then the number of packets handled may be less then the size of the buffer. Correctly report only the successfully processed packets to avoid using uninitialized data. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1364

4 5