December 2022 - Wine-gitlab

[PATCH 0/1] MR1791: vbscript: Fix spelling in a FIXME message.
by Robert Wilhelm (＠sloper42) 12 Dec '22

12 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1791

3 2

[PATCH v2 0/1] MR1766: d3dx9_36/tests: Get rid of GCC12 warning.
by eric pouech (＠epo) 12 Dec '22

12 Dec '22

Follow GCC recommendations for getting rid of it. MingW/GCC 12 complains with: /home/eric/work/wine/dlls/d3dx9_36/tests/effect.c: In function 'test_effect_parameter_value': /home/eric/work/wine/dlls/d3dx9_36/tests/effect.c:1838:71: warning: expression does not compute the number of elements in this array; element type is 'DWORD' {aka 'long unsigned int'}, not 'D3DXMATRIX' {aka 'struct _D3DMATRIX'} [-Wsizeof-array-div] 1838 | const D3DXMATRIX *matrix_pointer_array[sizeof(input_value)/sizeof(D3DXMATRIX)]; | ^ /home/eric/work/wine/dlls/d3dx9_36/tests/effect.c:1838:71: note: add parentheses around the second 'sizeof' to silence this warning /home/eric/work/wine/dlls/d3dx9_36/tests/effect.c:1835:19: note: array 'input_value' declared here 1835 | DWORD input_value[EFFECT_PARAMETER_VALUE_ARRAY_SIZE]; | ^~~~~~~~~~~ Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- v2: d3dx9: Get rid of GCC warning. https://gitlab.winehq.org/wine/wine/-/merge_requests/1766

3 3

[PATCH v3 0/2] MR1774: Coverity fixes
by Fabian Maurer (＠DarkShadow44) 12 Dec '22

12 Dec '22

Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- v3: wldap32: Free resource in error case (Coverity) urlmon: Pass correct parameter to realloc (Coverity) https://gitlab.winehq.org/wine/wine/-/merge_requests/1774

3 3

[PATCH 0/1] MR1792: user32/tests: Ignore undocumented Win11 message
by Fabian Maurer (＠DarkShadow44) 12 Dec '22

12 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54000 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1792

2 1

[PATCH 0/3] MR1763: winevulkan: Allow unix side thunks to tail call for performance critical functions.
by Rémi Bernon 12 Dec '22

12 Dec '22

I believe this performs similarly, if not better, than how direct calls previously performed. It is possible to make things even better with tail calls on the PE side, but it is going to be a little bit harder, and I'll make another MR later. FWIW except for vkoverhead benchmark, I still yet to see a real case scenario where it makes a difference, though I think this is straightforward enough. CC @mbriar -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1763

2 15

[PATCH v2 0/2] MR1774: Coverity fixes
by Fabian Maurer (＠DarkShadow44) 12 Dec '22

12 Dec '22

Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- v2: wldap32: Free resource in error case (Coverity) https://gitlab.winehq.org/wine/wine/-/merge_requests/1774

3 5

[PATCH 0/1] MR1766: d3dx9_36/tests: Get rid of GCC12 warning.
by eric pouech (＠epo) 12 Dec '22

12 Dec '22

Follow GCC recommendations for getting rid of it. MingW/GCC 12 complains with: /home/eric/work/wine/dlls/d3dx9_36/tests/effect.c: In function 'test_effect_parameter_value': /home/eric/work/wine/dlls/d3dx9_36/tests/effect.c:1838:71: warning: expression does not compute the number of elements in this array; element type is 'DWORD' {aka 'long unsigned int'}, not 'D3DXMATRIX' {aka 'struct _D3DMATRIX'} [-Wsizeof-array-div] 1838 | const D3DXMATRIX *matrix_pointer_array[sizeof(input_value)/sizeof(D3DXMATRIX)]; | ^ /home/eric/work/wine/dlls/d3dx9_36/tests/effect.c:1838:71: note: add parentheses around the second 'sizeof' to silence this warning /home/eric/work/wine/dlls/d3dx9_36/tests/effect.c:1835:19: note: array 'input_value' declared here 1835 | DWORD input_value[EFFECT_PARAMETER_VALUE_ARRAY_SIZE]; | ^~~~~~~~~~~ Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1766

3 2

[PATCH v5 0/10] MR1074: Draft: ntdll: Improve Valgrind and GDB integration.
by Rémi Bernon 12 Dec '22

12 Dec '22

Valgrind support requires a fork, which I've published to https://gitlab.winehq.org/rbernon/valgrind. The fork implements loading DWARF debug info from PE files, instead of the old and broken upstream PDB support. I've tried to upstream these changes a long time ago but didn't receive any feedback. I think we could maybe consider keeping a fork, which I'm happy to maintain, as the changes aren't too large. We may want to investigate adding 32-on-64 support, which may require a bit more changes (to VEX specifically, because its amd64 guest doesn't support segment register manipulation). The changes here are not all related to Valgrind, and I'll create separate MR for those which may make sense independently from Valgrind / GDB. Also included is a suppression file to silent some annoying false positives, many of which are coming from the cross-stack accesses during syscalls, which are confusing Valgrind's stack heuristics. One can try this out with something like: `WINELOADERNOEXEC=1 valgrind --suppressions=tools/valgrind.supp wine64/loader/wine64 wine64/programs/winecfg/winecfg.exe` -- v5: ntdll: Avoid writing to invalid memory in i386 unix dispatcher. ntdll: Set %rsp before args in x86_64 call_user_mode_callback. ntdll: Fix incorrect i386 call_user_mode_callback CFI. ntdll: Fix valgrind notifications from ntdll.so. ntdll: Import valgrind headers for PE side ntdll. ntdll: Allocate a truly separate stack for the kernel stack. ntdll: Maintain a PE module link map and expose it to GDB. ntdll: Pass a UNICODE_STRING to load_builtin and virtual_map_image. loader: Expose a shadow copy of ld.so link map to GDB. ntdll: Add .cfi_signal_frame to __wine_syscall_dispatcher. https://gitlab.winehq.org/wine/wine/-/merge_requests/1074

1 11

[PATCH v4 0/54] MR1074: Draft: ntdll: Improve Valgrind and GDB integration.
by Rémi Bernon 12 Dec '22

12 Dec '22

Valgrind support requires a fork, which I've published to https://gitlab.winehq.org/rbernon/valgrind. The fork implements loading DWARF debug info from PE files, instead of the old and broken upstream PDB support. I've tried to upstream these changes a long time ago but didn't receive any feedback. I think we could maybe consider keeping a fork, which I'm happy to maintain, as the changes aren't too large. We may want to investigate adding 32-on-64 support, which may require a bit more changes (to VEX specifically, because its amd64 guest doesn't support segment register manipulation). The changes here are not all related to Valgrind, and I'll create separate MR for those which may make sense independently from Valgrind / GDB. Also included is a suppression file to silent some annoying false positives, many of which are coming from the cross-stack accesses during syscalls, which are confusing Valgrind's stack heuristics. One can try this out with something like: `WINELOADERNOEXEC=1 valgrind --suppressions=tools/valgrind.supp wine64/loader/wine64 wine64/programs/winecfg/winecfg.exe` -- v4: ntdll: Avoid writing to invalid memory in i386 unix dispatcher. ntdll: Set %rsp before args in x86_64 call_user_mode_callback. ntdll: Fix incorrect i386 call_user_mode_callback CFI. ntdll: Fix valgrind notifications from ntdll.so. ntdll: Import valgrind headers for PE side ntdll. ntdll: Allocate a truly separate stack for the kernel stack. ntdll: Maintain a PE module link map and expose it to GDB. ntdll: Pass a UNICODE_STRING to load_builtin and virtual_map_image. loader: Expose a shadow copy of ld.so link map to GDB. ntdll: Add .cfi_signal_frame to __wine_syscall_dispatcher. configure: Quiet recheck and Werror. d3dx9_36/tests: Fix an array size warning. ntdll: Initialize unix_pid and unix_tid. rpcrt4: Fix partial allocation warnings. winegstreamer: Use QWORD instead of uint64_t for length. shell32: Avoid undefined behavior with partially allocated structs. user32: Avoid undefined behavior with partially allocated structs. jscript: Use flexible array member to avoid a warning. devenum: Avoid undefined behavior with uninitialized value. webservices: Explicitly cast WS_XML_READER_ENCODING_TYPE enum. msvcp60: Use an explicit type to avoid a warning. krnl386.exe16: Avoid undefined behavior. krnl386.exe16: Avoid passing NULL to lstrcpyA. winedbg: Avoid undefined behavior with printing NULL string. winex11: Avoid undefined behavior with uninitialized value. scrobj: Avoid depending on uninitialized hres value. gdiplus: Initialize ofs. ole32/tests: Avoid fixed pointer usage. ntdll: Avoid use of uninitialized ch. kernelbase: Avoid returning uninitialized HMODULE. comctl32: Always initialize dtFlags. mciseq: Print data only when successfully read. dwrite/tests: Silent a todo_wine identation warning. kernelbase/tests: Initialize input buffer to silent a warning. ntoskrnl.exe: Make USD pointers volatile to silent a warning. user.exe16: Initialize RECT to silent a warning. shlwapi/tests: Initialize input buffer to silent a warning. ddraw: Use designated initializer to avoid implicit enum cast. d3d8: Use designated initializer to avoid implicit enum cast. d3d11: Avoid implicit enum value cast. d2d1: Avoid implicit D2D1_FACTORY_TYPE enum cast. d2d1: Remove unnecessary cast. include: Support running all tests at once with --all. gitlab: Avoid unnecessary winetest re-link on incremental builds. configure.ac: Check for git presence and use $(GIT) variable. configure.ac: Use ; rather than && to chain variable and comparison. Revert "gitlab: Run lengthy tests in a separate job." Revert "gitlab: Run short tests on 32-bit too." WIP: build: Prefer local gitlab runner. gitlab: Run lengthy tests in a separate job. gitlab: Add a job to run some tests as 64-bit. gitlab: Run related tests on every commit. gitlab: Run some tests with nulldrv driver. WIP: build: Add a github actions workflow. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/1074

1 0

[PATCH 0/2] MR1789: mf/tests: Test GetOutputType for WMV decoder.
by Ziqing Hui (＠zhui) 12 Dec '22

12 Dec '22

The 2 patches came for https://gitlab.winehq.org/wine/wine/-/merge_requests/1707 It's code freeze time. So I split the test patches from MR 1707 to make tests upstreamed. They are totally identical to what they look like before. Nothing changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1789

3 3