December 2022 - Wine-gitlab

[PATCH 0/1] MR1779: hhctrl: Handle memory allocation failure in ReadChmSystem (cppcheck).
by Alex Henrie (＠alexhenrie) 12 Dec '22

12 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1779

2 1

[PATCH 0/1] MR1777: dbghelp: Handle memory allocation failure in image_locate_build_id_target (cppcheck).
by Alex Henrie (＠alexhenrie) 12 Dec '22

12 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1777

2 1

[PATCH v3 0/1] MR1771: ntoskrnl.exe: Fake Success for MmMapIoSpace.
by Etaash Mathamsetty (＠etaash.mathamsetty) 12 Dec '22

12 Dec '22

originally created by Guy1524 -- v3: ntoskrnl.exe: Fake Success for MmMapIoSpace. https://gitlab.winehq.org/wine/wine/-/merge_requests/1771

2 2

[PATCH 0/4] MR1775: Fix a few gcc warnings
by Fabian Maurer (＠DarkShadow44) 11 Dec '22

11 Dec '22

Happens on gcc 12.2.0 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1775

2 4

[PATCH 0/2] MR1774: Coverity fixes
by Fabian Maurer (＠DarkShadow44) 11 Dec '22

11 Dec '22

Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1774

2 2

[PATCH 0/1] MR1772: ntdll: Make sure xmm6-xmm15 are always restored in unix call dispatcher
by Torge Matthies (＠tmatthies) 11 Dec '22

11 Dec '22

If after a unix call `frame->restore_flags` was not 0 but did not include either `CONTEXT_FLOATING_POINT` or `CONTEXT_XSTATE`, xmm6-xmm15 were not restored to their previous values. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1772

2 1

[PATCH v2 0/7] MR1752: Draft: RFC: Make syscall functions sysv_abi on x64
by Torge Matthies (＠tmatthies) 11 Dec '22

11 Dec '22

This removes 20 `movaps` instructions from every syscall that calls a sysv_abi function, plus an `and` for stack alignment and some other instructions depending on the function. In `NtAllocateLocallyUniqueId` for example this reduces the number of instructions from 63 to 36. I don't entirely understand the llvm-mca output but here are the before and after stats that it outputs for that function: Before Iterations: 100 Instructions: 6300 Total Cycles: 3335 Total uOps: 6300 Dispatch Width: 6 uOps Per Cycle: 1.89 IPC: 1.89 Block RThroughput: 15.0 After Iterations: 100 Instructions: 3600 Total Cycles: 1514 Total uOps: 3600 Dispatch Width: 6 uOps Per Cycle: 2.38 IPC: 2.38 Block RThroughput: 6.0 This currently depends on the stack being aligned by the syscall dispatcher, which afaict is the case if `sizeof(struct syscall_frame) % 16 == 0`. If that is not good enough I can add an `andq $~15,%rsp` somewhere. One question I have is whether we want to continue supporting CDECL syscalls (only `wine_server_call`, `wine_server_fd_to_handle` and `wine_server_handle_to_fd`)? If we do, this adds a bit of complexity to the syscall dispatcher, see the commit "FIXUP ntdll: Support CDECL syscalls." If we don't, and make those syscalls WINAPI instead, then for every call to those functions on x86 it seems to either change nothing or add one `add` instruction. However we of course lose the ability to make CDECL syscalls. -- v2: Revert "ntdll: Make CDECL syscalls WINAPI instead." FIXUP ntdll: Support CDECL syscalls. ntdll: Make syscall functions sysv_abi on x64. ntdll: Make CDECL syscalls WINAPI instead. win32u: Make syscalls use the SYSCALL calling convention. ntdll: Make syscalls use the SYSCALL calling convention. include: Add SYSCALL calling convention. https://gitlab.winehq.org/wine/wine/-/merge_requests/1752

3 12

[PATCH 0/1] MR1771: ntoskrnl.exe: Fake Success for MmMapIoSpace.
by Etaash Mathamsetty (＠etaash.mathamsetty) 11 Dec '22

11 Dec '22

originally created by Guy1524 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1771

2 1

[PATCH 0/1] MR1769: winecrt0: Avoid predefined BOOL in get_relocbase
by Gerald Pfeifer (＠gerald) 10 Dec '22

10 Dec '22

When .so module initialization was moved from ntdll to winecrt0 with commit bef09697227c29f53bb0ad95232399cbba5c9c6b we lost a number of include files. This broke FreeBSD-specific code that used BOOL, TRUE, and FALSE. Fix that by using poor man's int, 1, and 0 instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1769

2 1

[PATCH 0/767] MR1767: winecrt0: Avoid predefined BOOL in get_relocbase
by Gerald Pfeifer (＠gerald) 10 Dec '22

10 Dec '22

When .so module initialization was moved from ntdll to winecrt0 with commit bef09697227c29f53bb0ad95232399cbba5c9c6b we lost a number of include files. This broke FreeBSD-specific code that used BOOL, TRUE, and FALSE. Fix that by using poor man's int, 1, and 0 instead. -- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/1767

1 2