September 2022 - Wine-gitlab

[PATCH v3 0/1] MR752: Draft: winecrt0: run C++ object destructors in DLL_PROCESS_DETACH.
by Kevin Puetz (＠puetzk) 08 Sep '22

08 Sep '22

Run C++ global/static destructors during DLL_PROCESS_DETACH while other other dllimport functions they may want to call are still viable. While windows imposes many restrictions on what may be done in such destructors (given that the run inside the loader lock), there are lots of legal and useful kernel32 functions like DestroyCriticalSection, DeleteAtom, TlsFree, etc that are both useful and legal. Currently this does not work for builtin modules because all the Win32 structures are discarded well before NtUnmapViewOfSection finally does the dlllose. Even for a winelib .dll.so module, it would be preferable for destructors to execute during process_detach (before wine tears down the MODREF and detaches dependant dlls), rather than be left until after the last NtUnmapViewOfSection (when we finally reach dlclose) Therefore, winegcc now always uses the DllMainCRTStartup entry point unless you specify your own --entry=func. Previously it did this only for PE modules using msvcrt. Making this default consistent matches cl.exe, which also always defaults to _DllMainCRTStartup unless overridden by /entry:foo https://docs.microsoft.com/en-us/cpp/build/reference/entry-entry-point-symb… The ELF version of winecrt0.a now provides a DllMainCRTStartup which, per the Itanium ABI that is in practice what is used by gcc and clang, performs this this destruction by calling __cxa_finalize(&__dso_handle).. This libc function is required to be idempotent, so it's OK that dlclose still calls it again later (there will just be no further work to do). Multiple calls to __cxa_finalize shall not result in calling termination function entries multiple times; the implementation may either remove entries or mark them finished. https://itanium-cxx-abi.github.io/cxx-abi/abi.html#dso-dtor-runtime-api This has two main effects; it moves ELF destructors earlier (before imports are unmapped), and it moves them inside the Nt loader lock. Being earlier was the intended goal, and moving them inside the lock seems fine. Any Win32 API calls in destructors are just being subjected to the same lock hierarchy rules as usual on windows (MSVC also runs destructors from DllMainCrtStartup) https://docs.microsoft.com/en-us/cpp/build/run-time-library-behavior?view=m… And any purely-ELF destructors that happen to also run earlier should never call functions exported from wine (and thus don't care about ntdll's locks). -- v3: winecrt0: run C++ object destructors during module unload. https://gitlab.winehq.org/wine/wine/-/merge_requests/752

3 4

[PATCH 0/1] MR808: d2d1/tests: Mark some more failing tests as todo.
by Alexandre Julliard (＠julliard) 08 Sep '22

08 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/808

3 3

[PATCH 0/1] MR807: urlmon/tests: Fix race condition in abort test.
by Alexandre Julliard (＠julliard) 08 Sep '22

08 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/807

3 2

[PATCH v12 0/1] MR766: advapi32/test: Add tests for RegLoadAppKey.
by Santino Mazza (＠tati1454) 08 Sep '22

08 Sep '22

-- v12: advapi32/tests: Add tests for RegLoadAppKey. https://gitlab.winehq.org/wine/wine/-/merge_requests/766

3 2

[PATCH v11 0/1] MR766: advapi32/test: Add tests for RegLoadAppKey.
by Santino Mazza (＠tati1454) 08 Sep '22

08 Sep '22

-- v11: advapi32/tests: Add tests for RegLoadAppKey. https://gitlab.winehq.org/wine/wine/-/merge_requests/766

3 2

[PATCH 0/1] MR806: dwrite/tests: Add some tests for glyph justification values.
by Nikolay Sivov (＠nsivov) 08 Sep '22

08 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/806

2 1

[PATCH v10 0/1] MR766: advapi32/test: Add tests for RegLoadAppKey.
by Santino Mazza (＠tati1454) 08 Sep '22

08 Sep '22

-- v10: advapi32/tests: Add tests for RegLoadAppKey. https://gitlab.winehq.org/wine/wine/-/merge_requests/766

3 2

[PATCH v9 0/1] MR766: advapi32/test: Add tests for RegLoadAppKey.
by Santino Mazza (＠tati1454) 08 Sep '22

08 Sep '22

-- v9: advapi32/tests: Add tests for RegLoadAppKey. https://gitlab.winehq.org/wine/wine/-/merge_requests/766

3 5

[PATCH 0/1] MR805: dssenh: Use CRT allocation functions.
by Nikolay Sivov (＠nsivov) 08 Sep '22

08 Sep '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/805

2 1

Re: [PATCH v2 0/2] MR804: mf: Assume maintainership of MF transforms. - approved
by Nikolay Sivov (＠nsivov) 08 Sep '22

08 Sep '22

This merge request was approved by Nikolay Sivov. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/804

1 0