September 2022 - Wine-gitlab

[PATCH 0/2] MR804: mf: Assume maintainership of MF transforms.
by Rémi Bernon 08 Sep '22

08 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/804

2 3

[PATCH v2 0/7] MR799: wineoss: Switch to mmdevapi's unixlib.h.
by Davide Beatrici (＠davidebeatrici) 08 Sep '22

08 Sep '22

Follow-up to !600. -- v2: wineoss: Switch to mmdevapi's unixlib.h. wineoss: Adapt "get_position_params" struct to mmdevapi's. wineoss: Adapt "get_frequency_params" struct to mmdevapi's. wineoss: Adapt "create_stream_params" struct to mmdevapi's. wineoss: Adapt "test_connect_params" struct to mmdevapi's. wineoss: Drop "oss_" prefix in unixlib enum, apply it to the functions instead. mmdevapi: Integrate wineoss's additions in unixlib.h. https://gitlab.winehq.org/wine/wine/-/merge_requests/799

3 8

Re: [PATCH v4 0/2] MR787: notepad: Add status bar and goto line dialog
by Nikolay Sivov (＠nsivov) 08 Sep '22

08 Sep '22

Nikolay Sivov (@nsivov) commented about programs/notepad/main.c: > + wchar_t statusTxt[25]; > + int lineIndex; > + DWORD selStart; > + DWORD selEnd; > + > + SendMessageW(Globals.hEdit,EM_GETSEL , (WPARAM)&selStart,(LPARAM)&selEnd); > + if(selStart == selEnd) > + Globals.trackedSel = selStart; > + if(selStart < Globals.trackedSel) > + currentCol = selStart; > + else > + currentCol = selEnd; > + currentLine = SendMessageW(Globals.hEdit,EM_LINEFROMCHAR,currentCol,0); > + lineIndex = SendMessageW(Globals.hEdit,EM_LINEINDEX, currentLine,0); > + > + swprintf(statusTxt,25,L"Ln %ld, Col %ld",currentLine+1,(currentCol+1) - lineIndex); Status bar message text should also be localized. You can find examples of how it's done in other modules - it would be using LoadStringW(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/787#note_7984

1 0

[PATCH 0/3] MR698: d2d1: Implement transform graph.
by Ziqing Hui (＠zhui) 08 Sep '22

08 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/698

3 9

[PATCH 0/7] MR799: wineoss: Switch to mmdevapi's unixlib.h.
by Davide Beatrici (＠davidebeatrici) 07 Sep '22

07 Sep '22

Follow-up to !600. --- The version check logic is removed because redundant. `SNDCTL_SYSINFO` was introduced in OSS 4.0: [oss4white.pdf](/uploads/e85c3196b611560db849cfac9e158bd2/oss4white.pdf) The `ioctl()` call fails with OSS 3.x. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/799

3 9

[PATCH 0/1] MR802: wow64: Don't re-enter cpu_simulate() from exception filter.
by Brendan Shanks (＠bshanks) 07 Sep '22

07 Sep '22

This avoids an eventual stack overflow in exception-heavy applications. Important note: when using the experimental Wow64 support on Linux, this change causes a crash during exception handling when unix_funcs->unwind_builtin_dll is called. The call in dll/ntdll/signal_x86_64.c virtual_unwind() to unix_funcs->unwind_builtin_dll() should be commented out and replaced with 'status = STATUS_UNSUCCESSFUL;'. This is along the same lines as needing to comment out the unix_funcs->init_builtin_dll() call for Wow64. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/802

2 1

Re: [PATCH v2 0/7] MR767: rpcrt4, msvcrt: Add SEH annotations to some functions. - approved
by Alexandre Julliard (＠julliard) 07 Sep '22

07 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/767

1 0

Re: [PATCH v3 0/1] MR774: msvcp140: Add _ExceptionHolder::ReportUnhandledError stub. - approved
by Alexandre Julliard (＠julliard) 07 Sep '22

07 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/774

1 0

Re: [PATCH v2 0/1] MR779: msvcrt: Fix the spelling of a comment. - approved
by Alexandre Julliard (＠julliard) 07 Sep '22

07 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/779

1 0

Re: [PATCH v3 0/2] MR796: include/test.h: Don't use strcasecmp. - approved
by Alexandre Julliard (＠julliard) 07 Sep '22

07 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/796

1 0