October 2023 - Wine-gitlab - list.winehq.org

[PATCH 0/1] MR3599: riched20: Remove unnecessary make_string and heap_string_free functions.
by Alex Henrie (＠alexhenrie) 06 Oct '23

06 Oct '23

It'll be easier to convert this code to use CRT allocation functions if we don't have to worry about the function pointer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3599

3 4

[PATCH v8 0/1] MR3777: gdi32: Add stub for D3DKMTQueryAdapterInfo.
by Etaash Mathamsetty (＠etaash.mathamsetty) 06 Oct '23

06 Oct '23

Rainbow 6 Siege and some other games require this. Type is printed in the FIXME to determine which type the application requires. -- v8: gdi32: Add stub for D3DKMTQueryAdapterInfo. https://gitlab.winehq.org/wine/wine/-/merge_requests/3777

3 2

[PATCH 0/1] MR3939: riched20: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 06 Oct '23

06 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3939

3 2

Re: [PATCH v2 0/1] MR3854: winmm: Avoid use of hardcoded return values.
by Huw Davies (＠huw) 06 Oct '23

06 Oct '23

> Since MCI_UnmapMsgAtoW handles all the cases where MCI_MapMsgAtoW allocates memory. Why not just call MCI_UnmapMsgAtoW to do its thing in all cases? Fine, but it would need to be a separate commit to that of changing the return values of `MCI_MapMsgAtoW()`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3854#note_47829

1 0

[PATCH v2 0/2] MR361: vkd3d-shader/hlsl: Initial support for 'switch' statement.
by Nikolay Sivov (＠nsivov) 06 Oct '23

06 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: vkd3d-shader/hlsl: Initial support for 'switch' statement. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/361

3 13

Re: [PATCH v6 0/3] MR3312: programs/start: Allow Ctrl-C to terminate GUI applications (/exec mode).
by eric pouech (＠epo) 06 Oct '23

06 Oct '23

On Fri Oct 6 06:52:42 2023 +0000, Maarten De Braekeleer wrote: > Hey! > First, thanks for addressing this. The fact that CTRL+C closes cmd was > the reason I created https://bugs.winehq.org/show_bug.cgi?id=55197. > I have some questions about the current cmd behavior: > - `CTRL+C` creates a new line, but does not write a new prompt to stdout. > Typing text will make text appear again on the original line. > Microsoft cmd will create a new prompt, and make new text input appear > after that. > - This is probably a feature request, but I think it would be useful to > close cmd by pressing CTRL+D (EOF). Other repl's, such as python have > this behavior. > If you prefer me to create bugzilla issues for these, let me know. please file a bug report for the missing prompt after ctrl-c in cmd (note: it should be also pointed out that ctrl-c in builtin cmd doesn't stop current command: e.g. try to stop 'dir /s c:\\') I'm afraid that ctrl-d will not be supported as you'd like. this is a unix shell behavior, not windows console one. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3312#note_47820

1 0

[PATCH v20 0/4] MR346: tests/shader-runner: Test DXIL shaders.
by Conor McCarthy (＠cmccarthy) 06 Oct '23

06 Oct '23

This goes on top of MR 345. -- v20: tests/shader-runner: Test shaders with dxcompiler. tests/shader-runner: Replace immediate shader type strings with an enum. tests/shader-runner: Do not exit if a 'require' directive is not met. tests/shader-runner: Handle individual keywords in shader directives. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/346

3 6

[PATCH v38 0/7] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) 06 Oct '23

06 Oct '23

This clears up much of the todo list for mspatcha. GetFilePatchSignature* and NormalizeFileForPatchSignature have now been implemented in these changes. These changes bring better support for things like the Adobe Acrobat installer without the need for things like the winetricks mspatcha.dll native dll override. Still needed is support for interleaved streams in the LZXD decompression logic, however this is a great start to better supporting software installers that use the Windows interface for creating and applying patches to files. This is the beginning of the fixes required for bug 12501: https://bugs.winehq.org/show_bug.cgi?id=12501 -- v38: mspatcha: Handle PE format errors properly https://gitlab.winehq.org/wine/wine/-/merge_requests/3870

3 9

[PATCH 0/5] MR4028: objsel: Various cleanups.
by Zebediah Figura (＠zfigura) 06 Oct '23

06 Oct '23

I originally wrote 1/1 while looking for non-multimedia DLLs that included uuids.h, and then noticed some of the other particularly egregious problems with this DLL. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4028

2 5

Re: [PATCH v37 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) 05 Oct '23

05 Oct '23

On Thu Oct 5 21:46:28 2023 +0000, eric pouech wrote: > actually, if there's a bug in imagehlp.CalcCheckSum, the general way of > handling is to write a test case that demonstrate the bug, and implement > the fix in the offending function It was in fact my own error. I was providing the length in bytes instead of words in my tests by accident. I updated it in https://gitlab.winehq.org/wine/wine/-/merge_requests/3870/diffs?diff_id=709… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_47787

1 0