October 2023 - Wine-gitlab - list.winehq.org

Re: [PATCH v5 0/1] MR385: vkd3d-shader: Fix compiler warning. - approved
by Alexandre Julliard (＠julliard) 05 Oct '23

05 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/385

1 0

Re: [PATCH v37 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Zebediah Figura (＠zfigura) 05 Oct '23

05 Oct '23

On Thu Oct 5 17:32:10 2023 +0000, Aidan Khoury wrote: > 1. Yes, however not easily. With my sample PE (which is what I used to > make the "normalized" buffers), it was not complex enough to emit patch > transformations when I used the mspatchc API. I tried for about a dozen > hours before giving in and using an existing real world buffer, which I > extracted from the adobe installers. > 2. Possible, yet extremely complicated as patch transformations appear > pretty complex. > The source of the buffers is the adobe acrobat x86_64 installer. Does that mean that the test data is copyrighted? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_47745

1 0

Re: [PATCH v37 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Zebediah Figura (＠zfigura) 05 Oct '23

05 Oct '23

On Thu Oct 5 17:33:15 2023 +0000, Aidan Khoury wrote: > So, should I make the effort or no? I'm afraid I can't give any injunctions, only telling what I would do. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_47744

1 0

Re: [PATCH v37 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) 05 Oct '23

05 Oct '23

On Tue Oct 3 16:18:47 2023 +0000, Zebediah Figura wrote: > > Oh! Okay, I will use `RtlImageNtHeader` and then do the bounds checks > afterwards :) > I suppose it's a matter of taste, but personally I don't find this an improvement... So, should I make the effort or no? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_47741

1 0

Re: [PATCH v37 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) 05 Oct '23

05 Oct '23

On Thu Oct 5 17:32:10 2023 +0000, Jeffrey Smith wrote: > The three .h files in your tests are --in effect-- huge data blobs, > which is something that should usually be avoided in source code repositories > as far as is possible. I haven't had a chance to look in detail at how > you are using them, > but here a couple of things you may want to investigate: > 1. Can the tests be accomplished with smaller sample files? > 2. Better yet, can the buffers be --at least partially-- generated > programmatic at test time? (as I did with `setup_pe_with_sections` in > my tests) > BTW, what was your source for those three buffers? 1. Yes, however not easily. With my sample PE (which is what I used to make the "normalized" buffers), it was not complex enough to emit patch transformations when I used the mspatchc API. I tried for about a dozen hours before giving in and using an existing real world buffer, which I extracted from the adobe installers. 2. Possible, yet extremely complicated as patch transformations appear pretty complex. The source of the buffers is the adobe acrobat x86_64 installer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_47740

1 0

[PATCH 0/3] MR4022: wined3d: Expose the image view usage to the Vulkan driver.
by Giovanni Mascellani (＠giomasce) 05 Oct '23

05 Oct '23

Some driver, e.g. MoltenVK, fail in some cases if the image view usage is too broad or unknown. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4022

4 5

[PATCH v8 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) 05 Oct '23

05 Oct '23

Resolves https://bugs.winehq.org/show_bug.cgi?id=9127 . (Some of the named programs in that issue may require additional currently-missing functionality, I didn't check; but if so, that's separate issues.) Tested with - winetest on Windows 7 - winetest on Windows 10 - winetest in Wine, of course - microkiri https://bugs.winehq.org/show_bug.cgi?id=9127#c102 - Wagamama High Spec Trial Edition https://wagahigh.com/download_trial.php#normal (ダウンロード means download) - Ninki Seiyuu no Tsukurikata Trial https://archive.org/details/sayou_trial (WMV files in microkiri and Wagamama don't work, but that's separate issues. Also, they need the LC_ALL=ja_JP env, or they throw various goofy errors.) -- v8: quartz/tests: Add tests for CLSID_CMpegVideoCodec. quartz/tests: Add tests for new CLSID_MPEG1Splitter functionality. winegstreamer: Improve and clean up some debug logs. winegstreamer: Implement a little more of IAMStreamSelect in CLSID_MPEG1Splitter. winegstreamer: Implement CLSID_CMpegVideoCodec. winegstreamer: Add program stream and video output support to CLSID_MPEG1Splitter. winegstreamer: Add WG_MAJOR_TYPE_VIDEO_MPEG1 media type. https://gitlab.winehq.org/wine/wine/-/merge_requests/3938

3 9

[PATCH v6 0/4] MR245: vkd3d-shader/hlsl: Add support for 'break' and 'continue' jumps in loops.
by Nikolay Sivov (＠nsivov) 05 Oct '23

05 Oct '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v6: vkd3d-shader/tpf: Write 'continue' instruction. vkd3d-shader/hlsl: Handle 'continue' statements. vkd3d-shader/hlsl: Allow 'break' instructions in loops. tests: Add some tests for 'break'/'continue' in loops. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/245

4 11

Re: [PATCH v6 0/3] MR3312: programs/start: Allow Ctrl-C to terminate GUI applications (/exec mode).
by Maarten De Braekeleer (＠maarten) 05 Oct '23

05 Oct '23

Hey! First, thanks for addressing this. The fact that CTRL+C closes cmd was the reason I created https://bugs.winehq.org/show_bug.cgi?id=55197. I have some questions about the current cmd behavior: - `CTRL+C` creates a new line, but does not write a new prompt to stdout. Typing text will make text appear again on the original line. Microsoft cmd will create a new prompt, and make new text input appear after that. - This is probably a feature request, but I think it would be useful to close cmd by pressing CTRL+D (EOF). Other repl's, such as python have this behavior. If you prefer me to create bugzilla issues for these, let me know. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3312#note_47736

1 0

[PATCH 0/1] MR4017: d3d10/effect: Add support for shift instructions.
by Nikolay Sivov (＠nsivov) 05 Oct '23

05 Oct '23

This is the last bit I got so far for expressions. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4017

3 6