October 2023 - Wine-gitlab - list.winehq.org

[PATCH 0/1] MR4106: include: Fix debugstr_fourcc printf format to print at most 4 chars.
by Rémi Bernon 16 Oct '23

16 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4106

2 4

[PATCH 0/1] MR4109: jscript: Fix Array.map and Array.reduce when last element doesn't exist.
by Gabriel Ivăncescu 16 Oct '23

16 Oct '23

I've fixed the `beforeunload` case, since it happens during `load_nsuri`. I added tests for both it and `unload`, but unfortunately the new tests are somewhat hackish, as we have to release the View without actually closing it to test this, because closing the view sends those events (this is already tested by existing tests), and we want to test if releasing the doc obj sends those events. As for why we have to release the View, it's because it holds a ref to the doc obj. So I placed the test last now since it doesn't close the view properly. If you think the test is too hackish I can remove it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4109

2 3

[PATCH 0/1] MR4107: wbemprox: Use correct string id.
by eric pouech (＠epo) 16 Oct '23

16 Oct '23

Don't use hard coded string indexes as one of the expected string can be absent, hence decreasing its index; nothing ensures that the strings are placed in the order of the fields in the smbios structure. So use, smbios structures' indexes instead. Wbemprox was also expecting one string too much. Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4107

2 1

[PATCH v2 0/5] MR4092: user32: Actually implement RealGetWindowClass{A/W}.
by Connor McAdams (＠cmcadams) 16 Oct '23

16 Oct '23

-- v2: user32: Pass real argument to NtUserGetClassName in RealGetWindowClass. win32u: Add support for retrieving real window class ID across processes. user32: Set real window class ID for user32 standard controls. https://gitlab.winehq.org/wine/wine/-/merge_requests/4092

5 24

Re: [PATCH v3 0/1] MR3971: gdiplus: Opimize GDI32_GdipDrawPath - approved
by Esme Povirk (＠madewokherd) 16 Oct '23

16 Oct '23

This merge request was approved by Esme Povirk. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3971

1 0

Re: [PATCH v3 0/1] MR3971: gdiplus: Opimize GDI32_GdipDrawPath
by Esme Povirk (＠madewokherd) 16 Oct '23

16 Oct '23

On Sat Oct 14 22:06:36 2023 +0000, Bartosz Kosiorek wrote: > With previous implementation we have 2*4 float multiplication inside > `GdipTransformMatrixPoints` function: > ``` > pts[i].X = x * matrix->matrix[0] + y * matrix->matrix[2] + matrix->matrix[4]; > pts[i].Y = x * matrix->matrix[1] + y * matrix->matrix[3] + matrix->matrix[5]; > ``` > Here is the full source code: > ``` > GpStatus WINGDIPAPI GdipTransformMatrixPoints(GpMatrix *matrix, GpPointF *pts, > INT count) > { > REAL x, y; > INT i; > TRACE("(%s, %p, %d)\n", debugstr_matrix(matrix), pts, count); > if(!matrix || !pts || count <= 0) > return InvalidParameter; > for(i = 0; i < count; i++) > { > x = pts[i].X; > y = pts[i].Y; > pts[i].X = x * matrix->matrix[0] + y * matrix->matrix[2] + matrix->matrix[4]; > pts[i].Y = x * matrix->matrix[1] + y * matrix->matrix[3] + matrix->matrix[5]; > } > return Ok; > } > ``` > As the vector is (0,0) and (1, 1), we could replace invocation of this > function by simple assigment (no need to multiple anything): > ``` > scale_x = graphics->worldtrans.matrix[0] + graphics->worldtrans.matrix[2]; > scale_y = graphics->worldtrans.matrix[1] + graphics->worldtrans.matrix[3]; > ``` > We could also optimize it more and calculate width via `sqrt` only once > (I would like to leave it for next MR). This seems simple enough that I have no problem changing it without performance numbers. Note that we immediately turn around and do the same thing with graphics->gdi_transform (with some indirection through gdip_transform_points and get_graphics_transform that could be eliminated). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3971#note_48812

1 0

[PATCH v7 0/11] MR401: vkd3d-shader/dxil: Read CBV info.
by Conor McCarthy (＠cmccarthy) 16 Oct '23

16 Oct '23

Goes atop MR 403 and 388. The last four commits belong to this MR. -- v7: vkd3d-shader: Clone descriptor scan info from struct vkd3d_shader_desc. vkd3d-shader/dxil: Read CBV descriptors. vkd3d-shader/dxil: Validate the descriptor list metadata nodes. vkd3d-shader/spirv: Align constant buffer sizes to 16 bytes. vkd3d-shader/dxil: Read DXIL compute shader thread group dimensions. vkd3d-shader/dxil: Read DXIL global flags. vkd3d-shader: Define more global flags. vkd3d-shader/dxil: Handle multi-row signature elements. vkd3d-shader/dxil: Handle signature element additional tag/value pairs. vkd3d-shader/dxil: Read the DXIL input and output signatures. vkd3d-shader/dxil: Validate the entry point info. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/401

3 12

[PATCH v3 0/2] MR4054: mshtml: HTMLWindow behavior improvements.
by Gabriel Ivăncescu 16 Oct '23

16 Oct '23

-- v3: mshtml: Return proper errors when navigating with no browser. mshtml: Set outer window to uninitialized page when document obj is released. https://gitlab.winehq.org/wine/wine/-/merge_requests/4054

2 3

[PATCH v5 0/1] MR384: vkd3d: Replace the descriptor object cache with a thread-local implementation.
by Conor McCarthy (＠cmccarthy) 16 Oct '23

16 Oct '23

The PE build uses FlsAlloc(), which for our purposes makes no difference vs TlsAlloc(), and allows the use of a destruction callback. -- v5: vkd3d: Replace the descriptor object cache with a thread-local implementation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/384

3 12

[PATCH 0/1] MR407: Draft: vkd3d-shader/disasm: Initial support for disassembling TX binaries.
by Nikolay Sivov (＠nsivov) 16 Oct '23

16 Oct '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/407

3 5