November 2023 - Wine-gitlab

[PATCH 0/1] MR4002: oleaut32: Fix typelib cache race condition.
by Connor McAdams (＠cmcadams) 08 Nov '23

08 Nov '23

This fixes the following issue: - Thread X holds the typelib cache list CS, and is iterating through the list. - Thread Y calls Release on the typelib interface, reference count hits 0, it's waiting for the cache list CS to remove this typelib. - Thread X finds the typelib in the cache list, returns it, exits the CS. - Thread Y enters now the CS, removes the typelib from the cache list, and proceeds to free all of the resources associated with the typelib. - Thread X tries to use the typelib, use after free. The method used here to prevent incrementing the reference count is borrowed from MR !2752. An alternative could be to decouple the actual typelib data from the `ITypeLib2` interface itself, e.g what gets stored into the typelib cache is just the data for the typelib, which would have its own private reference count locked behind the cache list CS. When the public `ITypeLib2` interface's reference count hits 0, it'd lock the typelib cache list CS, decrement the private reference count, and if the private reference count is 0 remove it from the list. The alternative method would require major restructuring of the code, which is why I'd prefer to use the one in this MR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4002

5 6

[PATCH v3 0/7] MR4339: dmsynth, dmloader: Fix memory leaks.
by Anton Baskanov (＠baskanov) 08 Nov '23

08 Nov '23

-- v3: dmloader: Mark cached objects as loaded. dmsynth: Don't leak modulators. dmsynth: Free the allocated presets manually. https://gitlab.winehq.org/wine/wine/-/merge_requests/4339

3 13

[PATCH v2 0/1] MR333: vkd3d-shader/hlsl: Add refract() function.
by Nikolay Sivov (＠nsivov) 08 Nov '23

08 Nov '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: vkd3d-shader/hlsl: Add refract() function. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/333

3 5

[PATCH 0/7] MR4339: dmsynth, dmloader: Fix memory leaks.
by Anton Baskanov (＠baskanov) 08 Nov '23

08 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4339

2 7

[PATCH 0/1] MR4337: msdasql: IColumnsRowset::GetAvailableColumns return 3 meta columns to allow updating of a row.
by Alistair Leslie-Hughes (＠alesliehughes) 08 Nov '23

08 Nov '23

Native returns 19 rows of all features it supports. However as a start, only these three are required to supported a row. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4337

2 1

[PATCH 0/1] MR4336: wsdapi: Use SecureZeroMemory() to clear magic fields.
by eric pouech (＠epo) 08 Nov '23

08 Nov '23

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4336

2 1

[PATCH 0/1] MR4335: wintrust: Use SecureZeroMemory() to clear magic fields.
by eric pouech (＠epo) 08 Nov '23

08 Nov '23

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4335

2 1

[PATCH 0/1] MR4334: winscard: Use SecureZeroMemory() to clear magic fields.
by eric pouech (＠epo) 08 Nov '23

08 Nov '23

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4334

2 1

Re: [PATCH v2 0/1] MR4233: winmm: Fix pszSound allocation in PlaySound_Alloc().
by Huw Davies (＠huw) 08 Nov '23

08 Nov '23

Huw Davies (@huw) commented about dlls/winmm/playsound.c: > else > { > UNICODE_STRING usBuffer; > - RtlCreateUnicodeStringFromAsciiz(&usBuffer, pszSound); > - wps->pszSound = usBuffer.Buffer; > + if (!RtlCreateUnicodeStringFromAsciiz(&usBuffer, pszSound)) goto oom_error; > + wps->pszSound = wcsdup(usBuffer.Buffer); > + HeapFree(GetProcessHeap(), 0, usBuffer.Buffer); ```suggestion:-0+0 RtlFreeUnicodeString(&usBuffer); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4233#note_51460

1 0

[PATCH v2 0/3] MR3839: kernel32: Add structure size checks to CreateActCtx().
by Dmitry Timoshkov (＠dmitry) 08 Nov '23

08 Nov '23

Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> -- v2: ntdll: Add ACTCTX field limit checks to RtlCreateActivationContext(). kernel32: Add ACTCTX field limit checks to CreateActCtxA(). kernel32/tests: Add some tests for CreateActCtx() with different structure sizes. https://gitlab.winehq.org/wine/wine/-/merge_requests/3839

3 7