December 2023 - Wine-gitlab

[PATCH v2 0/4] MR4587: kernelbase: Implement flag validation in `LoadLibraryEx()` to work like in Win10
by Dāvis Mosāns 05 Dec '23

05 Dec '23

While debugging League of Legends I noticed that `LoadLibraryEx()` is invoked with binary filename (non-text) and non-NULL `hFile`. In Windows such call would return `NULL` with LastError set as `ERROR_INVALID_PARAMETER` but current Wine implementation would try to proceed ahead. I don't know if this is intentional trick to mess up debugging/reversing tools or if we have some memory corruption before that overwrites filename buffer. But then I can't imagine how `hFile` could have gotten corrupted since shouldn't that be simple static value in register... Having this MR causes very noticeable difference in LoL: * without it - process deadlocks * with it - no deadlock Also while looking at this, I tried a lot of different flag combinations on Windows 10 and here I implemented so it works exactly like that. I also implemented test case for non-NULL `hFile` but I didn't bother for other flags since I don't know if we even care about those. -- v2: kernelbase: LoadLibraryEx validate flags like Win10 kernelbase: LoadLibraryEx support LOAD_PACKAGED_LIBRARY kernelbase: LoadLibraryEx enforce valid flag combinations kernelbase: Add test case for LoadLibraryEx() when hFile is non-NULL https://gitlab.winehq.org/wine/wine/-/merge_requests/4587

3 11

[PATCH v2 0/2] MR4605: ntdll: Use public type for SystemSupportedProcessorArchitectures returned data.
by Nikolay Sivov (＠nsivov) 05 Dec '23

05 Dec '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: ntdll: Use public type for SystemSupportedProcessorArchitectures returned data. include: Add missing enum to wdm.h. https://gitlab.winehq.org/wine/wine/-/merge_requests/4605

2 3

[PATCH v11 0/7] MR4449: winegstreamer: WMReader compressed output
by Alfred Agrell (＠Alcaro) 05 Dec '23

05 Dec '23

Along with !4450, this fixes WMV videos in microkiri (https://bugs.winehq.org/show_bug.cgi?id=9127#c102) and Wagamama High Spec Trial Edition (https://wagahigh.com/download_trial.php#normal ; ダウンロード means download). -- v11: wmvcore/tests: Add tests for compressed output. winegstreamer: Implement compressed output support in WMSyncReader. https://gitlab.winehq.org/wine/wine/-/merge_requests/4449

3 9

[PATCH v10 0/1] MR3970: quartz/tests: Improve VMR9 ChangeD3DDevice test
by Alfred Agrell (＠Alcaro) 05 Dec '23

05 Dec '23

- Make it present some frames - Make it check that the frames are from the new device, instead of checking TerminateDevice count; fixes https://bugs.winehq.org/show_bug.cgi?id=55649 - ~~Make it check for and avoid some absurd crash on Windows~~ ~~I tried everything I could think of, but Windows absolutely refuses to present a frame after changing the D3D device, instead choosing to return various absurd errors (segfaults, deadlocks, out of memory, etc). I suspect the VMR9 is haunted.~~ edit: Works on Windows now -- v10: quartz/tests: Improve VMR9 ChangeD3DDevice test. https://gitlab.winehq.org/wine/wine/-/merge_requests/3970

3 3

[PATCH v6 0/3] MR4596: Draft: msvcm80: Add stubs for CrtImplementationDetails::Thow*ModuleLoadException functions
by Vijay Kiran Kamuju (＠infyquest) 05 Dec '23

05 Dec '23

Add stubs for CrtImplementationDetails::Thow*ModuleLoadException functions This will help some applications not crashing. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=34537 Next part will be moving this code to msvcp and to make sure Cin, other related classes are implemented for msvcmxx.dlls -- v6: msvcm80: Add stub for ThrowNestedLoadModuleException function. msvcm80: Add stub for ThrowModuleLoadException(String, Exception) function. msvcm80: Add stub for ThrowModuleLoadException(String) function. https://gitlab.winehq.org/wine/wine/-/merge_requests/4596

3 4

Re: [PATCH v5 0/3] MR4596: Draft: msvcm80: Add stubs for CrtImplementationDetails::Thow*ModuleLoadException functions
by Vijay Kiran Kamuju (＠infyquest) 05 Dec '23

05 Dec '23

On Tue Dec 5 19:35:28 2023 +0000, Piotr Caban wrote: > This generally looks good for me. How about changing > `CrtImplementationDetails_ThrowModuleLoadException_Inner` function name? > I'm not familiar with the function so it's hard to suggest a better name > (maybe `CrtImplementationDetails_ThrowModuleLoadException_inner` or > `CrtImplementationDetails_ThrowModuleLoadException_exc`). In other > functions we're using lowercase suffix if needed. > This MR is marked as draft. Please mark it as ready when appropriate. I will rename to CrtImplementationDetails_ThrowModuleLoadException_inner and What I found that from extensive searching on google and the error messages is that the it trys to rethrow the inner exception as ModuleLoadException. eg: https://forum.unity.com/threads/c-wrapper-for-unity.265398/ -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4596#note_55104

1 0

Re: [PATCH v5 0/3] MR4596: Draft: msvcm80: Add stubs for CrtImplementationDetails::Thow*ModuleLoadException functions
by Piotr Caban (＠piotr) 05 Dec '23

05 Dec '23

This generally looks good for me. How about changing `CrtImplementationDetails_ThrowModuleLoadException_Inner` function name? I'm not familiar with the function so it's hard to suggest a better name (maybe `CrtImplementationDetails_ThrowModuleLoadException_inner` or `CrtImplementationDetails_ThrowModuleLoadException_exc`). In other functions we're using lowercase suffix if needed. This MR is marked as draft. Please mark it as ready when appropriate. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4596#note_55103

1 0

[PATCH 0/2] MR4608: msvcrt: Demangler C++/CLI related improvements
by Piotr Caban (＠piotr) 05 Dec '23

05 Dec '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4608

2 2

[PATCH 0/5] MR4593: winewayland.drv: part 11: Mouselook support
by Alexandros Frantzis (＠afrantzis) 05 Dec '23

05 Dec '23

This MR implements mouselook, which requires support for ClipCursor and relative motion events. The latter we can implement directly without using `SetCursorPos` for which no Wayland protocol exists at the moment. 1. Implement setting the foreground window, as this is required for clipping to work properly (i.e., for the ClipCursor driver callback to be called in the proper process/thread, see commit (2)). We can't unconditionally set the foreground window on keyboard focus, since compositors are eager to give the focus and some windows strongly dislike that (see https://gitlab.winehq.org/wine/wine/-/merge_requests/4102#note_51733) This MR borrows the "managed" window concept from WineX11 to detect windows that we shouldn't allow the compositor to manage, and avoids setting such windows as the foreground on keyboard focus. 2. Implement cursor clipping using the pointer-constraints protocol. 3. Switch to emitting relative motion events using the relative-pointer protocol when the cursor is not visible. --- 4. Finally, a potential fix for an issue I have been seeing where apps may transiently lose the active status (see commit message for more) as a result of the foreground state changes in this MR, which has undesirable side-effects. I have included this here for MR completeness/correctness, but it can be moved to a subsequent MR if preferred. Note: the velocity of relative motion events when scaling is involved is somewhat inconsistent among Wayland compositors. Thanks! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4593

8 33

[PATCH 0/1] MR4607: apisetschema: Add api-ms-win-core-com-l2-1-1
by Fabian Maurer (＠DarkShadow44) 05 Dec '23

05 Dec '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55075 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4607

2 1