February 2023 - Wine-gitlab

Re: [PATCH v4 0/1] MR110: vkd3d-shader: Make documentation for "messages" parameters self contained. - approved
by Alexandre Julliard (＠julliard) 28 Feb '23

28 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/110

1 0

Re: [PATCH v4 0/6] MR102: hlsl: Matrix majority, 2023 edition, part 2/2. - approved
by Alexandre Julliard (＠julliard) 28 Feb '23

28 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/102

1 0

[PATCH v4 0/1] MR2153: win32u: invalidate all cached keys after input
by Henry Goffin (＠AMZN-hgoffin) 28 Feb '23

28 Feb '23

This patch addresses an issue in Second Life and potentially other multi-threaded applications which process WM_KEYDOWN in one thread and then verify that the key is "still down" with GetAsyncKeyState from another thread. Wine uses a per-thread key cache, resulting in inconsistent views of key status. Caches are now invalidated when an input event is injected by the driver or via SendInput. -- v4: win32u: invalidate all cached keys after input https://gitlab.winehq.org/wine/wine/-/merge_requests/2153

2 1

Re: [PATCH v4 0/2] MR1924: ntoskrnl.exe/tests: Add KeInitializeDpc tests.
by Rémi Bernon 28 Feb '23

28 Feb '23

Rémi Bernon (@rbernon) commented about include/ddk/wdm.h: > typedef struct _KDPC { > - CSHORT Type; > - UCHAR Number; > - UCHAR Importance; > - LIST_ENTRY DpcListEntry; > + UCHAR Type; > + UCHAR Importance; > + volatile USHORT Number; > + SINGLE_LIST_ENTRY DpcListEntry; > + KAFFINITY ProcessorHistory; > PKDEFERRED_ROUTINE DeferredRoutine; > PVOID DeferredContext; > PVOID SystemArgument1; > PVOID SystemArgument2; > - PULONG_PTR Lock; > + PVOID DpcData; This doesn't seem to match `wdm.h` from SDK 10.0.19041.0 at least. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1924#note_25794

1 0

[PATCH v2 0/1] MR2153: win32u: invalidate all cached keys after input
by Henry Goffin (＠AMZN-hgoffin) 28 Feb '23

28 Feb '23

This patch addresses an issue in Second Life and potentially other multi-threaded applications which process WM_KEYDOWN in one thread and then verify that the key is "still down" with GetAsyncKeyState from another thread. Wine uses a per-thread key cache, resulting in inconsistent views of key status. Caches are now invalidated when an input event is injected by the driver or via SendInput. -- v2: win32u: invalidate all cached keys after input https://gitlab.winehq.org/wine/wine/-/merge_requests/2153

3 5

[PATCH 0/1] MR2302: gdiplus: Use FILE_SHARE_READ in GdipPrivateAddFontFile().
by w-flo (＠w-flo) 28 Feb '23

28 Feb '23

ZusiDisplay sometimes loads the same font file into two different PrivateFontCollections using two threads, so there is a race condition when the file is opened without the FILE_SHARE_READ sharing mode. The second call to GdipPrivateAddFontFile() might fail if the first one hasn't closed the file handle yet. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2302

3 4

[PATCH v3 0/2] MR2016: winex11: Take advantage of RTL_CONSTANT_STRING.
by Alex Henrie (＠alexhenrie) 28 Feb '23

28 Feb '23

-- v3: winex11: Avoid calling RtlInitUnicodeString on a static constant. winex11: Use RTL_CONSTANT_STRING instead of reimplementing it. https://gitlab.winehq.org/wine/wine/-/merge_requests/2016

2 3

Re: [PATCH v2 0/2] MR2016: winex11: Take advantage of RTL_CONSTANT_STRING.
by Jacek Caban (＠jacek) 28 Feb '23

28 Feb '23

Jacek Caban (@jacek) commented about dlls/winex11.drv/desktop.c: > static void query_desktop_work_area( RECT *rc_work ) > { > static const WCHAR trayW[] = {'S','h','e','l','l','_','T','r','a','y','W','n','d'}; > - UNICODE_STRING str = { sizeof(trayW), sizeof(trayW), (WCHAR *)trayW }; > + UNICODE_STRING str = RTL_CONSTANT_STRING( trayW ); You'd need to null-terminate trayW for this to work. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2016#note_25765

1 0

Re: [PATCH v2 0/1] MR2299: wined3d: Do not switch pixel format on non-private GL contexts.
by Matteo Bruni (＠Mystral) 28 Feb '23

28 Feb '23

On Tue Feb 28 14:37:01 2023 +0000, Henri Verbeet wrote: > It's probably worth pointing out that this has quite some potential for > causing regressions in performance. swapchain_blit_gdi() is not fast, > and ideally we'd work on reducing the number of cases where it's needed. !2217 should avoid most of those cases I think, it probably makes sense to wait for that one to go in first. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2299#note_25759

1 0

[PATCH v4 0/5] MR2296: Always use the user images for the D3D12 swapchain
by Giovanni Mascellani (＠giomasce) 28 Feb '23

28 Feb '23

-- v4: dxgi: Reset the back buffer index to zero on ResizeBuffers(). dxgi/tests: Test that ResizeBuffers() resets the back buffer index to zero. dxgi: Always assume that a D3D12 swapchain always uses user images. dxgi: Immediately error out when creating a D3D12 swapchain on a non-immediate queue. dxgi/tests: Test that D3D12 swapchains can only be created on direct command queues. https://gitlab.winehq.org/wine/wine/-/merge_requests/2296

2 6