February 2023 - Wine-gitlab

[PATCH v5 0/2] MR2282: d3d9: Disable instancing for not-indexed drawing
by Illia Polishchuk (＠illia.a.polishchuk) 28 Feb '23

28 Feb '23

d3d9 does not do instancing for not-indexed draw calls on Windows Original issue in DXVK repo: https://github.com/doitsujin/dxvk/issues/3157 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54570 -- v5: d3d9: Disable instancing for not-indexed drawing d3d9/tests: Add test for not-indexed instancing drawing https://gitlab.winehq.org/wine/wine/-/merge_requests/2282

3 3

[PATCH v8 0/1] MR2283: ntdll: Use IOPowerSources API to fill battery info on macOS
by Marc-Aurel Zent (＠marzent) 28 Feb '23

28 Feb '23

The current implementation based on `IOPMCopyBatteryInfo` does not work (macOS 13.2, M2 Max, returns `kIOReturnUnsupported`) and is not recommended/supported by Apple: > WARNING! IOPMCoyBatteryInfo is unsupported on ALL Intel CPU based systems. For PPC CPU based systems, it remains not recommended. For almost all purposes, developers should use the richer IOPowerSources API (with change notifications) instead of using IOPMCopyBatteryInfo. Keys to decipher IOPMCopyBatteryInfo's return CFArray exist in IOPM.h. -- v8: ntdll: Use IOPowerSources API to fill battery info on macOS https://gitlab.winehq.org/wine/wine/-/merge_requests/2283

2 1

[PATCH v2 0/5] MR2296: Always use the user images for the D3D12 swapchain
by Giovanni Mascellani (＠giomasce) 28 Feb '23

28 Feb '23

-- v2: dxgi: Reset the back buffer index to zero on ResizeBuffers(). dxgi/tests: Test that ResizeBuffers() resets the back buffer index to zero. dxgi: Always assume that a D3D12 swapchain always uses user images. dxgi: Immediately error out when creating a D3D12 swapchain on a non-immediate queue. dxgi/tests: Test that D3D12 swapchains can only be created on direct command queues. https://gitlab.winehq.org/wine/wine/-/merge_requests/2296

4 9

Re: [PATCH v2 0/1] MR2299: wined3d: Do not switch pixel format on non-private GL contexts.
by Henri Verbeet (＠hverbeet) 28 Feb '23

28 Feb '23

It's probably worth pointing out that this has quite some potential for causing regressions in performance. swapchain_blit_gdi() is not fast, and ideally we'd work on reducing the number of cases where it's needed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2299#note_25724

1 0

[PATCH 0/1] MR2301: maintainers: Add myself to the Audio I/O section.
by Huw Davies (＠huw) 28 Feb '23

28 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2301

2 1

[PATCH v4 0/1] MR1377: dsound: Use CRT functions for memory allocation.
by Alex Henrie (＠alexhenrie) 28 Feb '23

28 Feb '23

The big win here is getting rid of the reimplementation of wcsdup. -- v4: dsound: Use CRT functions for memory allocation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1377

3 2

Re: [PATCH v2 0/1] MR2299: wined3d: Do not switch pixel format on non-private GL contexts.
by Matteo Bruni (＠Mystral) 28 Feb '23

28 Feb '23

I left a small comment but, regardless, I think it's a step in the right direction (!2217 is another one). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2299#note_25714

1 0

Re: [PATCH v2 0/1] MR2299: wined3d: Do not switch pixel format on non-private GL contexts.
by Matteo Bruni (＠Mystral) 28 Feb '23

28 Feb '23

Matteo Bruni (@Mystral) commented about dlls/wined3d/context_gl.c: > current = gl_info->gl_ops.wgl.p_wglGetPixelFormat(dc); > if (current == format) goto success; > > + if (current && !private) > + return FALSE; I guess we could add a WARN("Using pixel format %u already set on DC %p.\n", current, dc); or something. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2299#note_25713

1 0

[PATCH v4 0/4] MR94: Fix other synchronization problems
by Giovanni Mascellani (＠giomasce) 28 Feb '23

28 Feb '23

-- v4: vkd3d: Do not keep the CS queue locked while processing it. vkd3d: Always enqueue CS operations, even if they can be executed right away. vkd3d: Hold the queue mutex when adding the queue to a blocked list. vkd3d: Mention the correct mutex in a comment. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/94

4 13

[PATCH 0/1] MR2257: mmdevapi/tests: WoW64 processes can read the properties from the registry.
by Francois Gouget (＠fgouget) 28 Feb '23

28 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2257

3 2