February 2023 - Wine-gitlab

[PATCH v2 0/11] MR103: DXBC handling API
by Henri Verbeet (＠hverbeet) 23 Feb '23

23 Feb '23

Public API for parsing and serialising DXBC blobs. -- v2: vkd3d-shader/dxbc: Introduce API for serialising DXBC blobs. vkd3d-shader/dxbc: Introduce API for parsing DXBC blobs. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/103

4 26

[PATCH 0/4] MR2267: msvcr80: Fix _(w)dupenv_s behavior with missing environment variable.
by Rémi Bernon 23 Feb '23

23 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2267

1 4

[PATCH v2 0/1] MR2263: evr: Fix crash when clear input type for the mixer
by Tingzhong Luo (＠tzluo) 23 Feb '23

23 Feb '23

In the implementation of [`evr_disconnect()`](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/evr.c#L325-333), it will try to clear types of mixer by pass null to `IMFTransform_SetInputType()`: ```c static void evr_disconnect(struct strmbase_renderer *iface) { struct evr *filter = impl_from_strmbase_renderer(iface); if (filter->mixer) IMFTransform_SetInputType(filter->mixer, 0, NULL, 0); evr_set_input_type(filter, NULL); evr_release_services(filter); } ``` This null ptr (`media_type`) will be pass to [`video_mixer_collect_output_types()`](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/mixer.c#L869) and cause a [crash](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/mixer.c…: ```c static HRESULT WINAPI video_mixer_transform_SetInputType(IMFTransform *iface, DWORD id, IMFMediaType *media_type, DWORD flags) { ... if (!mixer->device_manager) hr = MF_E_NOT_INITIALIZED; else { if (SUCCEEDED(hr = video_mixer_get_processor_service(mixer, &service))) { if (SUCCEEDED(hr = video_mixer_init_dxva_videodesc(media_type, &video_desc))) ... ``` In this patch, `video_mixer_transform_SetInputType()` will only clear types when got a NULL `media_type` and return `S_OK`. -- v2: evr: Fix crash when clear input type for the mixer https://gitlab.winehq.org/wine/wine/-/merge_requests/2263

3 3

[PATCH v2 0/5] MR2258: winegstreamer: Support WMV DMO decoder.
by Ziqing Hui (＠zhui) 23 Feb '23

23 Feb '23

-- v2: winegstreamer: Implement ProcessInput and ProcessOutput for WMV decoder DMO. winegstreamer: Create wg_transform for WMV decoder. winegstreamer: Better handle framerate. winegstreamer: Add format field to wmv wg_format. winegstreamer: Implement wg_transform data read/write for DMO. https://gitlab.winehq.org/wine/wine/-/merge_requests/2258

3 9

[PATCH 0/1] MR2262: winspool: Check dmSize in IsValidDevmodeW
by Tingzhong Luo (＠tzluo) 23 Feb '23

23 Feb '23

When dmSize is zero or greter than size of input buffer, `IsValidDevmodeW()` failed in Windows 10. But current implementation in wine, it will return `true` because there is no check to `dm.dmSize`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2262

3 2

[PATCH 0/1] MR2265: include: Allow overriding LANGID in module VERSIONINFO.
by Rémi Bernon 23 Feb '23

23 Feb '23

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/2221, this is required by `ImmInstallIME` and .ime modules. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2265

1 1

[PATCH 0/1] MR2264: ntdll: Avoid shrinking large heap block to small block.
by Rémi Bernon 23 Feb '23

23 Feb '23

Even though this is a waste of memory it seems to trip on some UAF with some games. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54475 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2264

1 1

[PATCH v4 0/5] MR2010: wined3d: More Vulkan feature checks.
by Zebediah Figura (＠zfigura) 23 Feb '23

23 Feb '23

-- v4: wined3d: Disable 64-bit integer support. wined3d: Require shader cull distance support to create a feature level 10.0 device. wined3d: Require shader clip distance support to create a feature level 10.0 device. wined3d: Require gather offset support to create a feature level 11.0 device. wined3d: Require fragment shader image stores and atomics to create a feature level 11.0 device. https://gitlab.winehq.org/wine/wine/-/merge_requests/2010

3 6

[PATCH 0/1] MR2263: evr: Fix crash when clear input type for the mixer
by Tingzhong Luo (＠tzluo) 23 Feb '23

23 Feb '23

In the implementation of [`evr_disconnect()`](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/evr.c#L325-333), it will try to clear types of mixer by pass null to `IMFTransform_SetInputType()`: ```c static void evr_disconnect(struct strmbase_renderer *iface) { struct evr *filter = impl_from_strmbase_renderer(iface); if (filter->mixer) IMFTransform_SetInputType(filter->mixer, 0, NULL, 0); evr_set_input_type(filter, NULL); evr_release_services(filter); } ``` This null ptr (`media_type`) will be pass to [`video_mixer_collect_output_types()`](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/mixer.c#L869) and cause a [crash](https://gitlab.winehq.org/wine/wine/-/blob/wine-8.2/dlls/evr/mixer.c…: ```c static HRESULT WINAPI video_mixer_transform_SetInputType(IMFTransform *iface, DWORD id, IMFMediaType *media_type, DWORD flags) { ... if (!mixer->device_manager) hr = MF_E_NOT_INITIALIZED; else { if (SUCCEEDED(hr = video_mixer_get_processor_service(mixer, &service))) { if (SUCCEEDED(hr = video_mixer_init_dxva_videodesc(media_type, &video_desc))) ... ``` In this patch, `video_mixer_transform_SetInputType()` will only clear types when got a NULL `media_type` and return `S_OK`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2263

3 3

[PATCH v9 0/7] MR1714: cryptowinrt: Implement IKeyCredentialManagerStatics::IsSupportedAsync().
by Mohamad Al-Jaf (＠maljaf) 23 Feb '23

23 Feb '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53176 1) The async test is broken on Windows 10 1507. This appears to be a trend among WinRT dlls. I'm thinking that we can add macro definitions for each testbot VM to avoid having to skip tests that would otherwise be working fine, and just greater control over tests in general. 2) The provider file that contains `interface IWineAsyncInfoImpl` is likely going to be reused again in the future. Perhaps a new file can be added in the include/wine folder to prevent duplicate code? I can do this in a separate merge request and cleanup the existing provider files. 3) All the check_bool_async tests return a random async_id so I skipped them. Testbot example: https://testbot.winehq.org/JobDetails.pl?Key=127232&f208=exe32.report#k208 -- v9: cryptowinrt/tests: Add IKeyCredentialManagerStatics::IsSupportedAsync() tests. cryptowinrt: Implement IKeyCredentialManagerStatics::IsSupportedAsync(). cryptowinrt: Import IAsyncOperation from windows.gaming.input. cryptowinrt: Stub IKeyCredentialManagerStatics interface. cryptowinrt: Add private.h file. cryptowinrt/tests: Add ICryptographicBufferStatics interface test. include: Add windows.security.credentials.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/1714

2 8