February 2023 - Wine-gitlab

Re: [PATCH v6 0/3] MR101: vkd3d-shader/hlsl: Improvements to builtin typenames handling. - approved
by Zebediah Figura (＠zfigura) 22 Feb '23

22 Feb '23

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/101

1 0

[PATCH 0/6] MR102: hlsl: Matrix majority, 2023 edition, part 2/2.
by Zebediah Figura (＠zfigura) 22 Feb '23

22 Feb '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/102

3 9

[PATCH 0/3] MR95: Add missing public headers to Doxygen documentation.
by Giovanni Mascellani (＠giomasce) 22 Feb '23

22 Feb '23

The Doxygen docs still need quite a lot of love, but at least the generated document lists the available functions! -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/95

4 5

[PATCH v4 0/8] MR2098: mshtml: Implement synchronous XMLHttpRequests.
by Gabriel Ivăncescu 22 Feb '23

22 Feb '23

wine-gecko does actually support synchronous XMLHttpRequests, even if they are deprecated, but unfortunately it is very broken compared to IE or all the other major browsers (more details [here](https://bugzilla.mozilla.org/show_bug.cgi?id=697151)) Thankfully, it still provides us with the event message loop, which is enough to fix it on mshtml side and act like IE. For sync XHRs, send() is supposed to block all script code, except for notifications sent to the sync XHR. This is because when send() blocks, no other piece of code in the script should execute other than the sync XHR handlers. Unfortunately, that's not the case in Gecko's broken implementation, which can execute handlers as if they were APCs while it's "blocked" in send(). Note that it doesn't actually block, though, because we still process the message loop (non-event related tasks such as navigation, paints, and other stuff), and that's normal. Gecko doesn't block everything related to script events, only some things on the document and timers, but that's far from enough and not even enough for our purposes since we use our own timer tasks. And not even message events are blocked, even though we *also* use our own message event dispatchers (but it doesn't block Gecko ones either). So what we have to do is we need to track all the timers and events dispatched that result in script handlers being executed, while "blocking" inside of a sync XHR send(), and queue them up to defer them to be dispatched later, after send() unblocks. But this is easier said that done. There are many corner cases to consider here, for example: * Events dispatched *synchronously* from within a sync XHR handler or other piece of code called from it. * Nested sync XHR send() calls (called during handler of another sync XHR). * Async XHRs having their events dispatched during a blocking sync XHR send() are complicated. `readyStateChange` for example needs to have the async XHR's readyState at the time it was sent, **not** at the time it was actually dispatched, since we're going to delay it and dispatch it later. It's similar with other XHR states, such as responseText (which can be partial). * Aborts of async XHRs during such handlers. These patches hopefully should address all the issues and, on a high level, work like this: * Track the `readyState` and `responseText` length manually, so we can override / force them to specific values. * "Snapshot" the async XHR at the time we encounter an event for it, and queue this event with such information. When later dispatching this event (after being deferred), we temporarily set the state of the async XHR to the snapshot. * To deal with nested event dispatches, keep track of a "dispatch depth" (everytime we dispatch an event we increase the depth, and when it returns we decrease it). * For sync XHRs, we note the depth when send() is called, and defer events at that depth, since they're dispatched during the "blocked" message loop and need to be delayed (except for sync XHR events, which is a special case since it must be dispatched synchronously). When it returns, we restore the previous blocking depth. -- v4: mshtml: Send all readystatechange events for synchronous XHRs in IE9 mshtml: Implement synchronous XMLHttpRequest. mshtml: Add separate task list for tasks dispatching events. mshtml: Track readyState in XHRs and report it manually. mshtml: Register all event handlers when creating the XMLHttpRequest. mshtml: Pass optional args to XMLHttpRequest.open() correctly. mshtml: Free the task after the destructor. mshtml: Use proper types for readystate_locked and readystate_pending. https://gitlab.winehq.org/wine/wine/-/merge_requests/2098

3 19

[PATCH v2 0/1] MR2254: vbscript/tests: Fix the testChrError() tests.
by Francois Gouget (＠fgouget) 22 Feb '23

22 Feb '23

v2: Fixed a typo in the commit message. -- v2: vbscript/tests: Fix the testChrError() tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/2254

3 4

[PATCH 0/1] MR104: vkd3d-shader: Avoid underflowing the indentation level.
by Zebediah Figura (＠zfigura) 22 Feb '23

22 Feb '23

Any shader that would underflow is invalid, but it is helpful to allow tracing even invalid shaders. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/104

4 3

[PATCH v13 0/11] MR66: vkd3d-shader/hlsl: Broaden resources support v2 (PART 1).
by Francisco Casas (＠fcasas) 22 Feb '23

22 Feb '23

First part of v2 of !27, which aims to: * Allow allocation of variables of complex types that contain both numerics and objects across multiple register sets (regsets). * Support the tex2D and tex3D intrinsics, inferring generic samplers dimension from usage, writing sampler declarations, and writing sample instructions. * Support for arrays of resources for both SM1 and SM4 (not to be confused with the resource-arrays of SM 5.1, which can have non-constant indexes). * Support for resources declared within structs. * Support for synthetic combined samplers for SM1 and synthetic separated samplers for SM4, considering that they can be arrays or members of structs. * Imitate the way the native compiler assigns the register indexes of the resources on allocation, which proved to be the most difficult thing. * Support for object components within complex input parameters. * Small fixes to corner cases. This part consists on parsing the `tex2D()` and `tex3D()` intrinsics and beginning to support the allocation of variables across multiple regsets. The whole series, is on my [master6](https://gitlab.winehq.org/fcasas/vkd3d/-/commits/master6) branch. -- v13: vkd3d-shader/hlsl: Allocate register reservations in a separate pass. vkd3d-shader/hlsl: Respect object reservations even if the object is unused. tests: Test allocation of unused objects. vkd3d-shader/hlsl: Allocate objects according to register set. vkd3d-shader/hlsl: Keep an hlsl_reg for each register set in hlsl_ir_var. vkd3d-shader/hlsl: Obtain extern resources as a separate array in SM4. vkd3d-shader/hlsl: Store the type's register size for each register set. vkd3d-shader/hlsl: Leave offset empty for array and struct derefs. vkd3d-shader/hlsl: Parse the tex3D() intrinsic. vkd3d-shader/hlsl: Parse the tex2D() intrinsic. vkd3d-shader/hlsl: Avoid segfault on missing sampler. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/66

4 12

[PATCH v17 0/2] MR2105: ddraw: Add local buffer in d3d_device7_DrawPrimitive()
by Steve Schnepp (＠steveschnepp) 22 Feb '23

22 Feb '23

Convert all consecutive calls to d7_DrawPrimitive(TRIANGLE_FAN) into a single call to d7_DrawPrimitive(TRIANGLE_LIST) with all the vertices. Note, it *increase* the number of vertices, but bandwith is much less costly than multiple calls. Note, only a very precise subset of the calls get buffered in order to ensure that the disruption is minimal. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=33814 -- v17: ddraw: Also Buffer D3DPT_POINTLIST ddraw: Add a local buffer in d3d_device7_DrawPrimitive() https://gitlab.winehq.org/wine/wine/-/merge_requests/2105

3 26

Re: [PATCH v6 0/3] MR101: vkd3d-shader/hlsl: Improvements to builtin typenames handling.
by Nikolay Sivov (＠nsivov) 22 Feb '23

22 Feb '23

On Wed Feb 22 12:53:30 2023 +0000, Giovanni Mascellani wrote: > Right now tests for eb02f7fd1f8e92f91fc7a9ddacc70865269086c9 fail both > on native and on vkd3d. Thanks, fixed now. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/101#note_25144

1 0

[PATCH v5 0/3] MR101: vkd3d-shader/hlsl: Improvements to builtin typenames handling.
by Nikolay Sivov (＠nsivov) 22 Feb '23

22 Feb '23

-- v5: vkd3d-shader/hlsl: Support case-insensitive lookup for builtin 'float' type. vkd3d-shader/hlsl: Use unsigned type for the 'dword' alias. vkd3d-shader/hlsl: Support case-insensitive lookup for builtin 'dword' type. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/101

4 6