March 2023 - Wine-gitlab - list.winehq.org

Re: [PATCH v10 0/2] MR2282: d3d9: Disable instancing for not-indexed drawing - approved
by Alexandre Julliard (＠julliard) 02 Mar '23

02 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2282

1 0

Re: [PATCH v3 0/2] MR2302: gdiplus: Use FILE_SHARE_READ in GdipPrivateAddFontFile(). - approved
by Alexandre Julliard (＠julliard) 02 Mar '23

02 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2302

1 0

Re: [PATCH v10 0/1] MR2153: win32u: Invalidate all cached keys after input. - approved
by Alexandre Julliard (＠julliard) 02 Mar '23

02 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2153

1 0

[PATCH v2 0/9] MR106: vkd3d-shader/hlsl: packoffset() support.
by Francisco Casas (＠fcasas) 02 Mar '23

02 Mar '23

Support manually packing constant buffer elements through the `packoffset(·)` syntax. Support not included yet for simultaneously having semantics, `register(·)`, and `packoffset(·)`, for abnormalities such as: ```hlsl Texture2D tex; cbuffer buff { float4 a : packoffset(c0); sampler sam : packoffset(c0) : register(s1) : SEMANTIC; } float4 main() : sv_target { return tex.Sample(sam, float2(0, 0)) + a; } ``` but this motivated the addition of the `hlsl_ir_var.offset_reservation` field instead of reusing `hlsl_ir_var.reg_reservation`. -- v2: vkd3d-shader/hlsl: Consider register() as manual packing for resource fields. tests: Test packoffset() with resources inside cbuffers. vkd3d-shader/hlsl: Ignore packoffset() contents for SM1. vkd3d-shader/hlsl: Don't allow manual and automatic cbuffer offset packing. vkd3d-shader/hlsl: Detect overlaps in cbuffer offsets. vkd3d-shader/hlsl: Support packoffset(). vkd3d-shader/hlsl: Parse packoffset(). tests: Test packoffset(). tests: Test cbuffer element offsets. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/106

4 36

[PATCH v5 0/2] MR1746: setupapi: Use MultiByteToUnicode and UnicodeToMultiByte instead of reimplementing them.
by Alex Henrie (＠alexhenrie) 02 Mar '23

02 Mar '23

-- v5: setupapi: Use MultiByteToUnicode and UnicodeToMultiByte instead of reimplementing them. setupapi: Handle NULL in string allocation functions and add tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1746

2 2

[PATCH 0/5] MR2309: ddraw: SetSurfaceDesc() refactoring, part 1.
by Zebediah Figura (＠zfigura) 02 Mar '23

02 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2309

4 7

[PATCH 0/5] MR2310: wined3d: move stubs out of state tables
by Max Figura (＠maxfigura) 02 Mar '23

02 Mar '23

Removing WINED3D_RS entries from state tables and moving stubs to wined3d_device_apply_stateblock. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2310

4 7

[PATCH 0/1] MR2260: wined3d: Initialise GLSL outputs to avoid nVidia warning
by David Gow (＠sulix) 02 Mar '23

02 Mar '23

nVidia's GLSL compiler spits out a warning if a value is potentially used without being initialized. This affects many of wined3d's GLSL shaders, as either some element of the (e.g.) vs_out array are not initialized, or individual vector components remain unwritten to. As a quick way of working around this, initialize all vs_out, gs_out, and temporary Rn registers to vec4(0,0,0,0). This gets rid of all of the warnings in the cases I tried. (A more complete solution would probably track if we're initialising these, and only add what is required. Or would just disable the warning somehow.) Some example warnings (from a shader in the 'Pharaoh: A New Era' demo): ``` 0264:fixme:d3d_shader:print_glsl_info_log Info log received from GLSL shader #3: 0264:fixme:d3d_shader:print_glsl_info_log Vertex info 0264:fixme:d3d_shader:print_glsl_info_log ----------- 0264:fixme:d3d_shader:print_glsl_info_log 0(28) : warning C7050: "vs_out[2].zw" might be used before being initialized 0264:fixme:d3d_shader:print_glsl_info_log 0(28) : warning C7050: "vs_out[5].w" might be used before being initialized 0264:fixme:d3d_shader:print_glsl_info_log 0(28) : warning C7050: "vs_out[7]" might be used before being initialized 0264:fixme:d3d_shader:print_glsl_info_log 0(28) : warning C7050: "vs_out[8]" might be used before being initialized 0264:fixme:d3d_shader:print_glsl_info_log 0(28) : warning C7050: "vs_out[9]" might be used before being initialized 0264:fixme:d3d_shader:print_glsl_info_log 0(28) : warning C7050: "vs_out[10]" might be used before being initialized 0264:fixme:d3d_shader:print_glsl_info_log 0(28) : warning C7050: "vs_out[11]" might be used before being initialized 0264:fixme:d3d_shader:print_glsl_info_log 0(28) : warning C7050: "vs_out[12]" might be used before being initialized 0264:fixme:d3d_shader:print_glsl_info_log 0(28) : warning C7050: "vs_out[13]" might be used before being initialized 0264:fixme:d3d_shader:print_glsl_info_log 0(28) : warning C7050: "vs_out[14]" might be used before being initialized 0264:fixme:d3d_shader:print_glsl_info_log 0(28) : warning C7050: "vs_out[15]" might be used before being initialized ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2260

5 10

[PATCH v9 0/2] MR2282: d3d9: Disable instancing for not-indexed drawing
by Illia Polishchuk (＠illia.a.polishchuk) 02 Mar '23

02 Mar '23

d3d9 does not do instancing for not-indexed draw calls on Windows Original issue in DXVK repo: https://github.com/doitsujin/dxvk/issues/3157 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54570 -- v9: d3d9: Always draw only a single instance for non-indexed draws. d3d9/tests: Add test for non-indexed instancing drawing. https://gitlab.winehq.org/wine/wine/-/merge_requests/2282

3 4

Re: [PATCH v2 0/1] MR2299: wined3d: Do not switch pixel format on non-private GL contexts.
by Henri Verbeet (＠hverbeet) 02 Mar '23

02 Mar '23

> Otherwise, it can be technically made to work like for GL child window redering (keeping composite redirected drawables for different pixel formats) but that requires essentially the same blitting on each present as done with wined3d backup context. It wouldn't need to go through CPU memory though. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2299#note_26016

1 0