April 2023 - Wine-gitlab - list.winehq.org

[PATCH 0/1] MR2622: ntdll: Use log-linear bucketing for free lists.
by Tatsuyuki Ishi (＠ishitatsuyuki) 10 Apr '23

10 Apr '23

Currently, the free list consists of a "small list" for sizes below 256, which are linearly spaced, and a "large list" which is manually split into a few chunks. This patch replaces it with a single log-linear policy, while expanding the range the large list covers. The old implementation had issues when a lot of large allocations happened. In this case, all the allocations went in the last catch-all bucket in the "large list", and what happens is: 1. The linked list grew in size over time, causing searching cost to skyrocket. 2. With the first-fit allocation policy, fragmentation was also making the problem worse. The new bucketing covers the entire range up until we start allocating large blocks, which will not enter the free list. It also makes the allocation policy closer to best-fit (although not exactly), reducing fragmentation. The increase in number of free lists does incur some cost when it needs to be skipped over, but the improvement in allocation performance outweighs it. For future work, these ideas (mostly from glibc) might or might not benefit performance: - Use an exact best-fit allocation policy. - Add a bitmap for freelist, allowing empty lists to be skipped with a single bit scan. Signed-off-by: Tatsuyuki Ishi <ishitatsuyuki(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2622

3 3

[PATCH 0/1] MR2611: iphlpapi: Fix the GAA_FLAG_INCLUDE_GATEWAYS constant name.
by Francois Gouget (＠fgouget) 10 Apr '23

10 Apr '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2611

4 3

[PATCH v5 0/2] MR131: vkd3d: Persistently map host-visible heaps on creation.
by Zebediah Figura (＠zfigura) 10 Apr '23

10 Apr '23

-- v5: tests: Add a test for readback map stability. vkd3d: Persistently map host-visible heaps on creation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/131

4 3

[PATCH v4 0/4] MR2603: winecoreaudio: Move timer logic to unixlib, matching other drivers.
by Davide Beatrici (＠davidebeatrici) 10 Apr '23

10 Apr '23

-- v4: winecoreaudio: Implement and call timer_loop in unixlib. winecoreaudio: Implement and call set_event_handle in unixlib. winecoreaudio: Store flags in unixlib. winecoreaudio: Retain precision when storing period in unixlib. https://gitlab.winehq.org/wine/wine/-/merge_requests/2603

3 5

[PATCH v3 0/1] MR2032: winex11: Allow replacing either context in wglShareLists.
by Alex Henrie (＠alexhenrie) 10 Apr '23

10 Apr '23

The deleted test is a bad test: The behavior is different on different drivers, for example, the test fails on the Windows 10 and 11 testbot machines that have AMD video cards. Furthermore, MSDN does not say that the destination context "must not" have any display lists yet but rather that it "should not" have any.[1] The Khronos OpenGL Wiki similarly advises against calling wglShareLists after the source or destination context has at least one object, but if you do, it only says that "there is a chance that wglShareLists will fail", not that it will necessarily fail.[2] Since there's no clear "right" behavior here, we can adopt the more permissive behavior that some programs expect, as long as it doesn't corrupt the context. [1] https://learn.microsoft.com/en-us/windows/win32/api/wingdi/nf-wingdi-wglsha… [2] https://www.khronos.org/opengl/wiki/Platform_specifics:_Windows#wglShareLis… Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=11436 -- v3: winex11: Allow replacing either context in wglShareLists. https://gitlab.winehq.org/wine/wine/-/merge_requests/2032

3 7

[PATCH 0/5] MR2621: Some IShellView improvements.
by Jactry Zeng (＠jactry) 10 Apr '23

10 Apr '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2621

2 5

[PATCH 0/2] MR2620: include: Add windows.ui.composition.interop.idl file.
by Mohamad Al-Jaf (＠maljaf) 10 Apr '23

10 Apr '23

Needed for mingw Firefox build. The WIDL error points to the wrong function, specifically the one after it. include/windows.ui.composition.interop.idl:35:63: error: parameter 'swapchain' of function 'CreateCompositionSurfaceForHandle' cannot derive from void * HRESULT CreateCompositionSurfaceForSwapChain([in] IUnknown *swapchain, [out, retval] ICompositionSurface **result); ^ make[1]: *** [Makefile:163749: include/windows.ui.composition.interop.h] Error 1 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2620

3 4

[PATCH v2 0/1] MR2619: mfplat: Handle more video subtypes in MFInitMediaTypeFromAMMediaType().
by Nikolay Sivov (＠nsivov) 09 Apr '23

09 Apr '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: mfplat: Handle more video subtypes in MFInitMediaTypeFromAMMediaType(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2619

2 1

[PATCH 0/1] MR2619: mfplat: Handle more video subtypes in MFInitMediaTypeFromAMMediaType().
by Nikolay Sivov (＠nsivov) 09 Apr '23

09 Apr '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2619

3 2

[PATCH 0/1] MR2618: ntdll: Increment offset by len in build_clr_surrogate_section.
by Alex Henrie (＠alexhenrie) 09 Apr '23

09 Apr '23

Instead of multiplying it by 2. I don't know how this ever worked. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54808 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2618

3 3