April 2023 - Wine-gitlab - list.winehq.org

[PATCH v7 0/10] MR106: vkd3d-shader/hlsl: packoffset() support.
by Francisco Casas (＠fcasas) 04 Apr '23

04 Apr '23

Support manually packing constant buffer elements through the `packoffset(·)` syntax. Support not included yet for simultaneously having semantics, `register(·)`, and `packoffset(·)`, for abnormalities such as: ```hlsl Texture2D tex; cbuffer buff { float4 a : packoffset(c0); sampler sam : packoffset(c0) : register(s1) : SEMANTIC; } float4 main() : sv_target { return tex.Sample(sam, float2(0, 0)) + a; } ``` but this motivated the addition of the `hlsl_ir_var.offset_reservation` field instead of reusing `hlsl_ir_var.reg_reservation`. -- v7: vkd3d-shader/hlsl: Consider register() as manual packing for resource fields. tests: Test packoffset() with resources inside cbuffers. vkd3d-shader/hlsl: Ignore packoffset() contents for SM1. vkd3d-shader/hlsl: Don't allow manual and automatic cbuffer offset packing. vkd3d-shader/hlsl: Detect overlaps in cbuffer offsets. vkd3d-shader/hlsl: Support packoffset(). vkd3d-shader/hlsl: Parse packoffset(). vkd3d-shader/hlsl: Rename struct hlsl_reg_reservation fields. tests: Test packoffset(). tests: Test cbuffer element offsets. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/106

3 11

[PATCH 0/6] MR2577: d3dcompiler: Use the vkd3d-shader DXBC API.
by Henri Verbeet (＠hverbeet) 04 Apr '23

04 Apr '23

The main advantage is that this way we're getting valid DXBC checksums for DXBC blobs generated by d3dcompiler. See also https://bugs.winehq.org/show_bug.cgi?id=54464. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2577

3 8

[PATCH 0/1] MR2467: gitlab: Install X11 utils and some window managers.
by Rémi Bernon 04 Apr '23

04 Apr '23

This adds several handy X11 utilities, such as xrandr, and some other window managers, in order to eventually use a different one and avoid fwvm race conditions. I think it would be interesting to test with some different WMs than fvwm, at least because they are more commonly used. Then, I also think that fvwm has some race conditions, and it causes spurious focus loss, as https://bugs.winehq.org/show_bug.cgi?id=54594 for instance. I've been running the same test in a tight loop with any of the other WMs added here (mutter / kwin / openbox) and it is not reproducing. With fvwm the failure reproduces quickly and systematically. The xrandr utility would be useful in the future, but only after the image is updated to a newer xserver-xorg-video-dummy version which would support multiple screens. It will then be possible to set them up with the following commands: ``` xrandr --addmode DUMMY1 1024x768 \ --addmode DUMMY2 1024x768 xrandr --output DUMMY0 --auto \ --output DUMMY1 --right-of DUMMY0 --mode 1024x768 \ --output DUMMY2 --right-of DUMMY1 --mode 1024x768 xrandr # to refresh the settings ``` Then I think it doesn't hurt to have it installed in the meantime. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2467

2 6

[PATCH 0/5] MR2500: wined3d: Move extension checks out of state tables
by Max Figura (＠maxfigura) 04 Apr '23

04 Apr '23

Removing extension checks from state tables and moving checks to called functions. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2500

5 10

[PATCH 0/1] MR2576: winex11.drv: Fix a typo.
by Zhiyi Zhang (＠zhiyi) 04 Apr '23

04 Apr '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2576

2 1

[PATCH 0/1] MR2575: ws2_32/tests: Adjust test results without host IPv6 support.
by Rémi Bernon 04 Apr '23

04 Apr '23

As seen when running the tests in Docker without IPv6 support configured, see for instance https://test.winehq.org/data/64cca153292833151d1adeb185252ca57e2d1625/linux…. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2575

2 2

[PATCH 0/11] MR2567: Bundle the musl math library
by Alexandre Julliard (＠julliard) 04 Apr '23

04 Apr '23

The goal is to use the bundling mechanism to share the musl math library code between msvcrt and ntdll, and also with a future FPU emulation library. It should also make it easier to sync with upstream changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2567

4 18

[PATCH v2 0/3] MR2573: dinput: Set guidType = GUID_Unknown for HID collections.
by Florian Will (＠w-flo) 04 Apr '23

04 Apr '23

I'm not sure if I'm using the dinput HID test infrastructure correctly. Also, an existing test could be extended instead of adding a whole new test function, saving a couple of source code lines and test execution time, but I wasn't sure which one to extend - feel free to suggest one and I will update the test. Also, maybe the suggested fix is not a great idea. Maybe there are actually some collection objects that are supposed to have a guidType that is not GUID_Unknown? I couldn't find any in the limited number of Windows environments I can access, so I wanted to put it out there for discussion. The issue I'm trying to solve is that Zusi 3 does not appear to check the DIDFT_NODATA bit in dwType, so it just adds most of the objects listed by EnumObjects() to the SetDataFormat() call, maybe filtering out only those that have guidType = GUID_Unknown, or maybe there's an allow-list of GUIDs to add, and that list includes GUID_ZAxis. I haven't seen complaints about joysticks not working in Zusi 3 on Windows, so I guess collections (and DIDFT_NODATA objects in general) rarely/never have a non-Unknown GUID, or maybe Windows simply accepts these collections in SetDataFormat() and that only fails in Wine. -- v2: dinput/tests: Remove unmatched winetest_pop_context(). dinput: Set guidType = GUID_Unknown for HID collections. dinput/tests: Add guidType test for collection objects. https://gitlab.winehq.org/wine/wine/-/merge_requests/2573

3 6

[PATCH 0/1] MR2572: wldap32: Skip over the TLS certificate check if not using TLS.
by Alex Henrie (＠alexhenrie) 04 Apr '23

04 Apr '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54772 I could have fixed this in merge request !2533 but unfortunately I was so focused on testing SSL connections that I didn't notice that non-SSL connections were still broken. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2572

4 3

[PATCH 0/2] MR2573: dinput: Set guidType = GUID_Unknown for HID collections.
by Florian Will (＠w-flo) 04 Apr '23

04 Apr '23

I'm not sure if I'm using the dinput HID test infrastructure correctly. Also, an existing test could be extended instead of adding a whole new test function, saving a couple of source code lines and test execution time, but I wasn't sure which one to extend - feel free to suggest one and I will update the test. Also, maybe the suggested fix is not a great idea. Maybe there are actually some collection objects that are supposed to have a guidType that is not GUID_Unknown? I couldn't find any in the limited number of Windows environments I can access, so I wanted to put it out there for discussion. The issue I'm trying to solve is that Zusi 3 does not appear to check the DIDFT_NODATA bit in dwType, so it just adds most of the objects listed by EnumObjects() to the SetDataFormat() call, maybe filtering out only those that have guidType = GUID_Unknown, or maybe there's an allow-list of GUIDs to add, and that list includes GUID_ZAxis. I haven't seen complaints about joysticks not working in Zusi 3 on Windows, so I guess collections (and DIDFT_NODATA objects in general) rarely/never have a non-Unknown GUID, or maybe Windows simply accepts these collections in SetDataFormat() and that only fails in Wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2573

3 5