April 2023 - Wine-gitlab - list.winehq.org

[PATCH v2 0/1] MR2559: widl: Add support for inherited runtime classes.
by Mohamad Al-Jaf (＠maljaf) 03 Apr '23

03 Apr '23

Needed to build windows.ui.composition.idl. Example code that needs this: ` [ contract(Windows.Foundation.UniversalApiContract, 2.0), marshaling_behavior(agile), threading(both) ] runtimeclass ColorKeyFrameAnimation : Windows.UI.Composition.KeyFrameAnimation { [default] interface Windows.UI.Composition.IColorKeyFrameAnimation; } ` -- v2: widl: Add support for inherited runtime classes. https://gitlab.winehq.org/wine/wine/-/merge_requests/2559

3 4

[PATCH 0/2] MR2558: wldap32: Allow LDAP_OPT_REFERRALS to be set from a pointer.
by Alex Henrie (＠alexhenrie) 03 Apr '23

03 Apr '23

The code was not correct or very clear, and the tests were not testing what they intended to. I expanded the tests and I could add even more tests, but I was trying to stick to fixing the main problem. Two of the new tests are to-do because Wine does not translate LDAP_OPT_ON to WLDAP32_OPT_ON in ldap_get_optionW. I haven't fixed that because to fix it properly, we would have to save the specific value that was passed to Wine's ldap_set_optionW and return that value from ldap_get_optionW instead of what was passed to OpenLDAP's ldap_set_option. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2558

3 3

[PATCH 0/7] MR2563: winemac: Preparatory IME cleanup.
by Rémi Bernon 03 Apr '23

03 Apr '23

Unifying a bit with winex11 before moving things to imm32. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2563

1 7

[PATCH 0/1] MR2561: widl: Add support for composable attribute.
by Mohamad Al-Jaf (＠maljaf) 03 Apr '23

03 Apr '23

Needed to build windows.ui.composition.idl. Example: ` [ composable(Windows.UI.Composition.ICompositionEasingFunctionFactory, public, Windows.Foundation.UniversalApiContract, 2.0), contract(Windows.Foundation.UniversalApiContract, 2.0), marshaling_behavior(agile), static(Windows.UI.Composition.ICompositionEasingFunctionStatics, Windows.Foundation.UniversalApiContract, 12.0), threading(both) ] runtimeclass CompositionEasingFunction : Windows.UI.Composition.CompositionObject { [default] interface Windows.UI.Composition.ICompositionEasingFunction; } ` Some WinRT headers use `protected` rather than `public` for the composable attribute like windows.ui.xaml.media.idl:2304 `[composable(Windows.UI.Xaml.Media.ICacheModeFactory, protected, Windows.Foundation.UniversalApiContract, 1.0)]` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2561

3 3

[PATCH 0/1] MR2546: winegstreamer: Create extra decodebin to decode compressed stream.
by Ziqing Hui (＠zhui) 03 Apr '23

03 Apr '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2546

3 8

[PATCH 0/2] MR2560: dinput: Add test and fix EnumObjects callback return value handling.
by Florian Will (＠w-flo) 03 Apr '23

03 Apr '23

First commit adds a "todo_wine" test, second commit fixes the behavior and marks the test as no longer "todo". It looks like the same logic is already implemented (and tested) for the EnumDevices method. Commit message for the fix commit: --- This solves an issue in ZUSI 3 settings for DirectInput devices. Delphi defines the True value of the "C-compatible" LongBool type as -1, which wine interpreted to mean DIENUM_STOP because it is != DIENUM_CONTINUE. Change that logic so only an explicit DIENUM_STOP (= 0) return value stops the enumeration of objects. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2560

4 6

[PATCH 0/1] MR2559: widl: Add support for inherited runtime classes.
by Mohamad Al-Jaf (＠maljaf) 03 Apr '23

03 Apr '23

Needed to build windows.ui.composition.idl. Example code that needs this: ` [ contract(Windows.Foundation.UniversalApiContract, 2.0), marshaling_behavior(agile), threading(both) ] runtimeclass ColorKeyFrameAnimation : Windows.UI.Composition.KeyFrameAnimation { [default] interface Windows.UI.Composition.IColorKeyFrameAnimation; } ` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2559

3 3

[PATCH 0/7] MR2562: winex11: Preparatory XIM cleanup.
by Rémi Bernon 03 Apr '23

03 Apr '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2562

1 7

Re: [PATCH v4 0/1] MR2305: rpcrt4: Pass the binding handle to server call function.
by Yeshun Ye (＠yeyeshun) 03 Apr '23

03 Apr '23

On Wed Mar 1 08:51:53 2023 +0000, Zhiyi Zhang wrote: > Make sure you pass the tests on the TestBots at > https://testbot.winehq.org/Submit.pl first. If you have other tests > failing only locally, you can comment them out for the time being. I tried to add a test for this change, but it's too complex for me. I tested my change with the project: https://github.com/ivellioscolin/NCALRPC_example The project 'NCALRPC_example' using explicit binding handle, and the handle is always 0 in server functions. I add some code in function 'RPCGet' in the file NCALRPC_example\Server\RPCServerImpl.cpp: ` DWORD pid; I_RpcBindingInqLocalClientPID(hBinding, &pid); pData->outSize = pid; ` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2305#note_28607

1 0

[PATCH 0/1] MR2439: ntoskrnl: Free memory before pointer gets set to NULL.
by Bernhard Übelacker 02 Apr '23

02 Apr '23

Without this patch the memory pointed to by context->in_buff gets leaked on each call to GetVolumeInformationByHandleW and the memory usage of winedevice.exe grows. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52322 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2439

2 3