May 2023 - Wine-gitlab - list.winehq.org

[PATCH 0/1] MR2507: vbscript: Add additional types for stack_pop_bool.
by Jason Millard (＠jsm174) 21 Jun '23

21 Jun '23

I have found some scripts where comparisons that use floats and OLECOLOR directly fail. For example: ``` If Light005.State Then ' State is a float V_R4 End If If Light005.Colorfull Then ' Colorfull is an OLECOLOR VT_UI4 End If ``` This is because `stack_pop_bool` does not handle `VT_R4` and `VT_UI4` and returns `E_NOTIMPL`. This adds additional types to `stack_pop_bool` similar to `VARIANT_Coerce`. Fixes https://bugs.winehq.org/show_bug.cgi?id=54731 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2507

4 7

[PATCH 0/1] MR1305: ntdll: The maximum length for a path is MAX_PATH.
by Jiajin Cui (＠jin-king1) 21 Jun '23

21 Jun '23

see "https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-li…". Signed-off-by: Jiajin Cui <cuijiajin(a)uniontech.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1305

3 3

[PATCH 0/1] MR1306: win32u: When the window is not visible but has WS_VISIBLE flag, we should update the vis rgn.
by Jiajin Cui (＠jin-king1) 21 Jun '23

21 Jun '23

When the child window and the parent window are no longer in the same process, the parent window shadow does not update the vis rgn of the child window and modify the WS_VISIBLE style of the child window. so we need to update the vis rgn when another process gets the DC of the child window. Signed-off-by: Jiajin Cui <cuijiajin(a)uniontech.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1306

2 2

[PATCH 0/1] MR217: include: Use WIN32_LEAN_AND_MEAN to exlude non-required headers
by Alistair Leslie-Hughes (＠alesliehughes) 20 Jun '23

20 Jun '23

Reference https://bugs.winehq.org/show_bug.cgi?id=54985 >From the line we see the mingw version used causes an In file included from /usr/share/mingw-w64/include/unknwnbase.h:47, [ 935s] from /usr/share/mingw-w64/include/objidlbase.h:439, [ 935s] from include/combaseapi.h:29, [ 935s] from include/objbase.h:267, [ 935s] from include/ole2.h:25, [ 935s] from /usr/share/mingw-w64/include/wtypes.h:13, [ 935s] from include/winscard.h:22, [ 935s] from include/windows.h:68, [ 935s] from libs/vkd3d/include/private/vkd3d_common.h:23, [ 935s] from libs/vkd3d/libs/vkd3d-shader/vkd3d_shader_private.h:49, [ 935s] from libs/vkd3d/libs/vkd3d-shader/preproc.y:24, [ 935s] from libs/vkd3d/libs/vkd3d-shader/preproc.l:23: [ 935s] /usr/share/mingw-w64/include/wtypesbase.h:148:16: error: redefinition of 'struct _SECURITY_ATTRIBUTES' [ 935s] 148 | typedef struct _SECURITY_ATTRIBUTES { The included file winscard.h seemed a little odd. The vkd3d isn't going to use this. Adding the define WIN32_LEAN_AND_MEAN to the Makefile.in (in wine), produce the following warnings. /home/alesliehughes/wine/libs/vkd3d/include/private/vkd3d_common.h:75:5: warning: implicit declaration of function ‘abort’ [-Wimplicit-function-declaration] 75 | abort(); | ^~~~~ /home/alesliehughes/wine/libs/vkd3d/include/private/vkd3d_common.h:258:14: warning: implicit declaration of function ‘atoi’ [-Wimplicit-function-declaration] 258 | *major = atoi(version); Adding header <stdlib.h> removed all the warnings. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/217

5 7

[PATCH v4 0/4] MR1710: mf: Discard end of presentation on IMFMediaSession_Stop.
by Rémi Bernon 20 Jun '23

20 Jun '23

MR !607 was trying to fix an issue with Life Is Strange Remastered, but although it fixed some race conditions with presentation end, the issue it was trying to fix is still there. The game calls IMFMediaSession_Stop while the presentation is ending, expects that command to quickly execute, interrupting the presentation end and emitting a MESessionStopped event instead of the MESessionEnded. Delaying the Stop command and emitting the MESessionEnded event breaks the game assumptions and it crashes. -- v4: mf: Discard end of presentation on IMFMediaSession_Stop. mf/tests: Test IMFMediaSession_Stop command near presentation end. mf/tests: Test Start / Pause / Stop IMFMEdiaSession events. mf/tests: Split wait_media_event helper into wait_next_media_event. https://gitlab.winehq.org/wine/wine/-/merge_requests/1710

2 10

[PATCH v2 0/5] MR2782: mf/tests: Test byte stream handler resolution time and media source presentation descriptor.
by Rémi Bernon 20 Jun '23

20 Jun '23

This tests that the resolution should be quick enough to not trigger an Unreal Engine race condition. This also checks the determinism of the media source presentation descriptor stream ordering, as well as the stream selection updates when the media source is started. -- v2: mf/tests: Test media source presentation stream descriptor update. winegstreamer: Keep a reference on the media source start descriptor. mf/tests: Test media sources stream descriptors attributes. mf/tests: Test media sources with multiple audio/video streams. mf/tests: Test byte stream handler to media source resolution time. https://gitlab.winehq.org/wine/wine/-/merge_requests/2782

2 12

[PATCH v2 0/1] MR2348: comdlg32: Add parent dir button to "Item" file dialog.
by Florian Will (＠w-flo) 17 Jun '23

17 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=29912 Now it looks like this (this patch adds the separator & "up" button): ![Bildschirmfoto_vom_2023-03-08_13-34-36](/uploads/cd30de5b3fa5f39accb4dd14a3f54421/Bildschirmfoto_vom_2023-03-08_13-34-36.png) -- v2: comdlg32: Add parent dir button to "Item" file dialog. https://gitlab.winehq.org/wine/wine/-/merge_requests/2348

2 5

[PATCH v3 0/2] MR2740: winemenubuilder: Create .desktop files for programs that open URIs
by Alex Henrie (＠alexhenrie) 13 Jun '23

13 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=22904 -- v3: winecfg: Mention protocol associations. winemenubuilder: Create .desktop files for programs that open URIs. https://gitlab.winehq.org/wine/wine/-/merge_requests/2740

4 11

[PATCH 0/1] MR2887: winegstreamer: Make sure threads are not waiting for event_cond object.
by Santino Mazza (＠tati1454) 08 Jun '23

08 Jun '23

First we set the EOS state, so the wait_parser_stream_buffer function doesn't call pthread_cond_wait again. Then we must call pthread_cond_signal to make sure that no one is waiting for it, if we don't do that, there is the possibility of hanging wg_parser_disconnect at the free_stream call, because pthread_cond_destroy will hang when the cond object is being waited by other threads. Specifically this helps to fix a hang in some applications, specially Unreal Engine games when changing sources too fast in a MediaPlayer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2887

3 6

[PATCH v5 0/3] MR1259: gitlab: Run some tests with nulldrv driver.
by Rémi Bernon 08 Jun '23

08 Jun '23

Allowing the job to fail to avoid failing the pipeline. Some new tests are failing with it, and some are succeeding todo_wine. -- v5: gitlab: Run user32 32-bit tests with nulldrv driver. user32/tests: Update todos specific to the X11 display driver. user32/tests: Check graphics driver and add todos for nulldrv. https://gitlab.winehq.org/wine/wine/-/merge_requests/1259

1 5