July 2023 - Wine-gitlab - list.winehq.org

[PATCH v4 0/3] MR255: vkd3d-shader: Scan for the maximum temporary register in d3dbc and emit a spirv temp array accordingly.
by Zebediah Figura (＠zfigura) 04 Jul '23

04 Jul '23

``` On Margate Sands. I can connect Nothing with nothing. ``` -- v4: vkd3d-shader/d3dbc: Scan for the maximum temporary register index. vkd3d-shader: Record a global temporary count per sm4 shader. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/255

4 6

[PATCH v2 0/1] MR252: vkd3d-shader/hlsl: Add constant folding for 'rcp'.
by Nikolay Sivov (＠nsivov) 04 Jul '23

04 Jul '23

-- v2: vkd3d-shader/hlsl: Add constant folding for 'rcp'. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/252

5 4

[PATCH v3 0/3] MR251: vkd3d: Fix a few resource leaks here and there
by Giovanni Mascellani (＠giomasce) 04 Jul '23

04 Jul '23

-- v3: vkd3d: Release op data when destroying the queue. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/251

3 4

[PATCH v4 0/5] MR250: vkd3d-shader/hlsl: Declare vars individually when parsing declarations.
by Francisco Casas (＠fcasas) 04 Jul '23

04 Jul '23

In a declaration with multiple variables, the variables must be created before the initializer of the next variable is parsed. This is required for initializers such as: ``` float a = 1, b = a, c = b + 1; ``` The solution is to parse the type information in the same rule as the first variable ('a' in this case) so that it can be declared before the parser reaches the initializer for the following variables. To initialize the following variables, the type information is passed along from the first variable's struct parse_variable_def to the next and so on. --- Solves https://bugs.winehq.org/show_bug.cgi?id=54484, pointed out by @nsivov. -- v4: vkd3d-shader/hlsl: Declare vars individually when parsing struct declarations. vkd3d-shader/hlsl: Declare vars individually when parsing regular declarations. vkd3d-shader/hlsl: Split declare_vars(). tests: Test multiple variable initializers. tests: Test semantics in uniform variables. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/250

4 8

[PATCH v4 0/5] MR224: tests: Test coarse and fine derivates and demand less precision from ddx() and ddy().
by Francisco Casas (＠fcasas) 04 Jul '23

04 Jul '23

On my Nvidia GeForce GTX 1050 Ti `ddxddy.shader_test` doesn't pass because of considerably different numeric results. As Giovanni pointed out, this is because my GPU uses the fine derivate and not the coarse derivate to implement ddx() and ddy(). For this reason, the result for ddx|ddy() is quantized so that the test passes if the GPU uses either coarse or fine derivates. Additionally, tests for both ddx_coarse|ddy_coarse() and ddx_fine|ddy_fine() are added, that expect a more precise result. -- v4: vkd3d-shader/hlsl: Support fine derivates. vkd3d-shader/hlsl: Support coarse derivates. tests: Quantize regular and coarse derivate test results. tests: Make ddx() and ddy() test behave correctly for shader models < 4. tests: Test coarse and fine derivates. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/224

4 8

[PATCH 0/1] MR261: vkd3d-shader: Add compiler option to specify matrix majority.
by Nikolay Sivov (＠nsivov) 04 Jul '23

04 Jul '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/261

3 2

[PATCH v2 0/2] MR3232: d3d10core/tests: Mark test failures specific to the Vulkan or GL renderers.
by Zebediah Figura (＠zfigura) 04 Jul '23

04 Jul '23

This is obviously questionable, as it requires reaching into Wine internals in tests (beyond simply detecting whether Wine is in use). However, we are at a point where, for d3d10 and above, the Vulkan renderer works well enough in general to see real use [in fact, in my experience it usually works better than the GL renderer], and at this point I think avoiding regressions is quite important. It is currently difficult to run tests with it when the results contain so much noise, and I think we need to solve this problem, by actually marking which tests work on each backend. We could in theory expose the renderer through some adapter string, but I believe in the past applications have been sensitive about the contents of adapter strings. Fixing either renderer to reach and maintain parity is not feasible. The GL renderer is not going away, but regrettably GL as an API is abandoned by Khronos, and important features we need in order to implement some Direct3D features will probably never be introduced into GL. Moreover, the amount of effort that would be required to reach parity is not small, and itself would all need to be verified manually. -- v2: d3d10core/tests: Mark test failures specific to the Vulkan or GL renderers. https://gitlab.winehq.org/wine/wine/-/merge_requests/3232

4 4

[PATCH 0/3] MR3217: wined3d: Reuse command buffers and fences.
by Zebediah Figura (＠zfigura) 04 Jul '23

04 Jul '23

This improves performance with Batman: Arkham Knight on NVidia drivers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3217

3 4

[PATCH 0/5] MR3212: wined3d: Reduce command stream CPU usage, part 1
by Matteo Bruni (＠Mystral) 04 Jul '23

04 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3212

4 12

Re: [PATCH v3 0/6] MR3165: dxgi: Introduce a worker thread for each D3D12 swapchain (first part).
by Henri Verbeet (＠hverbeet) 04 Jul '23

04 Jul '23

> The part that doesn't thrill me is the fact that DXGI still directly accesses the VkQueue object, which I tend to see as an internal implementation detail to vkd3d. On the other hand it's nice that we don't need new API from vkd3d (even if, in the future, we were to need something other than vkQueueSubmit() and vkQueuePresentKHR()). For what it's worth, it was a fairly explicit design decision early on to expose the underlying Vulkan objects for d3d12 devices and command queues, as well as to allow the creation of d3d12 resources on top of existing Vulkan images, for the purpose of interoperation with other Vulkan code. I.e., the idea is that it should be possible to integrate vkd3d into a larger Vulkan application to draw some parts using the d3d12 API, while everything else is drawn using Vulkan. The internal queueing of command queue operations on the vkd3d level is unfortunate in that regard; ideally we just wouldn't do that. This MR could probably do a better job of explaining why we need to do that in some cases, and what kind of command queue operation sequences could result in out-of-order presentation. If we're going to need to introduce a DXGI worker thread anyway, could we just make vkd3d_acquire_vk_queue() block until there are no longer any operations queued? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3165#note_37779

1 0