July 2023 - Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/7] MR3262: dxgi: Introduce a worker thread for each D3D12 swapchain (second part). - approved
by Alexandre Julliard (＠julliard) 13 Jul '23

13 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3262

1 0

Re: [PATCH v6 0/1] MR3269: wininet: Handle http headers correctly when length is 0 - approved
by Alexandre Julliard (＠julliard) 13 Jul '23

13 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3269

1 0

Re: [PATCH v4 0/2] MR3198: combase: Pass the correct destination context when unmarshaling using the standard marshaler. - approved
by Alexandre Julliard (＠julliard) 13 Jul '23

13 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3198

1 0

Re: [PATCH v2 0/1] MR3310: conhost: Fix ctrl-c handling. - approved
by Alexandre Julliard (＠julliard) 13 Jul '23

13 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3310

1 0

Re: [PATCH v3 0/1] MR253: vkd3d-shader/hlsl: Skip unallocated variables when looking for reservation conflicts. - approved
by Alexandre Julliard (＠julliard) 13 Jul '23

13 Jul '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/253

1 0

Re: [PATCH v2 0/1] MR3315: ntdll: Fix NtContinue from within exception context on ARM64
by Billy Laws (＠bylaws) 13 Jul '23

13 Jul '23

On Thu Jul 13 19:42:16 2023 +0000, Jinoh Kang wrote: > This leads to a regression: NtContinue() can no longer properly restore > X16 and X17, since they are now clobbered by `__wine_syscall_dispatcher_return`. > The proper fix is at > https://www.winehq.org/mailman3/hyperkitty/list/wine-devel(a)winehq.org/thr…, > which is a superset of this patchset. > I don't have an ARM64 build machine at the moment; can you rebase it and > see if it works? > Many thanks for your work! Can verify that your patch works for me, apologies for missing this in my original MR -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3315#note_38932

1 0

[PATCH v6 0/1] MR3294: wow64win: Always use NtUserSetWindowLongPtr() for GWLP_WNDPROC.
by Sven Baars (＠sbaars) 13 Jul '23

13 Jul '23

This fixes SetWindowLongPtr on WoW64. On 32-bit, we have ``` #define SetWindowLongPtrA SetWindowLongA #define SetWindowLongPtrW SetWindowLongW ``` meaning that on WoW64, all pointers passed would be padded with `0xffffffff` (because they are treated as LONG), and this is the cause of many of the failing WoW64 tests. This fixes that behavior. I'm not sure if this is the right place to fix it though. -- v6: wow64win: Always use NtUserSetWindowLongPtr() for GWLP_HINSTANCE and GWLP_WNDPROC. https://gitlab.winehq.org/wine/wine/-/merge_requests/3294

4 3

Re: [PATCH v5 0/2] MR3301: Improve trace output
by Jeffrey Smith (＠whydoubt) 13 Jul '23

13 Jul '23

On Thu Jul 13 16:38:12 2023 +0000, Jeffrey Smith wrote: > Same issue with comparison of an enumeration. As above, this thread can be dismissed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3301#note_38930

1 0

Re: [PATCH v5 0/2] MR3301: Improve trace output
by Jeffrey Smith (＠whydoubt) 13 Jul '23

13 Jul '23

On Thu Jul 13 18:07:29 2023 +0000, Gabriel Ivăncescu wrote: > There's no need for a cast though. `ARRAY_SIZE` is already `size_t` > (because it's implemented with `sizeof`), and a comparison between a > signed integer and an unsigned integer with at least as many bits is > always promoted to unsigned. That is true. This thread can be dismissed then. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3301#note_38929

1 0

Re: [PATCH v5 0/2] MR3301: Improve trace output
by Gabriel Ivăncescu 13 Jul '23

13 Jul '23

On Thu Jul 13 16:37:28 2023 +0000, Jeffrey Smith wrote: > Compilers can (and at least some do) treat an enumeration as a _signed_ > integer. For the comparison to work as desired you'll want to cast > `InformationClass` to an unsigned type. I think `size_t` would be appropriate. There's no need for a cast though. `ARRAY_SIZE` is already `size_t` (because it's implemented with `sizeof`), and a comparison between a signed integer and an unsigned integer with at least as many bits is always promoted to unsigned. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3301#note_38928

1 0