August 2023 - Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/5] MR3433: wined3d: Move GL declarations to wined3d_gl.h, part 1. - approved
by Alexandre Julliard (＠julliard) 02 Aug '23

02 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3433

1 0

Re: [PATCH v2 0/6] MR291: vkd3d-shader/preproc: Various fixes. - approved
by Alexandre Julliard (＠julliard) 02 Aug '23

02 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/291

1 0

Re: [PATCH v3 0/4] MR288: hlsl: Some fixes caught by Wine tests. - approved
by Alexandre Julliard (＠julliard) 02 Aug '23

02 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/288

1 0

Re: [PATCH v3 0/1] MR287: vkd3d: Implement ID3D12Fence1. - approved
by Alexandre Julliard (＠julliard) 02 Aug '23

02 Aug '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/287

1 0

Re: [PATCH v4 0/4] MR3439: mf: Implement basic urlmon scheme handler.
by Rémi Bernon 02 Aug '23

02 Aug '23

v3: Use a generic `MF_BYTESTREAM_CONTENT_TYPE` instead of using `MF_RESOLUTION_CONTENT_DOES_NOT_HAVE_TO_MATCH_EXTENSION_OR_MIME_TYPE`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3439#note_41022

1 0

Re: [PATCH v4 0/4] MR3439: mf: Implement basic urlmon scheme handler.
by Rémi Bernon 02 Aug '23

02 Aug '23

On Mon Jul 31 08:12:43 2023 +0000, Rémi Bernon wrote: > Actually I'm not even sure this is very useful. The scheme resolver also > sets the `MF_BYTESTREAM_CONTENT_TYPE` attributes on Windows (although to > `audio/x-wav`), which will be enough to not require `MF_RESOLUTION_CONTENT_DOES_NOT_HAVE_TO_MATCH_EXTENSION_OR_MIME_TYPE`. > On Wine we will miss the content type until we have a better > implementation of http scheme handlers with access to the response headers. I've added a generic `MF_BYTESTREAM_CONTENT_TYPE` instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3439#note_41020

1 0

[PATCH v3 0/4] MR3439: mf: Implement basic urlmon scheme handler.
by Rémi Bernon 02 Aug '23

02 Aug '23

Let The Good Life able to play its intro video, the game creates a source reader from a `http://localhost:6000/<random-hash>` URL. This should also probably work with other games playing streams over http(s). This is a very basic implementation, using urlmon, and it will download the entire stream to a local temporary file before playback. An more optimized implementation would probably use WinHttp and range requests to partially download the requested stream segments, but this can be implemented in a future change. -- v3: mf/scheme_handler: Implement http(s):// scheme handler using urlmon. mf/scheme_handler: Split file scheme handler to scheme_handler.c. mf/tests: Add some network scheme resolver tests. include: Add MF_BYTESTREAM_EFFECTIVE_URL GUID declaration. https://gitlab.winehq.org/wine/wine/-/merge_requests/3439

1 4

Re: [PATCH v2 0/3] MR3472: secur32: Convert "Negotiate" to an LSA package.
by Hans Leidekker (＠hans) 02 Aug '23

02 Aug '23

Hans Leidekker (@hans) commented about dlls/secur32/tests/Makefile.in: > TESTDLL = secur32.dll > -IMPORTS = secur32 crypt32 advapi32 ws2_32 > +IMPORTS = secur32 crypt32 advapi32 ws2_32 ntdll This causes a link failure on Windows. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3472#note_41017

1 0

Re: [PATCH v2 0/3] MR3472: secur32: Convert "Negotiate" to an LSA package.
by Hans Leidekker (＠hans) 02 Aug '23

02 Aug '23

Hans Leidekker (@hans) commented about dlls/secur32/lsa.c: > DWORD err, i; > HKEY root; > SecureProvider *provider; > + struct lsa_package package; > + NTSTATUS status; > + > + memset(&package, 0, sizeof(package)); > + > + /* "Negotiate" has package id 0, .Net depends on this. */ > + status = nego_SpLsaModeInitialize(SECPKG_INTERFACE_VERSION, &package.lsa_api_version, &package.lsa_api, &package.lsa_table_count); > + if (status == STATUS_SUCCESS) > + { > + status = package.lsa_api->InitializePackage(0, &lsa_dispatch, NULL, NULL, &package.name); > + if (status == STATUS_SUCCESS) > + { Please factor out a function to initialize a package. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3472#note_41016

1 0

[PATCH v4 0/4] MR585: Improve is_gecko_path() for handling non-ASCII characters.
by Jactry Zeng (＠jactry) 02 Aug '23

02 Aug '23

This fixes an issue when the path includes non-ASCII characters. Signed-off-by: Jactry Zeng <jzeng(a)codeweavers.com> -- v4: mshtml: Call UrlUnescapeW() with URL_UNESCAPE_AS_UTF8 in is_gecko_path(). shlwapi/tests: Test UrlUnescapeW() with URL_UNESCAPE_AS_UTF8. kernelbase: Implement URL_UNESCAPE_AS_UTF8 for UrlUnescapeW(). shlwapi/tests: Test UrlUnescapeW() with independent data. https://gitlab.winehq.org/wine/wine/-/merge_requests/585

3 10