August 2023 - Wine-gitlab - list.winehq.org

[PATCH 0/6] MR3572: mf: Make session_get_node_object() more robust.
by Zhiyi Zhang (＠zhiyi) 16 Aug '23

16 Aug '23

It's possible that a state object pointer not in the topology node collection gets passed to session_get_node_object(). Instead of returning the last node when the object is not found, we should return a NULL so that the state of the last node is not changed by mistake. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3572

4 20

Re: [PATCH v2 0/2] MR3431: wined3d: Fix clears of the current render target in Vulkan
by Alexandre Julliard (＠julliard) 16 Aug '23

16 Aug '23

This will need a rebase. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3431#note_42435

1 0

Re: [PATCH v3 0/1] MR3484: sane.ds: Fix pixel type setting.
by Alexandre Julliard (＠julliard) 16 Aug '23

16 Aug '23

Please fix the authorship information in the commit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3484#note_42426

1 0

[PATCH v2 0/1] MR3576: include: Add __WINE_ALLOC_SIZE to the definition of FNALLOC.
by Alex Henrie (＠alexhenrie) 16 Aug '23

16 Aug '23

I missed this one in commit 8f60004995dfc0830067d5d0450a30ef64c54b14. -- v2: include: Add __WINE_ALLOC_SIZE to the definition of FNALLOC. https://gitlab.winehq.org/wine/wine/-/merge_requests/3576

2 1

Re: [PATCH v3 0/2] MR3547: Common Controls: Fix balloon tooltips
by Carl Bialorucki (＠cbialorucki) 16 Aug '23

16 Aug '23

On Wed Aug 16 00:08:12 2023 +0000, Nikolay Sivov wrote: > This combines unrelated changes. Region part should have its own test, > if it's correct to begin with. I already removed the region changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3547#note_42412

1 0

[PATCH 0/1] MR3575: winepulse: Fix crash when requesting exclusive mode with an unsupported format.
by Davide Beatrici (＠davidebeatrici) 15 Aug '23

15 Aug '23

Fixes #55362. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3575

3 3

Re: [PATCH v3 0/2] MR3547: Common Controls: Fix balloon tooltips
by Nikolay Sivov (＠nsivov) 15 Aug '23

15 Aug '23

This combines unrelated changes. Region part should have its own test, if it's correct to begin with. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3547#note_42404

1 0

[PATCH v4 0/11] MR3542: mshtml: Implement Cycle Collection for all mshtml objects (dispex), part 4.
by Gabriel Ivăncescu 15 Aug '23

15 Aug '23

The first few patches will introduce temporary leaks or cyclic refs, but that's because we'll handle them properly with the dispex CC, and the last patch should fix this. Other objects' traversal will follow in another MR. EDIT: This now does more prep work and converts nodes to use the dispex CC, using temporary helpers, without any other object or temporary leaks yet. -- v4: mshtml: Release the event target during node unlink. mshtml: Implement node cycle collection using the dispex. mshtml: Move ccref from the node to the dispex. mshtml: Rename EventTarget_QI to EventTarget_QI_no_cc. mshtml: Rename dispex_query_interface to dispex_query_interface_no_cc. mshtml: Use designated initializers in node vtables. mshtml: Use designated initializers in dispex and event target vtables. mshtml: Make all event target vtbls const. mshtml: Split IUnknown methods for outer windows into separate vtable. mshtml: Move console to the inner window. mshtml: Use ASCII strings for dispex object names. https://gitlab.winehq.org/wine/wine/-/merge_requests/3542

2 14

Re: [PATCH v6 0/1] MR2565: mmdevapi: Implement function 'AEV_SetMasterVolumeLevelScalar'
by Davide Beatrici (＠davidebeatrici) 15 Aug '23

15 Aug '23

On Wed Apr 12 05:47:11 2023 +0000, Yeshun Ye wrote: > Yes, I'm fixing a bug of an application, not implementing the set of > Endpoint Volume API. > Do I really need to write some tests? Well, it's important. We can't risk setting the wrong volume and potentially ruining physical audio equipment (and eardrums). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2565#note_42399

1 0

Re: [PATCH v3 0/1] MR3574: configure: don't require pcsclite header for winscard
by Gijs Vermeulen (＠gverm) 15 Aug '23

15 Aug '23

On Tue Aug 15 20:36:58 2023 +0000, Hans Leidekker wrote: > @gverm Does this patch work for you? Yeah, it works for me on both macOS & Linux. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3574#note_42398

1 0