September 2023 - Wine-gitlab

[PATCH v9 0/6] MR3548: windows.applicationmodel: Implement some functions.
by Mohamad Al-Jaf (＠maljaf) 25 Sep '23

25 Sep '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52665 I'm unsure how to add tests for this given it requires an app to be installed via MSIX to get a package ID in Windows otherwise `IPackageStatics::get_Current()` returns `0x80073d54`. -- v9: windows.applicationmodel: Implement IStorageItem::get_Path(). windows.applicationmodel/tests: Add IStorageItem::get_Path() tests. windows.applicationmodel: Add IStorageItem stub interface. windows.applicationmodel: Implement IPackage::get_InstalledLocation(). windows.applicationmodel: Implement IPackageStatics::get_Current(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3548

4 9

[PATCH 0/1] MR3948: cabinet/tests: Initialize CURR_DIR globally.
by Jactry Zeng (＠jactry) 25 Sep '23

25 Sep '23

So that we can run each test function independently. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3948

2 1

[PATCH 0/1] MR3941: wpcap: Use the strdup function instead of reimplementing it.
by Alex Henrie (＠alexhenrie) 25 Sep '23

25 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3941

3 2

[PATCH v8 0/6] MR3548: windows.applicationmodel: Implement some functions.
by Mohamad Al-Jaf (＠maljaf) 25 Sep '23

25 Sep '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52665 I'm unsure how to add tests for this given it requires an app to be installed via MSIX to get a package ID in Windows otherwise `IPackageStatics::get_Current()` returns `0x80073d54`. -- v8: windows.applicationmodel: Implement IStorageItem::get_Path(). windows.applicationmodel/tests: Add IStorageItem::get_Path() tests. windows.applicationmodel: Add IStorageItem stub interface. windows.applicationmodel: Implement IPackage::get_InstalledLocation(). windows.applicationmodel: Implement IPackageStatics::get_Current(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3548

3 7

[PATCH v7 0/1] MR3931: windows.ui: Support accent colors in uisettings3_GetColorValue.
by Myah Caron (＠qsniyg) 25 Sep '23

25 Sep '23

Fixes https://bugs.winehq.org/show_bug.cgi?id=55640. The lightening/darkening values are loosely based on Qt 6's fallback code: https://github.com/qt/qtbase/blob/ba98644180bcaf40341a9005abe93575cf45cc5a/…. The values are not perfect, technically it should use Software\Microsoft\Windows\DWM\AccentColor. But since to my knowledge, wine doesn't use AccentColor in any way, this should do the trick for now. `COLOR_HIGHLIGHT` should be roughly the same color as the accent color in most cases. Qt 6 uses the accent color as its highlight color anyways. -- v7: windows.ui: Support accent colors in uisettings3_GetColorValue. https://gitlab.winehq.org/wine/wine/-/merge_requests/3931

3 3

[PATCH v9 0/12] MR346: Draft: tests/shader-runner: Test DXIL shaders.
by Conor McCarthy (＠cmccarthy) 25 Sep '23

25 Sep '23

This goes on top of MR 320 and 345. -- v9: tests/shader-runner: Add a '--dump-dxil' command line switch. tests/shader-runner: Test shaders with dxcompiler. tests/shader-runner: Replace immediate shader type strings with an enum. tests/shader-runner: Do not exit if a 'require' directive is not met. tests/shader-runner: Handle individual keywords in shader directives. vkd3d-shader/dxil: Implement DX instruction LoadInput. vkd3d-shader/dxil: Declare shader inputs. vkd3d-shader/dxbc: Load input signatures also from ISG1 chunks. vkd3d-shader/spirv: Build undefined values once. vkd3d-shader/spirv: Introduce a Static Single Assignment register type. vkd3d-shader/d3d-asm: Trace undefined registers. vkd3d-shader: Make the paramater allocator slab size at least MAX_REG_OUTPUT. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/346

2 12

Re: [PATCH v36 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Jeffrey Smith (＠whydoubt) 25 Sep '23

25 Sep '23

The three .h files in your tests are --in effect-- huge data blobs, which is something that should usually be avoided in source code repositories as far as is possible. I haven't had a chance to look in detail at how you are using them, but here a couple of things you may want to investigate: 1. Can the tests be accomplished with smaller sample files? 2. Better yet, can the buffers be --at least partially-- generated programmatic at test time? (as I did with `setup_pe_with_sections` in my tests) BTW, what was your source for those three buffers? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46566

1 0

[PATCH v8 0/12] MR346: Draft: tests/shader-runner: Test DXIL shaders.
by Conor McCarthy (＠cmccarthy) 25 Sep '23

25 Sep '23

This goes on top of MR 320 and 345. -- v8: tests/shader-runner: Add a '--dump-dxil' command line switch. tests/shader-runner: Test shaders with dxcompiler. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/346

2 12

[PATCH v4 0/1] MR3331: ntdll/tests: Add more reparse/junction point tests.
by Alex Henrie (＠alexhenrie) 24 Sep '23

24 Sep '23

Based on a patch by Erich E. Hoover. -- v4: ntdll/tests: Add more reparse/junction point tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3331

3 2

[PATCH v4 0/1] MR3096: ntdll: Add NtGetNextProcess stub.
by Alex Henrie (＠alexhenrie) 24 Sep '23

24 Sep '23

The stub is enough for TokenViewer.exe to start up and display its user interface. Based on a patch by Nikolay Sivov. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45119 -- v4: ntdll: Add NtGetNextProcess stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/3096

2 1