September 2023 - Wine-gitlab

Re: [PATCH v6 0/1] MR3736: winmm: Use CRT allocation functions.
by Huw Davies (＠huw) 13 Sep '23

13 Sep '23

> it's necessary to cast the pointers returned from malloc and realloc here because we add 1 to the pointer before assigning it to a variable. It's unusual but it works. Still, we could simplify this code a bit by only calling realloc. Right, sorry about that. However, let's start off with a commit that makes this explicit, to avoid mistakes by future reviewers. Something like: ```c if (llTypes[type].lpMlds) { WINE_MLD *mem = llTypes[type].lpMlds - 1; mem = HeapReAlloc(GetProcessHeap(), 0, mem, sizeof(WINE_MLD) * (llTypes[type].wMaxId + 1)); llTypes[type].lpMlds = mem + 1; } else { WINE_MLD *mem; mem = HeapAlloc(GetProcessHeap(), 0, sizeof(WINE_MLD) * (llTypes[type].wMaxId + 1)); llTypes[type].lpMlds = mem + 1; } ``` Then we can merge to two branches into `realloc()` in the commit that switches things to the CRT allocator. > As far as the casts in the calls to free, they are all to avoid warnings about freeing pointers to const strings, so they can't be removed. Got it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3736#note_45151

1 0

[PATCH v24 0/6] MR2808: SNI tray implementation
by Cherser-s (＠Cherser-s) 13 Sep '23

13 Sep '23

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v24: winesni.drv: add dbus watch instead of using plain unix fds and flush winesni.drv: replaced the dbus connection logic with a single connection per each SNI object winesni.drv: wrap functions with pthread mutex locking winesni.drv: implement basic balloon notification support explorer: add winesni.drv tray implementation support winesni.drv: add KDE StatusNotifierItem implementation for tray https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

3 7

[PATCH v6 0/5] MR3572: mf: Make session_get_node_object() more robust.
by Zhiyi Zhang (＠zhiyi) 13 Sep '23

13 Sep '23

It's possible that a state object pointer not in the topology node collection gets passed to session_get_node_object(). Instead of returning the last node when the object is not found, we should return a NULL so that the state of the last node is not changed by mistake. -- v6: mf/tests: Test IMFMediaSession::Start(). mf/tests: Add a create_media_session() helper. mf: Add seeking support for IMFMediaSession::Start(). mf: Add a session_flush_nodes() helper. mf: Make session_get_node_object() more robust. https://gitlab.winehq.org/wine/wine/-/merge_requests/3572

4 10

[PATCH v5 0/1] MR3736: winmm: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 13 Sep '23

13 Sep '23

-- v5: winmm: Use CRT allocation functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/3736

2 1

Re: [PATCH v4 0/1] MR3736: winmm: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 13 Sep '23

13 Sep '23

On Wed Sep 13 02:57:29 2023 +0000, Alex Henrie wrote: > You're right that it's unnecessary to cast the void pointer returned > from malloc or realloc, so I've removed those casts. Thanks for pointing > that out. As far as the casts in the calls to free, they are all to > avoid warnings about freeing pointers to const strings, so they can't be removed. No, never mind, it's necessary to cast the pointers returned from malloc and realloc here because we add 1 to the pointer before assigning it to a variable. It's unusual but it works. Still, we could simplify this code a bit by only calling realloc. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3736#note_45138

1 0

[PATCH v3 0/1] MR3736: winmm: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 13 Sep '23

13 Sep '23

-- v3: winmm: Use CRT allocation functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/3736

2 2

[PATCH 0/3] MR339: vkd3d-shader/hlsl: Produce 2D resource declarations and loads for tex1D().
by Nikolay Sivov (＠nsivov) 13 Sep '23

13 Sep '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/339

5 11

[PATCH v9 0/5] MR3799: kernelbase: Add implementation of PerfSetULongCounterValue and PerfSetULongLongCounterValue
by Lorenzo Ferrillo (＠llde) 13 Sep '23

13 Sep '23

These functions are used by Visual Studio 2019, when opening or converting some projects. Signed-off-by: Lorenzo Ferrillo <lorenzofersteam(a)live.it> -- v9: kernelbase: Check for PERF_SIZE_LARGE in PerfSetULongLongCounterValue and PerfSetULongCounterValue https://gitlab.winehq.org/wine/wine/-/merge_requests/3799

3 6

[PATCH v2 0/3] MR3784: nsiproxy.sys: Implement ipv6_forward_enumerate_all.
by Helix Graziani (＠TornadoCookie) 13 Sep '23

13 Sep '23

-- v2: wldp: Add WldpQueryWindowsLockdownMode stub. nsiproxy.sys: Implement ipv6_forward_enumerate_all. wldp: Add WldpQueryWindowsLockdownMode stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/3784

3 4

[PATCH 0/1] MR3808: sensapi: Remove unnecessary includes.
by Zebediah Figura (＠zfigura) 13 Sep '23

13 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3808

2 1