January 2024 - Wine-gitlab - list.winehq.org

[PATCH v24 0/2] MR4822: ntdll: Fix: Use pagesize alignment if MEM_REPLACE_PLACEHOLDER is set in flags of NtMapViewOfSection(Ex)
by Felix Münchhalfen 31 Jan '24

31 Jan '24

I had a bugreport here: https://bugs.winehq.org/show_bug.cgi?id=56161 This pull req fixes the bug that programs that do VirtualAlloc(placeholder)/VirtualFree(keep placeholder)/MapViewOfFile3(replace placeholder), do not run. Like the dotnet pe loader in .net 7 for example. It was not clear to me at first, because i didnt notice it on msdn, but the way that Dmitry Timoshkov "hacked" it in https://bugs.winehq.org/show_bug.cgi?id=56122 is actually (nearly) how it is supposed to happen according to msdn. >From here: https://learn.microsoft.com/en-us/windows/win32/api/memoryapi/nf-memoryapi-… ![image](/uploads/58614927d38c15d4c23517aa5dc09d77/image.png) So thanks to Dmitry Timoshkov. If you are interested you could also look into the thing i mentioned in the bug report, that MapViewOfFile3 doesn't round down to 64k, but, i don't think this is a serious problem yet. Edit: I found out that under windows, the alignment constraint is not fully lifted but, it is only required to be pagesize aligned if MEM_REPLACE_PLACEHOLDER is present in the flags. To clarify why i want this in wine. The PE Loader of .net (see here https://github.com/dotnet/runtime/blob/f21dc6c3dceb6ea76bef73e2a026c770aaed…) does align with page size. Not with 64k. This breaks a .net 7 app during load up, that will execute otherwise just execute fine. -- v24: kernelbase: Added a test for MapViewOfFile3 with MEM_REPLACE_PLACEHOLDER https://gitlab.winehq.org/wine/wine/-/merge_requests/4822

1 2

[PATCH v22 0/2] MR4822: ntdll: Fix: Use pagesize alignment if MEM_REPLACE_PLACEHOLDER is set in flags of NtMapViewOfSection(Ex)
by Felix Münchhalfen 31 Jan '24

31 Jan '24

I had a bugreport here: https://bugs.winehq.org/show_bug.cgi?id=56161 This pull req fixes the bug that programs that do VirtualAlloc(placeholder)/VirtualFree(keep placeholder)/MapViewOfFile3(replace placeholder), do not run. Like the dotnet pe loader in .net 7 for example. It was not clear to me at first, because i didnt notice it on msdn, but the way that Dmitry Timoshkov "hacked" it in https://bugs.winehq.org/show_bug.cgi?id=56122 is actually (nearly) how it is supposed to happen according to msdn. >From here: https://learn.microsoft.com/en-us/windows/win32/api/memoryapi/nf-memoryapi-… ![image](/uploads/58614927d38c15d4c23517aa5dc09d77/image.png) So thanks to Dmitry Timoshkov. If you are interested you could also look into the thing i mentioned in the bug report, that MapViewOfFile3 doesn't round down to 64k, but, i don't think this is a serious problem yet. Edit: I found out that under windows, the alignment constraint is not fully lifted but, it is only required to be pagesize aligned if MEM_REPLACE_PLACEHOLDER is present in the flags. To clarify why i want this in wine. The PE Loader of .net (see here https://github.com/dotnet/runtime/blob/f21dc6c3dceb6ea76bef73e2a026c770aaed…) does align with page size. Not with 64k. This breaks a .net 7 app during load up, that will execute otherwise just execute fine. -- v22: kernelbase: Added a test for MapViewOfFile3 with MEM_REPLACE_PLACEHOLDER https://gitlab.winehq.org/wine/wine/-/merge_requests/4822

1 3

[PATCH 0/1] MR621: vkd3d: Use uint64_t for the size in vkd3d_gpu_va_allocator_allocate.
by Jacek Caban (＠jacek) 31 Jan '24

31 Jan '24

Avoids value truncation in 32-bit builds and fixes clang warning: ``` ../libs/vkd3d/libs/vkd3d/device.c:2157:14: warning: result of comparison of constant 4294967296 with expression of type 'size_t' (aka 'unsigned int') is always true [-Wtautological-constant-out-of-range-compare] if (size <= VKD3D_VA_SLAB_SIZE && allocator->free_slab) ~~~~ ^ ~~~~~~~~~~~~~~~~~~ ``` -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/621

2 1

[PATCH 0/4] MR4983: mfreadwrite/tests: Test source reader transforms with video processing attributes.
by Rémi Bernon 31 Jan '24

31 Jan '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4983

2 6

Re: [PATCH v2 0/1] MR4985: windows.globalization: Add IIterable_HSTRING impl to IVectorView_HSTRING.
by Helix Graziani (＠TornadoCookie) 31 Jan '24

31 Jan '24

On Wed Jan 31 20:20:40 2024 +0000, Rémi Bernon wrote: > Fwiw there is already an implementation of this in > `dlls/windows.media.speech/vector.c`, you should probably copy the > relevant parts of the file there. Will do, had no idea that existed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4985#note_59718

1 0

[PATCH v6 0/11] MR4982: Draft: Load and play MIDI
by Yuxuan Shui (＠yshui) 31 Jan '24

31 Jan '24

There are still some issues I need to fix, mainly around timing conversion between MIDI and dmusic. Right now MIDI files seem to be cut off before the end is reached. Please have a look at the general approach in the meantime, I need to know if this is the right way to do this or not. -- v6: debug dmusic: Don't stop instrument downloading early on failure. dmime: Create a band track for MIDI segments. dmband: Move band.c to dmusic dmband: Implement getting/setting GUID_BandParam on band tracks. https://gitlab.winehq.org/wine/wine/-/merge_requests/4982

3 14

[PATCH v3 0/6] MR2298: winewinrt: Introduce new WinRT common module.
by Rémi Bernon 31 Jan '24

31 Jan '24

The idea I have is to use this module to declare class stubs until there is a good reason to split them to dedicated modules. WinRT modules aren't usually loaded directly, and instead the registry is queried to figure which module to load for which class. This would help avoiding unnecessary proliferation of stub WinRT modules, while at the same time allowing to factor WinRT foundation code (such as vector / async, etc...) between the modules that seem to deserve to be implemented separately. The relevant classes could then be split out to dedicated modules on a as-needed basis, when they get fleshed out. -- v3: winewinrt: Factor IAsyncOperation<boolean> implementations. winewinrt: Factor IAsyncInfo implementations. winewinrt: Move Vector<HSTRING> from windows.media.speech. widl: Write C type names for function parameters. winewinrt: Factor Vector<IInspectable> implementations. winewinrt: Introduce new static library. https://gitlab.winehq.org/wine/wine/-/merge_requests/2298

4 12

[PATCH v5 0/10] MR4982: Draft: Load and play MIDI
by Yuxuan Shui (＠yshui) 31 Jan '24

31 Jan '24

There are still some issues I need to fix, mainly around timing conversion between MIDI and dmusic. Right now MIDI files seem to be cut off before the end is reached. Please have a look at the general approach in the meantime, I need to know if this is the right way to do this or not. -- v5: dmusic: Don't stop instrument downloading early on failure. dmime: Create a band track for MIDI segments. dmband: Move band.c to dmusic dmband: Implement getting/setting GUID_BandParam on band tracks. https://gitlab.winehq.org/wine/wine/-/merge_requests/4982

3 11

Re: [PATCH v2 0/1] MR4985: windows.globalization: Add IIterable_HSTRING impl to IVectorView_HSTRING.
by Rémi Bernon 31 Jan '24

31 Jan '24

Fwiw there is already an implementation of this in `dlls/windows.media.speech/vector.c`, you should probably copy the relevant parts of the file there. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4985#note_59714

1 0

[PATCH v4 0/10] MR4982: Draft: Load and play MIDI
by Yuxuan Shui (＠yshui) 31 Jan '24

31 Jan '24

There are still some issues I need to fix, mainly around timing conversion between MIDI and dmusic. Right now MIDI files seem to be cut off before the end is reached. Please have a look at the general approach in the meantime, I need to know if this is the right way to do this or not. -- v4: dmusic: Don't stop instrument downloading early on failure. dmime: Create a band track for MIDI segments. dmband: Move band.c to dmusic dmband: Implement setting GUID_BandParam on band tracks. dmime/test: Add test for getting band track from midi file. dmime: Implement IDirectMusicTrack_Play for MIDI tracks. dmime: Implement getting/setting TempoParam for MIDI tracks. dmime: Parse MIDI files. dmime: Add stubs for MIDI tracks https://gitlab.winehq.org/wine/wine/-/merge_requests/4982

3 11