January 2024 - Wine-gitlab - list.winehq.org

[PATCH v3 0/1] MR4973: ntdll: Add stub for RtlGetDeviceFamilyInfoEnum.
by Louis Lenders (＠xe) 30 Jan '24

30 Jan '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56259 Note: the stub now returns for the last two parameters the values that the testbots gave me (DEVICEFAMILYINFOENUM_DESKTOP and DEVICEFAMILYDEVICEFORM_UNKNOWN). The first parameter returned some value that I don't get (like 0xa00004a63066d), for now i set it to 0, as the Webview installer didn't use this anyway (null pointer). -- v3: ntdll: Add stub for RtlGetDeviceFamilyInfoEnum. https://gitlab.winehq.org/wine/wine/-/merge_requests/4973

2 1

[PATCH v2 0/2] MR4973: ntdll: Add stub for RtlGetDeviceFamilyInfoEnum.
by Louis Lenders (＠xe) 30 Jan '24

30 Jan '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56259 Note: the stub now returns for the last two parameters the values that the testbots gave me (DEVICEFAMILYINFOENUM_DESKTOP and DEVICEFAMILYDEVICEFORM_UNKNOWN). The first parameter returned some value that I don't get (like 0xa00004a63066d), for now i set it to 0, as the Webview installer didn't use this anyway (null pointer). -- v2: ntdll: Add stub for RtlGetDeviceFamilyInfoEnum. https://gitlab.winehq.org/wine/wine/-/merge_requests/4973

2 2

[PATCH v2 0/10] MR607: Draft: vkd3d-shader/ir: Introduce a simple CFG structurizer.
by Giovanni Mascellani (＠giomasce) 30 Jan '24

30 Jan '24

This goes atop !598 and !603. -- v2: vkd3d-shader/ir: Introduce a simple control flow graph structurizer. vkd3d-shader/ir: Materialize SSA registers to temporaries. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/607

3 18

[PATCH 0/2] MR4964: winebus.sys: Fix Unity crashing with certain input devices connected.
by Arek Hiler (＠ivyl) 30 Jan '24

30 Jan '24

Affected games: Phasmophobia, Lethal Company. The games do not use joystick input but Unity Input subsystem is initialized and that's enough to cause stack overflow when it tries to parse 8 bit hat switches. Most joysticks and some mice have hats. I own 2 Thrustmaster devices and this fixes the problem with them plugged in. I've also seen [report descriptors shared by Proton users](https://github.com/ValveSoftware/Proton/issues/7284) that reported the crash. The real devices always use 4 bits only. This MR was tested using a few dinput test programs (upstream Wine) and Elite Dangerous (change was applied on top of the Proton tree). Singular hat works. I don't have anything with more than that though. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4964

3 7

[PATCH 0/1] MR4973: ntdll: Add stub for RtlGetDeviceFamilyInfoEnum.
by Louis Lenders (＠xe) 30 Jan '24

30 Jan '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56259 Note: the stub now returns for the last two parameters the values that the testbots gave me (DEVICEFAMILYINFOENUM_DESKTOP and DEVICEFAMILYDEVICEFORM_UNKNOWN). The first parameter returned some value that I don't get (like 0xa00004a63066d), for now i set it to 0, as the Webview installer didn't use this anyway (null pointer). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4973

3 2

[PATCH 0/1] MR4972: mfplat/tests: Skip tests that require d3d9 support.
by Nikolay Sivov (＠nsivov) 30 Jan '24

30 Jan '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4972

2 1

[PATCH 0/5] MR4971: comdlg32: Fix item data in resolutions combobox.
by Brendan McGrath (＠redmcg) 30 Jan '24

30 Jan '24

This MR fixes a few issues in the printdlg and adds the printer name to stc1. This fixes some of the issues in the Quicken Print Dialog from the tax summary. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4971

2 5

Re: [PATCH v9 0/1] MR4940: bug #56065 - add stub for GetAnycastIpAddressTable()
by Huw Davies (＠huw) 30 Jan '24

30 Jan '24

Huw Davies (@huw) commented about include/netioapi.h: > LARGE_INTEGER CreationTimeStamp; > } MIB_UNICASTIPADDRESS_ROW, *PMIB_UNICASTIPADDRESS_ROW; > > +typedef struct _MIB_ANYCASTIPADDRESS_ROW { Please move the opening brace to the next line. Additionally, let's move this below the unicast table definition below. Further, please add the function prototype (with the others, near the end). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4940#note_59470

1 0

Re: [PATCH v9 0/1] MR4940: bug #56065 - add stub for GetAnycastIpAddressTable()
by Huw Davies (＠huw) 30 Jan '24

30 Jan '24

Huw Davies (@huw) commented about dlls/iphlpapi/iphlpapi_main.c: > row->CreationTimeStamp.QuadPart = stat->creation_time; > } > > +DWORD WINAPI GetAnycastIpAddressTable(ADDRESS_FAMILY family, MIB_ANYCASTIPADDRESS_TABLE **table) > +{ > + FIXME( "(%u, %p) stub\n", family, table ); > + if (!table || (family != AF_INET && family != AF_INET6 && family != AF_UNSPEC)) > + return ERROR_INVALID_PARAMETER; > + There are some trailing spaces on this line - please remove (but leave the blank line). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4940#note_59471

1 0

Re: [PATCH v9 0/1] MR4940: bug #56065 - add stub for GetAnycastIpAddressTable()
by Huw Davies (＠huw) 30 Jan '24

30 Jan '24

Huw Davies (@huw) commented about dlls/iphlpapi/iphlpapi_main.c: > row->CreationTimeStamp.QuadPart = stat->creation_time; > } > > +DWORD WINAPI GetAnycastIpAddressTable(ADDRESS_FAMILY family, MIB_ANYCASTIPADDRESS_TABLE **table) Could you move this so that it doesn't split the Unicast implementation, perhaps below `GetUnicastIpAddressTable()`? Also, please capitalize the first leteter of 'add' in the commit message. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4940#note_59469

1 0