January 2024 - Wine-gitlab - list.winehq.org

Re: [PATCH v3 0/2] MR4251: windows.ui: Add stubs for InputPane class
by Fabian Maurer (＠DarkShadow44) 21 Jan '24

21 Jan '24

On Sun Jan 21 11:55:06 2024 +0000, Rémi Bernon wrote: > ```suggestion:-0+0 > static HRESULT WINAPI inputpane2_TryShow( IInputPane2 *iface, boolean > *result ) > ``` fixed -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4251#note_58333

1 0

Re: [PATCH v3 0/2] MR4251: windows.ui: Add stubs for InputPane class
by Fabian Maurer (＠DarkShadow44) 21 Jan '24

21 Jan '24

On Sun Jan 21 11:55:05 2024 +0000, Rémi Bernon wrote: > ```suggestion:-0+0 > IUnknown_AddRef( (IUnknown *)*out ); > ``` fixed -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4251#note_58332

1 0

Re: [PATCH v3 0/1] MR4251: windows.ui: Add stubs for InputPane class
by Fabian Maurer (＠DarkShadow44) 21 Jan '24

21 Jan '24

On Sun Jan 21 11:55:05 2024 +0000, Rémi Bernon wrote: > Probably should be your name? whoops, copy&paste. fixed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4251#note_58331

1 0

Re: [PATCH v3 0/1] MR4251: windows.ui: Add stubs for InputPane class
by Fabian Maurer (＠DarkShadow44) 21 Jan '24

21 Jan '24

On Sun Jan 21 11:55:05 2024 +0000, Rémi Bernon wrote: > The file should be named `inputpaneinterop.idl`. thanks, fixed -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4251#note_58330

1 0

Re: [PATCH v3 0/1] MR4251: windows.ui: Add stubs for InputPane class
by Fabian Maurer (＠DarkShadow44) 21 Jan '24

21 Jan '24

On Sun Jan 21 11:55:04 2024 +0000, Rémi Bernon wrote: > In SDK headers `10.0.20348.0` there's also a: > `static(Windows.UI.ViewManagement.IInputPaneStatics2, > Windows.Foundation.UniversalApiContract, 8.0)` ah, a newer version. added. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4251#note_58329

1 0

Re: [PATCH v3 0/1] MR4251: windows.ui: Add stubs for InputPane class
by Fabian Maurer (＠DarkShadow44) 21 Jan '24

21 Jan '24

On Sun Jan 21 11:55:04 2024 +0000, Rémi Bernon wrote: > Please don't use camelcase. fixed -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4251#note_58328

1 0

[PATCH 0/1] MR4895: server: Avoid unloading of HKU .Default registry branch.
by Bernhard Übelacker 21 Jan '24

21 Jan '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55000 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4895

1 1

Re: [PATCH v3 0/1] MR4251: windows.ui: Add stubs for InputPane class
by Rémi Bernon 21 Jan '24

21 Jan '24

Also I think it'd be better to split the include changes from the stub implementation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4251#note_58325

1 0

Re: [PATCH v3 0/1] MR4251: windows.ui: Add stubs for InputPane class
by Rémi Bernon 21 Jan '24

21 Jan '24

Rémi Bernon (@rbernon) commented about dlls/windows.ui/inputpane.c: > + factory_GetRuntimeClassName, > + factory_GetTrustLevel, > + /* IActivationFactory methods */ > + factory_ActivateInstance, > +}; > + > +DEFINE_IINSPECTABLE( inputpane_interop, IInputPaneInterop, struct inputpane_statics, IActivationFactory_iface ); > + > +static HRESULT WINAPI inputpane_interop_GetForWindow(IInputPaneInterop *iface, HWND window, REFIID riid, void **inputpane) > +{ > + struct inputpane_statics *impl = impl_from_IInputPaneInterop(iface); > + > + TRACE("(window %p, riid %s, inputpane %p)\n", window, debugstr_guid( riid ), inputpane); > + > + factory_ActivateInstance(&impl->IActivationFactory_iface, (IInspectable**)inputpane); > + return S_OK; ```suggestion:-7+0 static HRESULT WINAPI inputpane_interop_GetForWindow( IInputPaneInterop *iface, HWND window, REFIID riid, void **inputpane ) { struct inputpane_statics *impl = impl_from_IInputPaneInterop( iface ); TRACE( "window %p, riid %s, inputpane %p\n", window, debugstr_guid( riid ), inputpane ); factory_ActivateInstance( &impl->IActivationFactory_iface, (IInspectable **)inputpane ); return S_OK; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4251#note_58324

1 0

Re: [PATCH v3 0/1] MR4251: windows.ui: Add stubs for InputPane class
by Rémi Bernon 21 Jan '24

21 Jan '24

Rémi Bernon (@rbernon) commented about include/windows.ui.viewmanagement.idl: > + ] > + interface IInputPaneVisibilityEventArgs : IInspectable > + { > + [propget] HRESULT OccludedRect([out, retval] Windows.Foundation.Rect *value); > + [propput] HRESULT EnsuredFocusedElementInView([in] boolean value); > + [propget] HRESULT EnsuredFocusedElementInView([out, retval] boolean *value); > + } > + > + [ > + contract(Windows.Foundation.UniversalApiContract, 1.0), > + exclusiveto(Windows.UI.ViewManagement.InputPane), > + uuid(95f4af3a-ef47-424a-9741-fd2815eba2bd) > + ] > + interface IInputPaneStatics : IInspectable > + { > + HRESULT GetForCurrentView([out, retval] Windows.UI.ViewManagement.InputPane **inputPane); Please don't use camelcase. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4251#note_58318

1 0