November 2024 - Wine-gitlab

[PATCH v7 0/6] MR6640: propsys: Support converting to BSTR for PropVariantToVariant.
by Ziqing Hui (＠zhui) 08 Nov '24

08 Nov '24

This is based on top of !6526, will mark ready after !6526 is merged. -- v7: https://gitlab.winehq.org/wine/wine/-/merge_requests/6640

4 13

Re: [PATCH v3 0/1] MR5522: sppc: Add stub SLInstallLicense().
by Alex Henrie (＠alexhenrie) 08 Nov '24

08 Nov '24

> I'm not enthusiastic anymore about championing my patches, knowing I can always maintain a local patchset or submit them to Proton It's no use sending them to Proton because the same people who maintain Wine and Wine Staging also maintain Proton. You could try to get the patches accepted in another Wine derivative, but I think a bigger problem may be that the infinite-sleep workaround kind of only works by accident, so even though it works for the current version of MS Office, I expect that it will break in a future version. I hate to say it, but your time and energy, which I greatly appreciate, would probably be better spent on other Wine bugs. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5522#note_86895

1 0

[PATCH v5 0/1] MR6790: ntdll: use __wine_unix_spawnvp() to invoke unmount command.
by Michael Lelli (＠toadking) 08 Nov '24

08 Nov '24

Fix umounting filesystems mounted on paths with spaces. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57391 -- v5: ntdll: use __wine_unix_spawnvp() to invoke unmount command. https://gitlab.winehq.org/wine/wine/-/merge_requests/6790

3 3

[PATCH v4 0/1] MR6790: ntdll: use __wine_unix_spawnvp() to invoke unmount command.
by Michael Lelli (＠toadking) 08 Nov '24

08 Nov '24

Fix umounting filesystems mounted on paths with spaces. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57391 -- v4: ntdll: use __wine_unix_spawnvp() to invoke unmount command. https://gitlab.winehq.org/wine/wine/-/merge_requests/6790

3 2

[PATCH v3 0/2] MR6783: winegstreamer: Fix a memory/resource leak.
by Conor McCarthy (＠cmccarthy) 08 Nov '24

08 Nov '24

References held by contained stream objects must use an internal refcount, otherwise they prevent release of the media source if Start() and Shutdown() are not called. -- v3: winegstreamer: Introduce an internal refcount in media source objects. mfplat/tests: Test the refcount before the media source is released. https://gitlab.winehq.org/wine/wine/-/merge_requests/6783

3 4

[PATCH v3 0/1] MR6790: ntdll: use __wine_unix_spawnvp() to invoke unmount command.
by Michael Lelli (＠toadking) 08 Nov '24

08 Nov '24

Fix umounting filesystems mounted on paths with spaces. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57391 -- v3: ntdll: use __wine_unix_spawnvp() to invoke unmount command. https://gitlab.winehq.org/wine/wine/-/merge_requests/6790

2 2

[PATCH v2 0/1] MR6790: ntdll: use posix_spawn() to invoke unmount command instead of system().
by Michael Lelli (＠toadking) 08 Nov '24

08 Nov '24

Fix umounting filesystems mounted on paths with spaces. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57391 -- v2: ntdll: use posix_spawn() to invoke unmount command instead of system(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6790

3 2

[PATCH 0/1] MR6790: ntdll: use fork()/exec() to invoke unmount command instead of system().
by Michael Lelli (＠toadking) 08 Nov '24

08 Nov '24

Fix umounting filesystems mounted on paths with spaces. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57391 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6790

3 2

[PATCH 0/1] MR6772: d3dx9: Add semi-stub for D3DXOptimizeVertices.
by Alex Henrie (＠alexhenrie) 08 Nov '24

08 Nov '24

This submission is practically identical to [Vijay Kiran Kamuju's improved version](https://list.winehq.org/mailman3/hyperkitty/list/wine-devel(a)wine… of [Christian Costa's D3DXOptimizeVertices patch in Staging](https://github.com/wine-staging/wine-staging/blob/master/patches/d…. The only changes I made were adding the "Vertex order will not be optimal" message to match [the similar message in D3DXOptimizeFaces](https://gitlab.winehq.org/wine/wine/-/blob/eeabbe812ffc3…, removing the extra newlines around the function, and changing `%x` to `%lx` in the tests to resolve warnings. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47776 Signed-off-by: Vijay Kiran Kamuju <infyquest(a)gmail.com> Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6772

3 5

Re: [PATCH v7 0/2] MR6737: comctl32/toolbar: forward unhandled WM_NOTIFY
by Zhiyi Zhang (＠zhiyi) 08 Nov '24

08 Nov '24

On Thu Nov 7 19:56:04 2024 +0000, Alanas wrote: > <div><a target="_blank" > href="https://gitlab.winehq.org/wine/wine/-/blob/6db2812411d45ca4b4d15dea9a00577e…"><code>pager.c</code>:<pre><code > lang="c">static BOOL PAGER_AdjustBuffer(PAGER_INFO *infoPtr, INT > size)
{
 if (!infoPtr->pwszBuffer)
 > infoPtr->pwszBuffer = Alloc(size);
 else if > (infoPtr->nBufferSize < size)
 infoPtr->pwszBuffer = > ReAlloc(infoPtr->pwszBuffer, size);

 if > (!infoPtr->pwszBuffer) return FALSE;
 if (infoPtr->nBufferSize > < size) infoPtr->nBufferSize = size;

 return > TRUE;
}</code></pre></a>Why is this function designed to leak old > <code>infoPtr->pwszBuffer</code> when <code>ReAlloc(infoPtr->pwszBuffer, > size)</code> returns <code>NULL</code>?</div> No. It's a bug. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6737#note_86878

1 0